[Buildroot] [git commit] modem-manager: update package prompt name

[Buildroot] [git commit] modem-manager: update package prompt name

[Thomas Petazzoni]

commit: https://git.buildroot.net/buildroot/commit/?id=de46ba290d2152261e29ef5339d8ea4adbbaf132
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Rename the prompt string for consistency with the package directory
name.

Cc: Aleksander Morgado <aleksander@aleksander.es>
Cc: Carlos Santos <casantos@datacom.com.br>
Cc: Petr Vorel <petr.vorel@gmail.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
Acked-by: Petr Vorel <petr.vorel@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/modem-manager/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
index 226f82f4f6..c4c723776d 100644
--- a/package/modem-manager/Config.in
+++ b/package/modem-manager/Config.in
@@ -1,5 +1,5 @@
 config BR2_PACKAGE_MODEM_MANAGER
-	bool "modemmanager"
+	bool "modem-manager"
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus

[Buildroot] [git commit] modem-manager: update package prompt name

[Petr Vorel]

Hi Baruch, Thomas,

> commit: https://git.buildroot.net/buildroot/commit/?id=de46ba290d2152261e29ef5339d8ea4adbbaf132
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

> Rename the prompt string for consistency with the package directory
> name.

> Cc: Aleksander Morgado <aleksander@aleksander.es>
> Cc: Carlos Santos <casantos@datacom.com.br>
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> Reviewed-by: Yegor Yefremov <yegorslists@googlemail.com>
> Acked-by: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/modem-manager/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> index 226f82f4f6..c4c723776d 100644
> --- a/package/modem-manager/Config.in
> +++ b/package/modem-manager/Config.in
> @@ -1,5 +1,5 @@
>  config BR2_PACKAGE_MODEM_MANAGER
> -	bool "modemmanager"
> +	bool "modem-manager"
Sorry I should have thought twice before acking this.
It's not that important, but better would be to call it ModemManager, as that's its name.
And network-manager (called now networkmanager) as NetworkManager...

Kind regards,
Petr

[Buildroot] [git commit] modem-manager: update package prompt name

[Petr Vorel]

Hi Baruch, Thomas,

> > commit: https://git.buildroot.net/buildroot/commit/?id=de46ba290d2152261e29ef5339d8ea4adbbaf132
> > branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

> > Rename the prompt string for consistency with the package directory
> > name.

> >  config BR2_PACKAGE_MODEM_MANAGER
> > -	bool "modemmanager"
> > +	bool "modem-manager"
> Sorry I should have thought twice before acking this.
> It's not that important, but better would be to call it ModemManager, as that's its name.
> And network-manager (called now networkmanager) as NetworkManager...
OK, bool is supposed to be lower case, than it's ok. although it looks a bit
unusual. Maybe I'm too used to Debian package names (modemmanager vs. network-manager).


Kind regards,
Petr

[Buildroot] [git commit] modem-manager: update package prompt name

[Thomas Petazzoni]

Hello,

On Fri, 15 Jun 2018 21:37:54 +0200, Petr Vorel wrote:

> > diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> > index 226f82f4f6..c4c723776d 100644
> > --- a/package/modem-manager/Config.in
> > +++ b/package/modem-manager/Config.in
> > @@ -1,5 +1,5 @@
> >  config BR2_PACKAGE_MODEM_MANAGER
> > -	bool "modemmanager"
> > +	bool "modem-manager"  
> Sorry I should have thought twice before acking this.
> It's not that important, but better would be to call it ModemManager, as that's its name.
> And network-manager (called now networkmanager) as NetworkManager...

We normally try to be consistent between the package/<pkg>/
directory name and the prompt used in menuconfig.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [git commit] modem-manager: update package prompt name

[Petr Vorel]

Hi,

> On Fri, 15 Jun 2018 21:37:54 +0200, Petr Vorel wrote:

> > > diff --git a/package/modem-manager/Config.in b/package/modem-manager/Config.in
> > > index 226f82f4f6..c4c723776d 100644
> > > --- a/package/modem-manager/Config.in
> > > +++ b/package/modem-manager/Config.in
> > > @@ -1,5 +1,5 @@
> > >  config BR2_PACKAGE_MODEM_MANAGER
> > > -	bool "modemmanager"
> > > +	bool "modem-manager"  
> > Sorry I should have thought twice before acking this.
> > It's not that important, but better would be to call it ModemManager, as that's its name.
> > And network-manager (called now networkmanager) as NetworkManager...

> We normally try to be consistent between the package/<pkg>/
> directory name and the prompt used in menuconfig.
Thanks for explaining Thomas.
So, I've sent a patch to fix the same issue with network-manager.


Kind regards,
Petr