* [Buildroot] [PATCH] qt53d: fix install issue with qt5.6
@ 2018-06-11 13:56 Gaël PORTAY
2018-06-11 14:33 ` Romain REIGNIER
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Gaël PORTAY @ 2018-06-11 13:56 UTC (permalink / raw)
To: buildroot
Both plugins `geometryloaders' and `renderplugins' are available since
Qt 5.9.
Fixes:
>>> qt53d 5.6.3 Installing to target
cp -dpf /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*
/home/gportay/src/buildroot/output/target/usr/lib
cp -dpfr /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
/home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
cp: cannot stat '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders': No such file or directory
package/pkg-generic.mk:310: recipe for target '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed' failed
make[2]: *** [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1
Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
---
package/qt5/qt53d/qt53d.mk | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/package/qt5/qt53d/qt53d.mk b/package/qt5/qt53d/qt53d.mk
index 6896b00318..48a931d60b 100644
--- a/package/qt5/qt53d/qt53d.mk
+++ b/package/qt5/qt53d/qt53d.mk
@@ -37,13 +37,19 @@ endef
endif
ifeq ($(BR2_STATIC_LIBS),)
-define QT53D_INSTALL_TARGET_CMDS
- cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
+# Available since 5.9
+define QT53D_INSTALL_TARGET_LATEST
cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geometryloaders $(TARGET_DIR)/usr/lib/qt/plugins
cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/renderplugins $(TARGET_DIR)/usr/lib/qt/plugins
+endef
+endif
+define QT53D_INSTALL_TARGET_CMDS
+ cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/sceneparsers $(TARGET_DIR)/usr/lib/qt/plugins
cp -dpfr $(STAGING_DIR)/usr/qml/Qt3D $(TARGET_DIR)/usr/qml
cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick $(TARGET_DIR)/usr/qml
+ $(QT53D_INSTALL_TARGET_LATEST)
$(QT53D_INSTALL_TARGET_EXAMPLES)
endef
endif
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt53d: fix install issue with qt5.6
2018-06-11 13:56 [Buildroot] [PATCH] qt53d: fix install issue with qt5.6 Gaël PORTAY
@ 2018-06-11 14:33 ` Romain REIGNIER
2018-06-11 14:44 ` Gaël PORTAY
2018-06-17 12:58 ` Thomas Petazzoni
2018-07-18 21:11 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Romain REIGNIER @ 2018-06-11 14:33 UTC (permalink / raw)
To: buildroot
This patch make sense. Sorry for the regression with my last contribution.
Le lun. 11 juin 2018 ? 21:56, Ga?l PORTAY <gael.portay@savoirfairelinux.com>
a ?crit :
> Both plugins `geometryloaders' and `renderplugins' are available since
> Qt 5.9.
>
> Fixes:
>
> >>> qt53d 5.6.3 Installing to target
> cp -dpf
> /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*
> /home/gportay/src/buildroot/output/target/usr/lib
> cp -dpfr
> /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
> /home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
> cp: cannot stat
> '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders':
> No such file or directory
> package/pkg-generic.mk:310: recipe for target
> '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed'
> failed
> make[2]: ***
> [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed]
> Error 1
>
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
> package/qt5/qt53d/qt53d.mk | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/package/qt5/qt53d/qt53d.mk b/package/qt5/qt53d/qt53d.mk
> index 6896b00318..48a931d60b 100644
> --- a/package/qt5/qt53d/qt53d.mk
> +++ b/package/qt5/qt53d/qt53d.mk
> @@ -37,13 +37,19 @@ endef
> endif
>
> ifeq ($(BR2_STATIC_LIBS),)
> -define QT53D_INSTALL_TARGET_CMDS
> - cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
> +ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
> +# Available since 5.9
> +define QT53D_INSTALL_TARGET_LATEST
> cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geometryloaders
> $(TARGET_DIR)/usr/lib/qt/plugins
> cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/renderplugins
> $(TARGET_DIR)/usr/lib/qt/plugins
> +endef
> +endif
> +define QT53D_INSTALL_TARGET_CMDS
> + cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
> cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/sceneparsers
> $(TARGET_DIR)/usr/lib/qt/plugins
> cp -dpfr $(STAGING_DIR)/usr/qml/Qt3D $(TARGET_DIR)/usr/qml
> cp -dpfr $(STAGING_DIR)/usr/qml/QtQuick $(TARGET_DIR)/usr/qml
> + $(QT53D_INSTALL_TARGET_LATEST)
> $(QT53D_INSTALL_TARGET_EXAMPLES)
> endef
> endif
> --
> 2.11.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180611/f10e1095/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt53d: fix install issue with qt5.6
2018-06-11 14:33 ` Romain REIGNIER
@ 2018-06-11 14:44 ` Gaël PORTAY
0 siblings, 0 replies; 5+ messages in thread
From: Gaël PORTAY @ 2018-06-11 14:44 UTC (permalink / raw)
To: buildroot
Romain,
On Mon, Jun 11, 2018 at 10:33:44PM +0800, Romain REIGNIER wrote:
> This patch make sense. Sorry for the regression with my last contribution.
>
No worries about the regression ;)
I added you in cc to let you know that I am fixing an issue with 5.6. I
hope it will no break what you have fixed. You probably know more things
about qt3d than me :).
Regards,
Gael
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt53d: fix install issue with qt5.6
2018-06-11 13:56 [Buildroot] [PATCH] qt53d: fix install issue with qt5.6 Gaël PORTAY
2018-06-11 14:33 ` Romain REIGNIER
@ 2018-06-17 12:58 ` Thomas Petazzoni
2018-07-18 21:11 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-06-17 12:58 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 11 Jun 2018 09:56:55 -0400, Ga?l PORTAY wrote:
> Both plugins `geometryloaders' and `renderplugins' are available since
> Qt 5.9.
>
> Fixes:
>
> >>> qt53d 5.6.3 Installing to target
> cp -dpf /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*
> /home/gportay/src/buildroot/output/target/usr/lib
> cp -dpfr /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
> /home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
> cp: cannot stat '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders': No such file or directory
> package/pkg-generic.mk:310: recipe for target '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed' failed
> make[2]: *** [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1
>
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
> ---
> package/qt5/qt53d/qt53d.mk | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt53d: fix install issue with qt5.6
2018-06-11 13:56 [Buildroot] [PATCH] qt53d: fix install issue with qt5.6 Gaël PORTAY
2018-06-11 14:33 ` Romain REIGNIER
2018-06-17 12:58 ` Thomas Petazzoni
@ 2018-07-18 21:11 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-07-18 21:11 UTC (permalink / raw)
To: buildroot
>>>>> "Ga?l" == Ga?l PORTAY <gael.portay@savoirfairelinux.com> writes:
> Both plugins `geometryloaders' and `renderplugins' are available since
> Qt 5.9.
> Fixes:
>>>> qt53d 5.6.3 Installing to target
> cp -dpf /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/libQt53D*.so.*
> /home/gportay/src/buildroot/output/target/usr/lib
> cp -dpfr /home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders
> /home/gportay/src/buildroot/output/target/usr/lib/qt/plugins
> cp: cannot stat '/home/gportay/src/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/lib/qt/plugins/geometryloaders': No such file or directory
> package/pkg-generic.mk:310: recipe for target '/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed' failed
> make[2]: *** [/home/gportay/src/buildroot/output/build/qt53d-5.6.3/.stamp_target_installed] Error 1
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
Committed to 2018.02.x and 2018.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-18 21:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-11 13:56 [Buildroot] [PATCH] qt53d: fix install issue with qt5.6 Gaël PORTAY
2018-06-11 14:33 ` Romain REIGNIER
2018-06-11 14:44 ` Gaël PORTAY
2018-06-17 12:58 ` Thomas Petazzoni
2018-07-18 21:11 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox