* [Buildroot] [PATCH] wampcc: new package
@ 2018-06-26 9:53 Sven Neumann
2018-06-26 19:40 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Sven Neumann @ 2018-06-26 9:53 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sven Neumann <neumann@teufel.de>
---
package/Config.in | 1 +
package/wampcc/Config.in | 13 +++++++++++++
package/wampcc/wampcc.hash | 2 ++
package/wampcc/wampcc.mk | 14 ++++++++++++++
4 files changed, 30 insertions(+)
create mode 100644 package/wampcc/Config.in
create mode 100644 package/wampcc/wampcc.hash
create mode 100644 package/wampcc/wampcc.mk
diff --git a/package/Config.in b/package/Config.in
index c5365547a4..d5612b5b61 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1487,6 +1487,7 @@ menu "Networking"
source "package/sofia-sip/Config.in"
source "package/thrift/Config.in"
source "package/usbredir/Config.in"
+ source "package/wampcc/Config.in"
source "package/zeromq/Config.in"
source "package/zmqpp/Config.in"
source "package/zyre/Config.in"
diff --git a/package/wampcc/Config.in b/package/wampcc/Config.in
new file mode 100644
index 0000000000..055f21a43d
--- /dev/null
+++ b/package/wampcc/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_WAMPCC
+ bool "wampcc"
+ depends on !BR2_STATIC_LIBS
+ select BR2_PACKAGE_LIBUV
+ select BR2_PACKAGE_JANSSON
+ select BR2_PACKAGE_OPENSSL
+ help
+ wampcc is C++ library that implements the Web Application Messaging Protocol protocol.
+
+ https://github.com/darrenjs/wampcc
+
+comment "wampcc needs a toolchain w/ dynamic library"
+ depends on BR2_STATIC_LIBS
diff --git a/package/wampcc/wampcc.hash b/package/wampcc/wampcc.hash
new file mode 100644
index 0000000000..9c3af366e9
--- /dev/null
+++ b/package/wampcc/wampcc.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 b3c3633b4c6a74d7ac8a676a7ea30fbfde7ae19aa1fc37de3b8aa3a553b674a2 wampcc-v1.6.tar.gz
diff --git a/package/wampcc/wampcc.mk b/package/wampcc/wampcc.mk
new file mode 100644
index 0000000000..d8e093f679
--- /dev/null
+++ b/package/wampcc/wampcc.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# wampcc
+#
+################################################################################
+
+WAMPCC_VERSION = v1.6
+WAMPCC_SITE = $(call github,darrenjs,wampcc,$(WAMPCC_VERSION))
+WAMPCC_DEPENDENCIES = host-pkgconf libuv jansson openssl
+WAMPCC_INSTALL_STAGING = YES
+WAMPCC_LICENSE = MIT
+WAMPCC_LICENSE_FILES = LICENSE
+
+$(eval $(cmake-package))
--
2.14.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] wampcc: new package
2018-06-26 9:53 [Buildroot] [PATCH] wampcc: new package Sven Neumann
@ 2018-06-26 19:40 ` Thomas Petazzoni
2018-06-28 13:50 ` [Buildroot] [PATCH 1/2] " Sven Neumann
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-06-26 19:40 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 26 Jun 2018 11:53:23 +0200, Sven Neumann wrote:
> Signed-off-by: Sven Neumann <neumann@teufel.de>
> ---
> package/Config.in | 1 +
> package/wampcc/Config.in | 13 +++++++++++++
> package/wampcc/wampcc.hash | 2 ++
> package/wampcc/wampcc.mk | 14 ++++++++++++++
Missing entry in DEVELOPERS file.
> diff --git a/package/wampcc/Config.in b/package/wampcc/Config.in
> new file mode 100644
> index 0000000000..055f21a43d
> --- /dev/null
> +++ b/package/wampcc/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_WAMPCC
> + bool "wampcc"
> + depends on !BR2_STATIC_LIBS
> + select BR2_PACKAGE_LIBUV
You need to replicate the dependencies of libuv.
> + select BR2_PACKAGE_JANSSON
> + select BR2_PACKAGE_OPENSSL
> + help
> + wampcc is C++ library that implements the Web Application Messaging Protocol protocol.
This line needs to be wrapped. Please run ./utils/check-package on your
package submissions, it detects a few coding style issues.
> diff --git a/package/wampcc/wampcc.hash b/package/wampcc/wampcc.hash
> new file mode 100644
> index 0000000000..9c3af366e9
> --- /dev/null
> +++ b/package/wampcc/wampcc.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 b3c3633b4c6a74d7ac8a676a7ea30fbfde7ae19aa1fc37de3b8aa3a553b674a2 wampcc-v1.6.tar.gz
A hash for the license file would be nice to have.
> diff --git a/package/wampcc/wampcc.mk b/package/wampcc/wampcc.mk
> new file mode 100644
> index 0000000000..d8e093f679
> --- /dev/null
> +++ b/package/wampcc/wampcc.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# wampcc
> +#
> +################################################################################
> +
> +WAMPCC_VERSION = v1.6
> +WAMPCC_SITE = $(call github,darrenjs,wampcc,$(WAMPCC_VERSION))
> +WAMPCC_DEPENDENCIES = host-pkgconf libuv jansson openssl
> +WAMPCC_INSTALL_STAGING = YES
> +WAMPCC_LICENSE = MIT
> +WAMPCC_LICENSE_FILES = LICENSE
> +
> +$(eval $(cmake-package))
Otherwise, looks good to me.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] wampcc: new package
2018-06-26 19:40 ` Thomas Petazzoni
@ 2018-06-28 13:50 ` Sven Neumann
2018-06-28 13:50 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc Sven Neumann
2018-06-28 19:37 ` [Buildroot] [PATCH 1/2] wampcc: new package Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Sven Neumann @ 2018-06-28 13:50 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sven Neumann <neumann@teufel.de>
---
package/Config.in | 1 +
package/wampcc/Config.in | 19 +++++++++++++++++++
package/wampcc/wampcc.hash | 3 +++
package/wampcc/wampcc.mk | 14 ++++++++++++++
4 files changed, 37 insertions(+)
create mode 100644 package/wampcc/Config.in
create mode 100644 package/wampcc/wampcc.hash
create mode 100644 package/wampcc/wampcc.mk
diff --git a/package/Config.in b/package/Config.in
index c5365547a4..d5612b5b61 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1487,6 +1487,7 @@ menu "Networking"
source "package/sofia-sip/Config.in"
source "package/thrift/Config.in"
source "package/usbredir/Config.in"
+ source "package/wampcc/Config.in"
source "package/zeromq/Config.in"
source "package/zmqpp/Config.in"
source "package/zyre/Config.in"
diff --git a/package/wampcc/Config.in b/package/wampcc/Config.in
new file mode 100644
index 0000000000..e7cf6b26fd
--- /dev/null
+++ b/package/wampcc/Config.in
@@ -0,0 +1,19 @@
+config BR2_PACKAGE_WAMPCC
+ bool "wampcc"
+ depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_barrier_*
+ depends on BR2_USE_MMU # fork()
+ depends on !BR2_STATIC_LIBS
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
+ select BR2_PACKAGE_LIBUV
+ select BR2_PACKAGE_JANSSON
+ select BR2_PACKAGE_OPENSSL
+ help
+ wampcc is a C++ library that implements the Web Application
+ Messaging Protocol.
+
+ https://github.com/darrenjs/wampcc
+
+comment "wampcc needs a toolchain w/ NPTL, dynamic library"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
+ depends on BR2_USE_MMU
+ depends on BR2_TOOLCHAIN_HAS_SYNC_4
diff --git a/package/wampcc/wampcc.hash b/package/wampcc/wampcc.hash
new file mode 100644
index 0000000000..162dcab0ec
--- /dev/null
+++ b/package/wampcc/wampcc.hash
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 b3c3633b4c6a74d7ac8a676a7ea30fbfde7ae19aa1fc37de3b8aa3a553b674a2 wampcc-v1.6.tar.gz
+sha256 bd185b1ec8a292d42b42346757ff6e198073e13c1e080e9ea548d34dd42d30d8 LICENSE
diff --git a/package/wampcc/wampcc.mk b/package/wampcc/wampcc.mk
new file mode 100644
index 0000000000..d8e093f679
--- /dev/null
+++ b/package/wampcc/wampcc.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# wampcc
+#
+################################################################################
+
+WAMPCC_VERSION = v1.6
+WAMPCC_SITE = $(call github,darrenjs,wampcc,$(WAMPCC_VERSION))
+WAMPCC_DEPENDENCIES = host-pkgconf libuv jansson openssl
+WAMPCC_INSTALL_STAGING = YES
+WAMPCC_LICENSE = MIT
+WAMPCC_LICENSE_FILES = LICENSE
+
+$(eval $(cmake-package))
--
2.14.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc
2018-06-28 13:50 ` [Buildroot] [PATCH 1/2] " Sven Neumann
@ 2018-06-28 13:50 ` Sven Neumann
2018-06-28 19:38 ` Thomas Petazzoni
2018-06-28 19:37 ` [Buildroot] [PATCH 1/2] wampcc: new package Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Sven Neumann @ 2018-06-28 13:50 UTC (permalink / raw)
To: buildroot
Also move packages from my old email company address to the new one.
Signed-off-by: Sven Neumann <neumann@teufel.de>
---
DEVELOPERS | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/DEVELOPERS b/DEVELOPERS
index 27e24896fb..5bf1a1ac15 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1880,12 +1880,11 @@ F: package/lcdproc/
F: package/python-influxdb/
N: Sven Neumann <neumann@teufel.de>
-F: package/gstreamer1/gst1-libav/
-
-N: Sven Neumann <s.neumann@raumfeld.com>
F: package/glib-networking/
+F: package/gstreamer1/gst1-libav/
F: package/libmms/
F: package/orc/
+F: package/wampcc/
N: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
F: package/mmc-utils/
--
2.14.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc
2018-06-28 13:50 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc Sven Neumann
@ 2018-06-28 19:38 ` Thomas Petazzoni
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-06-28 19:38 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 28 Jun 2018 15:50:09 +0200, Sven Neumann wrote:
> Also move packages from my old email company address to the new one.
>
> Signed-off-by: Sven Neumann <neumann@teufel.de>
> ---
> DEVELOPERS | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
I've applied, after reworking the commit to not add wampcc (done in the
previous commit) and adjusting the commit log accordingly.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] wampcc: new package
2018-06-28 13:50 ` [Buildroot] [PATCH 1/2] " Sven Neumann
2018-06-28 13:50 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc Sven Neumann
@ 2018-06-28 19:37 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-06-28 19:37 UTC (permalink / raw)
To: buildroot
Hello,
I've applied, after fixing a few issues, see below.
On Thu, 28 Jun 2018 15:50:08 +0200, Sven Neumann wrote:
> Signed-off-by: Sven Neumann <neumann@teufel.de>
> ---
> package/Config.in | 1 +
> package/wampcc/Config.in | 19 +++++++++++++++++++
> package/wampcc/wampcc.hash | 3 +++
> package/wampcc/wampcc.mk | 14 ++++++++++++++
> 4 files changed, 37 insertions(+)
> create mode 100644 package/wampcc/Config.in
> create mode 100644 package/wampcc/wampcc.hash
> create mode 100644 package/wampcc/wampcc.mk
The entry to the DEVELOPERS file was still missing. I know it was in
your second patch, but the addition of wampcc to DEVELOPERS should have
been with this patch.
> diff --git a/package/wampcc/Config.in b/package/wampcc/Config.in
> new file mode 100644
> index 0000000000..e7cf6b26fd
> --- /dev/null
> +++ b/package/wampcc/Config.in
> @@ -0,0 +1,19 @@
> +config BR2_PACKAGE_WAMPCC
> + bool "wampcc"
> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_barrier_*
> + depends on BR2_USE_MMU # fork()
> + depends on !BR2_STATIC_LIBS
> + depends on BR2_TOOLCHAIN_HAS_SYNC_4
Those dependencies come from libuv, some instead of "fork()" and
"pthread_barrier_" which are the reason for libuv to have those
dependencies, we prefer to have the reason for wampcc to have those
dependencies, i.e the fact that it selects libuv. So:
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
and so on.
Also, another dependency was missing: BR2_TOOLCHAIN_HAS_GCC_BUG_64735.
The C++ code uses std::shared_future, which doesn't work on gcc < 7.x
on some architectures.
As I said above, I fixed those issues and applied.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-28 19:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-26 9:53 [Buildroot] [PATCH] wampcc: new package Sven Neumann
2018-06-26 19:40 ` Thomas Petazzoni
2018-06-28 13:50 ` [Buildroot] [PATCH 1/2] " Sven Neumann
2018-06-28 13:50 ` [Buildroot] [PATCH 2/2] DEVELOPERS: add myself for wampcc Sven Neumann
2018-06-28 19:38 ` Thomas Petazzoni
2018-06-28 19:37 ` [Buildroot] [PATCH 1/2] wampcc: new package Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox