* [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: correct dependencies comment display conditions
@ 2018-07-03 17:05 Baruch Siach
2018-07-03 17:05 ` [Buildroot] [PATCH 2/2] kf5-networkmanager-qt: " Baruch Siach
2018-07-03 19:40 ` [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: " Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2018-07-03 17:05 UTC (permalink / raw)
To: buildroot
Display the dependencies comment only when modem-manager is enabled.
Otherwise, a toolchain configuration change would not make the package
selectable.
Cc: Pierre Ducroquet <pinaraf@pinaraf.info>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/kf5/kf5-modemmanager-qt/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/kf5/kf5-modemmanager-qt/Config.in b/package/kf5/kf5-modemmanager-qt/Config.in
index c291b886f5cd..f08de5567220 100644
--- a/package/kf5/kf5-modemmanager-qt/Config.in
+++ b/package/kf5/kf5-modemmanager-qt/Config.in
@@ -16,4 +16,5 @@ config BR2_PACKAGE_KF5_MODEMMANAGER_QT
comment "kf5-modemmanager-qt needs toolchain w/ threads"
depends on BR2_USE_MMU
+ depends on BR2_PACKAGE_MODEM_MANAGER
depends on !BR2_TOOLCHAIN_HAS_THREADS
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 2/2] kf5-networkmanager-qt: correct dependencies comment display conditions
2018-07-03 17:05 [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: correct dependencies comment display conditions Baruch Siach
@ 2018-07-03 17:05 ` Baruch Siach
2018-07-03 19:40 ` [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: " Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2018-07-03 17:05 UTC (permalink / raw)
To: buildroot
Display the dependencies comment only when network-manager is enabled.
Otherwise, a toolchain configuration change would not make the package
selectable.
Cc: Pierre Ducroquet <pinaraf@pinaraf.info>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/kf5/kf5-networkmanager-qt/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/kf5/kf5-networkmanager-qt/Config.in b/package/kf5/kf5-networkmanager-qt/Config.in
index 277e08866a1b..6b309f08047a 100644
--- a/package/kf5/kf5-networkmanager-qt/Config.in
+++ b/package/kf5/kf5-networkmanager-qt/Config.in
@@ -16,4 +16,5 @@ config BR2_PACKAGE_KF5_NETWORKMANAGER_QT
comment "kf5-networkmanager-qt needs toolchain w/ threads"
depends on BR2_USE_MMU
+ depends on BR2_PACKAGE_NETWORK_MANAGER
depends on !BR2_TOOLCHAIN_HAS_THREADS
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: correct dependencies comment display conditions
2018-07-03 17:05 [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: correct dependencies comment display conditions Baruch Siach
2018-07-03 17:05 ` [Buildroot] [PATCH 2/2] kf5-networkmanager-qt: " Baruch Siach
@ 2018-07-03 19:40 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-07-03 19:40 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 3 Jul 2018 20:05:17 +0300, Baruch Siach wrote:
> Display the dependencies comment only when modem-manager is enabled.
> Otherwise, a toolchain configuration change would not make the package
> selectable.
>
> Cc: Pierre Ducroquet <pinaraf@pinaraf.info>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/kf5/kf5-modemmanager-qt/Config.in | 1 +
> 1 file changed, 1 insertion(+)
Series applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-03 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 17:05 [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: correct dependencies comment display conditions Baruch Siach
2018-07-03 17:05 ` [Buildroot] [PATCH 2/2] kf5-networkmanager-qt: " Baruch Siach
2018-07-03 19:40 ` [Buildroot] [PATCH 1/2] kf5-modemmanager-qt: " Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox