Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30
@ 2018-07-09 22:42 Bernd Kuhls
  2018-07-09 22:58 ` Bernd Kuhls
  2018-07-10  8:00 ` Arnout Vandecappelle
  0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2018-07-09 22:42 UTC (permalink / raw)
  To: buildroot

Added license hash.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/tar/tar.hash | 5 +++--
 package/tar/tar.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/tar/tar.hash b/package/tar/tar.hash
index e5634566e0..efa7bb3520 100644
--- a/package/tar/tar.hash
+++ b/package/tar/tar.hash
@@ -1,3 +1,4 @@
 # Locally calculated after checking signature
-sha256	402dcfd0022fd7a1f2c5611f5c61af1cd84910a760a44a688e18ddbff4e9f024	tar-1.29.tar.xz
-sha256	9173f222464dd3676118408840da5990527062b5c7daf6487bed7c396c45bfb1	tar-1.29.cpio.gz
+sha256 f1bf92dbb1e1ab27911a861ea8dde8208ee774866c46c0bb6ead41f4d1f4d2d3  tar-1.30.tar.xz
+sha256 29a12eebde6bda10b74ede856a159cb6cf8739fdc4d1b48354c9e79c4f658ee3  tar-1.30.cpio.gz
+sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
diff --git a/package/tar/tar.mk b/package/tar/tar.mk
index 6f609d7a02..227475dd3f 100644
--- a/package/tar/tar.mk
+++ b/package/tar/tar.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-TAR_VERSION = 1.29
+TAR_VERSION = 1.30
 TAR_SOURCE = tar-$(TAR_VERSION).tar.xz
 TAR_SITE = $(BR2_GNU_MIRROR)/tar
 # busybox installs in /bin, so we need tar to install as well in /bin
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30
  2018-07-09 22:42 [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30 Bernd Kuhls
@ 2018-07-09 22:58 ` Bernd Kuhls
  2018-07-10  8:02   ` Arnout Vandecappelle
  2018-07-10  8:00 ` Arnout Vandecappelle
  1 sibling, 1 reply; 6+ messages in thread
From: Bernd Kuhls @ 2018-07-09 22:58 UTC (permalink / raw)
  To: buildroot

Am Tue, 10 Jul 2018 00:42:18 +0200 schrieb Bernd Kuhls:

> Added license hash.
> 
> Signed-off-by: Bernd Kuhls
> <bernd.kuhls@t-online.de>
> ---
>  package/tar/tar.hash | 5 +++--
>  package/tar/tar.mk   | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)

Hi,

marked the patch as rejected on patchworks after I found

https://git.buildroot.net/buildroot/commit/support/dependencies/check-
host-tar.sh?id=b8fa273d500b44153e9939f0a100e97db2ff63ed

Sorry for the noise.

Regards, Bernd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30
  2018-07-09 22:42 [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30 Bernd Kuhls
  2018-07-09 22:58 ` Bernd Kuhls
@ 2018-07-10  8:00 ` Arnout Vandecappelle
  2018-07-15 15:48   ` Yann E. MORIN
  1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2018-07-10  8:00 UTC (permalink / raw)
  To: buildroot

 Hi Bernd,

 Have you seen b8fa273d500b4?

    check-host-tar.sh: blacklist tar 1.30+

    Tar 1.30 changed the --numeric-owner output for filenames > 100 characters,
    leading to hash mismatches for the tar archives we create ourselves from
    git.  This is really a fix for a bug in earlier tar versions regarding
    deterministic output, so it is unlikely to be reverted in later versions.

    For more details, see:
    http://lists.busybox.net/pipermail/buildroot/2018-January/211222.html

    To work around this issue, blacklist tar 1.30+ similar to how we do it for
    pre-1.17 versions so Buildroot falls back to building host-tar.


 Marked as Rejected...


 Regards,
 Arnout

On 10-07-18 00:42, Bernd Kuhls wrote:
> Added license hash.
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/tar/tar.hash | 5 +++--
>  package/tar/tar.mk   | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/tar/tar.hash b/package/tar/tar.hash
> index e5634566e0..efa7bb3520 100644
> --- a/package/tar/tar.hash
> +++ b/package/tar/tar.hash
> @@ -1,3 +1,4 @@
>  # Locally calculated after checking signature
> -sha256	402dcfd0022fd7a1f2c5611f5c61af1cd84910a760a44a688e18ddbff4e9f024	tar-1.29.tar.xz
> -sha256	9173f222464dd3676118408840da5990527062b5c7daf6487bed7c396c45bfb1	tar-1.29.cpio.gz
> +sha256 f1bf92dbb1e1ab27911a861ea8dde8208ee774866c46c0bb6ead41f4d1f4d2d3  tar-1.30.tar.xz
> +sha256 29a12eebde6bda10b74ede856a159cb6cf8739fdc4d1b48354c9e79c4f658ee3  tar-1.30.cpio.gz
> +sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  COPYING
> diff --git a/package/tar/tar.mk b/package/tar/tar.mk
> index 6f609d7a02..227475dd3f 100644
> --- a/package/tar/tar.mk
> +++ b/package/tar/tar.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -TAR_VERSION = 1.29
> +TAR_VERSION = 1.30
>  TAR_SOURCE = tar-$(TAR_VERSION).tar.xz
>  TAR_SITE = $(BR2_GNU_MIRROR)/tar
>  # busybox installs in /bin, so we need tar to install as well in /bin
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30
  2018-07-09 22:58 ` Bernd Kuhls
@ 2018-07-10  8:02   ` Arnout Vandecappelle
  0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2018-07-10  8:02 UTC (permalink / raw)
  To: buildroot



On 10-07-18 00:58, Bernd Kuhls wrote:
> Am Tue, 10 Jul 2018 00:42:18 +0200 schrieb Bernd Kuhls:
> 
>> Added license hash.
>>
>> Signed-off-by: Bernd Kuhls
>> <bernd.kuhls@t-online.de>
>> ---
>>  package/tar/tar.hash | 5 +++--
>>  package/tar/tar.mk   | 2 +-
>>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> Hi,
> 
> marked the patch as rejected on patchworks after I found
> 
> https://git.buildroot.net/buildroot/commit/support/dependencies/check-
> host-tar.sh?id=b8fa273d500b44153e9939f0a100e97db2ff63ed
> 
> Sorry for the noise.

 Oops, I hadn't seen this mail yet...

 Sorry for the noise ^2 :-)

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30
  2018-07-10  8:00 ` Arnout Vandecappelle
@ 2018-07-15 15:48   ` Yann E. MORIN
  2018-07-17 21:34     ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2018-07-15 15:48 UTC (permalink / raw)
  To: buildroot

Arnout, All,

On 2018-07-10 10:00 +0200, Arnout Vandecappelle spake thusly:
>  Have you seen b8fa273d500b4?
> 
>     check-host-tar.sh: blacklist tar 1.30+
> 
>     Tar 1.30 changed the --numeric-owner output for filenames > 100 characters,
>     leading to hash mismatches for the tar archives we create ourselves from
>     git.  This is really a fix for a bug in earlier tar versions regarding
>     deterministic output, so it is unlikely to be reverted in later versions.
> 
>     For more details, see:
>     http://lists.busybox.net/pipermail/buildroot/2018-January/211222.html
> 
>     To work around this issue, blacklist tar 1.30+ similar to how we do it for
>     pre-1.17 versions so Buildroot falls back to building host-tar.
> 
> 
>  Marked as Rejected...

Yet at some point, we will want to bump tar to a newer version.

What I would suggest is that we pin the host version to 1.29, and still
allow bumping the target version, so maybe something like:

    TAR_VERSION = 1.30
    HOST_TAR_VERSION = 1.29

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30
  2018-07-15 15:48   ` Yann E. MORIN
@ 2018-07-17 21:34     ` Peter Korsgaard
  0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-07-17 21:34 UTC (permalink / raw)
  To: buildroot

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Arnout, All,
 > On 2018-07-10 10:00 +0200, Arnout Vandecappelle spake thusly:
 >> Have you seen b8fa273d500b4?
 >> 
 >> check-host-tar.sh: blacklist tar 1.30+
 >> 
 >> Tar 1.30 changed the --numeric-owner output for filenames > 100 characters,
 >> leading to hash mismatches for the tar archives we create ourselves from
 >> git.  This is really a fix for a bug in earlier tar versions regarding
 >> deterministic output, so it is unlikely to be reverted in later versions.
 >> 
 >> For more details, see:
 >> http://lists.busybox.net/pipermail/buildroot/2018-January/211222.html
 >> 
 >> To work around this issue, blacklist tar 1.30+ similar to how we do it for
 >> pre-1.17 versions so Buildroot falls back to building host-tar.
 >> 
 >> 
 >> Marked as Rejected...

 > Yet at some point, we will want to bump tar to a newer version.

 > What I would suggest is that we pin the host version to 1.29, and still
 > allow bumping the target version, so maybe something like:

 >     TAR_VERSION = 1.30
 >     HOST_TAR_VERSION = 1.29

Yes, that is possible. It does add a bit of extra complexity (subdirs
for patches, 2 versions in tar.hash, ..), but we already have that for
packages where we have a version selection.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-07-17 21:34 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-09 22:42 [Buildroot] [PATCH 1/1] package/tar: bump version to 1.30 Bernd Kuhls
2018-07-09 22:58 ` Bernd Kuhls
2018-07-10  8:02   ` Arnout Vandecappelle
2018-07-10  8:00 ` Arnout Vandecappelle
2018-07-15 15:48   ` Yann E. MORIN
2018-07-17 21:34     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox