* [Buildroot] [PATCH 1/2] bind: fix build with openssl
@ 2018-07-18 18:53 Baruch Siach
2018-07-18 18:53 ` [Buildroot] [PATCH 2/2] bind: fix build with zlib Baruch Siach
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Baruch Siach @ 2018-07-18 18:53 UTC (permalink / raw)
To: buildroot
The bind configure.in uses AC_TRY_RUN that is not compatible with cross
compile. Disable eddsa unconditionally since it requires a newer OpenSSL
version than we currently have. Enable aes; this is always supported in
current OpenSSL versions.
Fixes:
http://autobuild.buildroot.net/results/3ed/3edb1659954b00401b68ffc7e1c8b3c29581c0e4/
http://autobuild.buildroot.net/results/025/025e377b51b39ba34647636ad0d0661a3cb95572/
http://autobuild.buildroot.net/results/725/7250564e780e43e793ae6c8c526985e5519681f4/
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/bind/bind.mk | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index c4429ef6cc7f..e71eddcd7f00 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -61,7 +61,9 @@ BIND_CONF_ENV += \
ac_cv_func_EVP_sha512=yes
BIND_CONF_OPTS += \
--with-openssl=$(STAGING_DIR)/usr LIBS="-lz" \
- --with-ecdsa=yes
+ --with-ecdsa=yes \
+ --with-eddsa=no \
+ --with-aes=yes
# GOST cipher support requires openssl extra engines
ifeq ($(BR2_PACKAGE_OPENSSL_ENGINES),y)
BIND_CONF_OPTS += --with-gost=yes
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] bind: fix build with zlib
2018-07-18 18:53 [Buildroot] [PATCH 1/2] bind: fix build with openssl Baruch Siach
@ 2018-07-18 18:53 ` Baruch Siach
2018-07-19 21:41 ` Peter Korsgaard
2018-07-19 7:12 ` [Buildroot] [PATCH 1/2] bind: fix build with openssl Thomas Petazzoni
2018-07-19 21:41 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2018-07-18 18:53 UTC (permalink / raw)
To: buildroot
The bind configure.in now checks for "${with_zlib}/include/zlib.h".
Remove the redundant "include/".
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/bind/bind.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/bind/bind.mk b/package/bind/bind.mk
index e71eddcd7f00..d478a7f6e12c 100644
--- a/package/bind/bind.mk
+++ b/package/bind/bind.mk
@@ -33,7 +33,7 @@ BIND_CONF_OPTS = \
--enable-filter-aaaa
ifeq ($(BR2_PACKAGE_ZLIB),y)
-BIND_CONF_OPTS += --with-zlib=$(STAGING_DIR)/usr/include
+BIND_CONF_OPTS += --with-zlib=$(STAGING_DIR)/usr
BIND_DEPENDENCIES += zlib
else
BIND_CONF_OPTS += --without-zlib
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/2] bind: fix build with openssl
2018-07-18 18:53 [Buildroot] [PATCH 1/2] bind: fix build with openssl Baruch Siach
2018-07-18 18:53 ` [Buildroot] [PATCH 2/2] bind: fix build with zlib Baruch Siach
@ 2018-07-19 7:12 ` Thomas Petazzoni
2018-07-19 21:41 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-07-19 7:12 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 18 Jul 2018 21:53:03 +0300, Baruch Siach wrote:
> The bind configure.in uses AC_TRY_RUN that is not compatible with cross
> compile. Disable eddsa unconditionally since it requires a newer OpenSSL
> version than we currently have. Enable aes; this is always supported in
> current OpenSSL versions.
>
> Fixes:
> http://autobuild.buildroot.net/results/3ed/3edb1659954b00401b68ffc7e1c8b3c29581c0e4/
> http://autobuild.buildroot.net/results/025/025e377b51b39ba34647636ad0d0661a3cb95572/
> http://autobuild.buildroot.net/results/725/7250564e780e43e793ae6c8c526985e5519681f4/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/bind/bind.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Both applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] bind: fix build with openssl
2018-07-18 18:53 [Buildroot] [PATCH 1/2] bind: fix build with openssl Baruch Siach
2018-07-18 18:53 ` [Buildroot] [PATCH 2/2] bind: fix build with zlib Baruch Siach
2018-07-19 7:12 ` [Buildroot] [PATCH 1/2] bind: fix build with openssl Thomas Petazzoni
@ 2018-07-19 21:41 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-07-19 21:41 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> The bind configure.in uses AC_TRY_RUN that is not compatible with cross
> compile. Disable eddsa unconditionally since it requires a newer OpenSSL
> version than we currently have. Enable aes; this is always supported in
> current OpenSSL versions.
> Fixes:
> http://autobuild.buildroot.net/results/3ed/3edb1659954b00401b68ffc7e1c8b3c29581c0e4/
> http://autobuild.buildroot.net/results/025/025e377b51b39ba34647636ad0d0661a3cb95572/
> http://autobuild.buildroot.net/results/725/7250564e780e43e793ae6c8c526985e5519681f4/
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed to 2018.02.x and 2018.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-19 21:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-18 18:53 [Buildroot] [PATCH 1/2] bind: fix build with openssl Baruch Siach
2018-07-18 18:53 ` [Buildroot] [PATCH 2/2] bind: fix build with zlib Baruch Siach
2018-07-19 21:41 ` Peter Korsgaard
2018-07-19 7:12 ` [Buildroot] [PATCH 1/2] bind: fix build with openssl Thomas Petazzoni
2018-07-19 21:41 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox