* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
@ 2018-07-17 19:16 Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 2/4] meson: change from global to per package cross-compilation.conf Peter Seiderer
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Peter Seiderer @ 2018-07-17 19:16 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Notes:
Hash not checked against the pgp signature, tried
$ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
gpg: Can't check signature: No public key
Any advice which public key is used to sign the meson package?
Changes v1 -> v2:
- new patch
---
...-RPATH-if-install_rpath-is-not-empty.patch | 32 -------------------
package/meson/meson.hash | 5 ++-
package/meson/meson.mk | 2 +-
3 files changed, 3 insertions(+), 36 deletions(-)
delete mode 100644 package/meson/0001-Only-fix-RPATH-if-install_rpath-is-not-empty.patch
diff --git a/package/meson/0001-Only-fix-RPATH-if-install_rpath-is-not-empty.patch b/package/meson/0001-Only-fix-RPATH-if-install_rpath-is-not-empty.patch
deleted file mode 100644
index 03c1944258..0000000000
--- a/package/meson/0001-Only-fix-RPATH-if-install_rpath-is-not-empty.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-From 53e4920038d5562b7b672fec8b9469fc02eef4ad Mon Sep 17 00:00:00 2001
-From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
-Date: Thu, 10 May 2018 21:57:49 +0200
-Subject: [PATCH] Only fix RPATH if install_rpath is not empty
-
-Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
----
- mesonbuild/scripts/meson_install.py | 8 +++++++-
- 1 file changed, 7 insertions(+), 1 deletion(-)
-
-diff --git a/mesonbuild/scripts/meson_install.py b/mesonbuild/scripts/meson_install.py
-index 013f2a00..f7ff1dcc 100644
---- a/mesonbuild/scripts/meson_install.py
-+++ b/mesonbuild/scripts/meson_install.py
-@@ -368,7 +368,13 @@ def install_targets(d):
- printed_symlink_error = True
- if os.path.isfile(outname):
- try:
-- depfixer.fix_rpath(outname, install_rpath, False)
-+ # Buildroot check-host-rpath script expects RPATH
-+ # But if install_rpath is empty, it will stripped.
-+ # So, preserve it in this case
-+ if install_rpath:
-+ depfixer.fix_rpath(outname, install_rpath, False)
-+ else:
-+ print("Skipping RPATH fixing")
- except SystemExit as e:
- if isinstance(e.code, int) and e.code == 0:
- pass
---
-2.14.3
-
diff --git a/package/meson/meson.hash b/package/meson/meson.hash
index bd9e4114ff..4b17744db6 100644
--- a/package/meson/meson.hash
+++ b/package/meson/meson.hash
@@ -1,4 +1,3 @@
-# Locally calculated after checking pgp signature
-# https://github.com/mesonbuild/meson/releases/download/0.46.1/meson-0.46.1.tar.gz.asc
-sha256 19497a03e7e5b303d8d11f98789a79aba59b5ad4a81bd00f4d099be0212cee78 meson-0.46.1.tar.gz
+# Locally calculated
+sha256 d673de79f7bab064190a5ea06140eaa8415efb386d0121ba549f6d66c555ada6 meson-0.47.1.tar.gz
sha256 cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 COPYING
diff --git a/package/meson/meson.mk b/package/meson/meson.mk
index 28c9e6f202..d110e594f5 100644
--- a/package/meson/meson.mk
+++ b/package/meson/meson.mk
@@ -4,7 +4,7 @@
#
################################################################################
-MESON_VERSION = 0.46.1
+MESON_VERSION = 0.47.1
MESON_SITE = https://github.com/mesonbuild/meson/releases/download/$(MESON_VERSION)
MESON_LICENSE = Apache-2.0
MESON_LICENSE_FILES = COPYING
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 2/4] meson: change from global to per package cross-compilation.conf
2018-07-17 19:16 [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Peter Seiderer
@ 2018-07-17 19:16 ` Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 3/4] libdrm: change to meson build system Peter Seiderer
` (3 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Peter Seiderer @ 2018-07-17 19:16 UTC (permalink / raw)
To: buildroot
Add FOO_MESON_CFLAGS, FOO_MESON_LDFLAGS and FOO_MESON_CXXFLAGS
variables to allow per package additional flags.
Change to buildtype plain as all compiler/linker flags forcing
debug/release are already given via the cross-compilation.conf
file.
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Notes:
- documentation change for new flags missing
- use in pkg-meson.mk the same sed/printf for flags quotation mark
and comma adding
Changes v1 -> v2:
- no changes
---
package/meson/cross-compilation.conf.in | 8 ++++----
package/meson/meson.mk | 6 +++---
package/pkg-meson.mk | 9 +++++++--
3 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
index 0eec74087b..6af03314eb 100644
--- a/package/meson/cross-compilation.conf.in
+++ b/package/meson/cross-compilation.conf.in
@@ -11,10 +11,10 @@ strip = '@TARGET_CROSS at strip'
pkgconfig = '@HOST_DIR@/usr/bin/pkg-config'
[properties]
-c_args = [@TARGET_CFLAGS@]
-c_link_args = [@TARGET_LDFLAGS@]
-cpp_args = [@TARGET_CXXFLAGS@]
-cpp_link_args = [@TARGET_LDFLAGS@]
+c_args = [@TARGET_CFLAGS@ @PKG_TARGET_CFLAGS@]
+c_link_args = [@TARGET_LDFLAGS@ @PKG_TARGET_LDFLAGS@]
+cpp_args = [@TARGET_CXXFLAGS@ @PKG_TARGET_CXXFLAGS@]
+cpp_link_args = [@TARGET_LDFLAGS@ @PKG_TARGET_LDFLAGS@]
[host_machine]
system = 'linux'
diff --git a/package/meson/meson.mk b/package/meson/meson.mk
index d110e594f5..0f2ee2855d 100644
--- a/package/meson/meson.mk
+++ b/package/meson/meson.mk
@@ -20,7 +20,7 @@ HOST_MESON_SED_CFLAGS = $(if $(TARGET_CFLAGS),`printf '"%s"$(comma) ' $(TARGET_C
HOST_MESON_SED_LDFLAGS = $(if $(TARGET_LDFLAGS),`printf '"%s"$(comma) ' $(TARGET_LDFLAGS)`)
HOST_MESON_SED_CXXFLAGS = $(if $(TARGET_CXXFLAGS),`printf '"%s"$(comma) ' $(TARGET_CXXFLAGS)`)
-define HOST_MESON_INSTALL_CROSS_CONF
+define HOST_MESON_INSTALL_CROSS_CONF_IN
mkdir -p $(HOST_DIR)/etc/meson
sed -e "s%@TARGET_CROSS@%$(TARGET_CROSS)%g" \
-e "s%@TARGET_ARCH@%$(ARCH)%g" \
@@ -31,9 +31,9 @@ define HOST_MESON_INSTALL_CROSS_CONF
-e "s%@TARGET_CXXFLAGS@%$(HOST_MESON_SED_CXXFLAGS)%g" \
-e "s%@HOST_DIR@%$(HOST_DIR)%g" \
$(HOST_MESON_PKGDIR)/cross-compilation.conf.in \
- > $(HOST_DIR)/etc/meson/cross-compilation.conf
+ > $(HOST_DIR)/etc/meson/cross-compilation.conf.in
endef
-HOST_MESON_POST_INSTALL_HOOKS += HOST_MESON_INSTALL_CROSS_CONF
+HOST_MESON_POST_INSTALL_HOOKS += HOST_MESON_INSTALL_CROSS_CONF_IN
$(eval $(host-python-package))
diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
index 507e686068..565e10e8fb 100644
--- a/package/pkg-meson.mk
+++ b/package/pkg-meson.mk
@@ -64,12 +64,17 @@ ifeq ($(4),target)
define $(2)_CONFIGURE_CMDS
rm -rf $$($$(PKG)_SRCDIR)/build
mkdir -p $$($$(PKG)_SRCDIR)/build
+ sed -e "s%@PKG_TARGET_CFLAGS@%$$($$(PKG)_MESON_CFLAGS)%g" \
+ -e "s%@PKG_TARGET_LDFLAGS@%$$($$(PKG)_MESON_LDFLAGS)%g" \
+ -e "s%@PKG_TARGET_CXXFLAGS@%$$($$(PKG)_MESON_CXXFLAGS)%g" \
+ $(HOST_DIR)/etc/meson/cross-compilation.conf.in \
+ > $$($$(PKG)_SRCDIR)/build//cross-compilation.conf
PATH=$$(BR_PATH) $$($$(PKG)_CONF_ENV) $$(MESON) \
--prefix=/usr \
--libdir=lib \
--default-library=$(if $(BR2_STATIC_LIBS),static,shared) \
- --buildtype=$(if $(BR2_ENABLE_DEBUG),debug,release) \
- --cross-file=$(HOST_DIR)/etc/meson/cross-compilation.conf \
+ --buildtype=plain \
+ --cross-file=$$($$(PKG)_SRCDIR)/build/cross-compilation.conf \
$$($$(PKG)_CONF_OPTS) \
$$($$(PKG)_SRCDIR) $$($$(PKG)_SRCDIR)/build
endef
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 3/4] libdrm: change to meson build system
2018-07-17 19:16 [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 2/4] meson: change from global to per package cross-compilation.conf Peter Seiderer
@ 2018-07-17 19:16 ` Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 4/4] libinput: bump version to 1.11.0 and convert to meson build Peter Seiderer
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Peter Seiderer @ 2018-07-17 19:16 UTC (permalink / raw)
To: buildroot
- remove legacy patch
0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
- add patch to fix meson atomic ops detection
0003-meson.build-fix-intel-atomics-detection.patch
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Notes:
- convertion from "LIBDRM_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'"
is missing (maybe meson gets it right (?) or use LIBDRM_MESON_CFLAGS
to force it)
Changes v1 -> v2:
- add 0003-meson.build-fix-intel-atomics-detection.patch to fix
sparc compile
---
...le.am-use-pkg-config-to-discover-lib.patch | 162 ------------------
...on.build-fix-intel-atomics-detection.patch | 32 ++++
package/libdrm/libdrm.mk | 71 ++++----
3 files changed, 64 insertions(+), 201 deletions(-)
delete mode 100644 package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
create mode 100644 package/libdrm/0003-meson.build-fix-intel-atomics-detection.patch
diff --git a/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch b/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
deleted file mode 100644
index 0fbe77ef7c..0000000000
--- a/package/libdrm/0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
+++ /dev/null
@@ -1,162 +0,0 @@
-From 57d544ff2f96a26cac07d5be00ff7b67678ae7b8 Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Date: Mon, 18 Dec 2017 13:08:39 +0100
-Subject: [PATCH] configure/Makefile.am: use pkg-config to discover
- libatomic_ops
-
-The configure script currently tests the availability of libatomic_ops
-by checking the presence of atomic_ops.h. While this is good enough as
-an availability test, it is not sufficient as on some platforms,
-libatomic_ops provides an actual shared library against which we
-should be linked to access libatomic_ops functionality.
-
-Therefore, we instead use PKG_CHECK_MODULES() to test the availability
-of libatomic_ops. Besides testing its availability, this also fills in
-the ATOMIC_OPS_LIBS variable with the list of libraries we need to
-link with to use libatomic_ops.
-
-All Mesa drivers that include xf86atomic.h have been updated to link
-against ATOMIC_OPS_LIBS.
-
-Of course, if we're not using libatomic_ops, ATOMIC_OPS_LIBS is empty,
-and we don't link against it.
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-Signed-off-by: Peter Seiderer <ps.report@gmx.net>
-[Bernd: PKG_CHECK_MODULES should not fail when libatomic_ops is missing]
-Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
----
- amdgpu/Makefile.am | 2 +-
- configure.ac | 2 +-
- etnaviv/Makefile.am | 3 ++-
- freedreno/Makefile.am | 3 ++-
- intel/Makefile.am | 3 ++-
- nouveau/Makefile.am | 2 +-
- omap/Makefile.am | 2 +-
- radeon/Makefile.am | 2 +-
- tegra/Makefile.am | 2 +-
- 9 files changed, 12 insertions(+), 9 deletions(-)
-
-diff --git a/amdgpu/Makefile.am b/amdgpu/Makefile.am
-index a1b0d05c..b2bcceff 100644
---- a/amdgpu/Makefile.am
-+++ b/amdgpu/Makefile.am
-@@ -36,7 +36,7 @@ AM_CPPFLAGS = -DAMDGPU_ASIC_ID_TABLE=\"${libdrmdatadir}/amdgpu.ids\"
- libdrm_amdgpu_la_LTLIBRARIES = libdrm_amdgpu.la
- libdrm_amdgpu_ladir = $(libdir)
- libdrm_amdgpu_la_LDFLAGS = -version-number 1:0:0 -no-undefined
--libdrm_amdgpu_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@
-+libdrm_amdgpu_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@ @ATOMIC_OPS_LIBS@
-
- libdrm_amdgpu_la_SOURCES = $(LIBDRM_AMDGPU_FILES)
- amdgpu_asic_id.lo: $(top_srcdir)/data/amdgpu.ids
-diff --git a/configure.ac b/configure.ac
-index 35378b33..501d0871 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -247,7 +247,7 @@ AC_CACHE_CHECK([for native atomic primitives], drm_cv_atomic_primitives, [
- ]],[[]])], [drm_cv_atomic_primitives="Intel"],[])
-
- if test "x$drm_cv_atomic_primitives" = "xnone"; then
-- AC_CHECK_HEADER([atomic_ops.h], drm_cv_atomic_primitives="libatomic-ops")
-+ PKG_CHECK_MODULES(ATOMIC_OPS, [atomic_ops], drm_cv_atomic_primitives="libatomic-ops", true)
- fi
-
- # atomic functions defined in <atomic.h> & libc on Solaris
-diff --git a/etnaviv/Makefile.am b/etnaviv/Makefile.am
-index be96ba86..669cf14f 100644
---- a/etnaviv/Makefile.am
-+++ b/etnaviv/Makefile.am
-@@ -12,7 +12,8 @@ libdrm_etnaviv_la_LDFLAGS = -version-number 1:0:0 -no-undefined
- libdrm_etnaviv_la_LIBADD = \
- ../libdrm.la \
- @PTHREADSTUBS_LIBS@ \
-- @CLOCK_LIB@
-+ @CLOCK_LIB@ \
-+ @ATOMIC_OPS_LIBS@
-
- libdrm_etnaviv_la_SOURCES = $(LIBDRM_ETNAVIV_FILES)
-
-diff --git a/freedreno/Makefile.am b/freedreno/Makefile.am
-index cbb0d031..238407e3 100644
---- a/freedreno/Makefile.am
-+++ b/freedreno/Makefile.am
-@@ -14,7 +14,8 @@ libdrm_freedreno_la_LDFLAGS = -version-number 1:0:0 -no-undefined
- libdrm_freedreno_la_LIBADD = \
- ../libdrm.la \
- @PTHREADSTUBS_LIBS@ \
-- @CLOCK_LIB@
-+ @CLOCK_LIB@ \
-+ @ATOMIC_OPS_LIBS@
-
- libdrm_freedreno_la_SOURCES = $(LIBDRM_FREEDRENO_FILES)
- if HAVE_FREEDRENO_KGSL
-diff --git a/intel/Makefile.am b/intel/Makefile.am
-index c52e8c08..f3635a64 100644
---- a/intel/Makefile.am
-+++ b/intel/Makefile.am
-@@ -38,7 +38,8 @@ libdrm_intel_la_LDFLAGS = -version-number 1:0:0 -no-undefined
- libdrm_intel_la_LIBADD = ../libdrm.la \
- @PTHREADSTUBS_LIBS@ \
- @PCIACCESS_LIBS@ \
-- @CLOCK_LIB@
-+ @CLOCK_LIB@ \
-+ @ATOMIC_OPS_LIBS@
-
- libdrm_intel_la_SOURCES = $(LIBDRM_INTEL_FILES)
-
-diff --git a/nouveau/Makefile.am b/nouveau/Makefile.am
-index 344a8445..a4e6a78b 100644
---- a/nouveau/Makefile.am
-+++ b/nouveau/Makefile.am
-@@ -10,7 +10,7 @@ AM_CFLAGS = \
- libdrm_nouveau_la_LTLIBRARIES = libdrm_nouveau.la
- libdrm_nouveau_ladir = $(libdir)
- libdrm_nouveau_la_LDFLAGS = -version-number 2:0:0 -no-undefined
--libdrm_nouveau_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@
-+libdrm_nouveau_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@ @ATOMIC_OPS_LIBS@
-
- libdrm_nouveau_la_SOURCES = $(LIBDRM_NOUVEAU_FILES)
-
-diff --git a/omap/Makefile.am b/omap/Makefile.am
-index 599bb9de..524afee3 100644
---- a/omap/Makefile.am
-+++ b/omap/Makefile.am
-@@ -7,7 +7,7 @@ AM_CFLAGS = \
- libdrm_omap_la_LTLIBRARIES = libdrm_omap.la
- libdrm_omap_ladir = $(libdir)
- libdrm_omap_la_LDFLAGS = -version-number 1:0:0 -no-undefined
--libdrm_omap_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@
-+libdrm_omap_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@ @ATOMIC_OPS_LIBS@
-
- libdrm_omap_la_SOURCES = omap_drm.c
-
-diff --git a/radeon/Makefile.am b/radeon/Makefile.am
-index e2415314..c27d3c75 100644
---- a/radeon/Makefile.am
-+++ b/radeon/Makefile.am
-@@ -33,7 +33,7 @@ AM_CFLAGS = \
- libdrm_radeon_la_LTLIBRARIES = libdrm_radeon.la
- libdrm_radeon_ladir = $(libdir)
- libdrm_radeon_la_LDFLAGS = -version-number 1:0:1 -no-undefined
--libdrm_radeon_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@
-+libdrm_radeon_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@ @ATOMIC_OPS_LIBS@
-
- libdrm_radeon_la_SOURCES = $(LIBDRM_RADEON_FILES)
-
-diff --git a/tegra/Makefile.am b/tegra/Makefile.am
-index fb40be55..12abe8c4 100644
---- a/tegra/Makefile.am
-+++ b/tegra/Makefile.am
-@@ -9,7 +9,7 @@ AM_CFLAGS = \
- libdrm_tegra_ladir = $(libdir)
- libdrm_tegra_la_LTLIBRARIES = libdrm_tegra.la
- libdrm_tegra_la_LDFLAGS = -version-number 0:0:0 -no-undefined
--libdrm_tegra_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@
-+libdrm_tegra_la_LIBADD = ../libdrm.la @PTHREADSTUBS_LIBS@ @ATOMIC_OPS_LIBS@
-
- libdrm_tegra_la_SOURCES = \
- private.h \
---
-2.14.3
-
diff --git a/package/libdrm/0003-meson.build-fix-intel-atomics-detection.patch b/package/libdrm/0003-meson.build-fix-intel-atomics-detection.patch
new file mode 100644
index 0000000000..141a627bd5
--- /dev/null
+++ b/package/libdrm/0003-meson.build-fix-intel-atomics-detection.patch
@@ -0,0 +1,32 @@
+From f8ca348c8d1b8953ccf019b7dd45ca7d5bf06d24 Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Mon, 16 Jul 2018 23:01:40 +0200
+Subject: [PATCH] meson.build: fix intel atomics detection
+
+Use the stronger compiler.link() test (instead of the weaker
+compiler.compile()) to fix the intel atomics detection.
+
+Fixes false positive in case of sparc compile (buildroot toolchain).
+
+Upstream suggested: https://lists.freedesktop.org/archives/dri-devel/2018-July/183728.html
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 9b443a5..e47ad26 100644
+--- a/meson.build
++++ b/meson.build
+@@ -49,7 +49,7 @@ intel_atomics = false
+ lib_atomics = false
+
+ dep_atomic_ops = dependency('atomic_ops', required : false)
+-if cc.compiles('''
++if cc.links('''
+ int atomic_add(int *i) { return __sync_add_and_fetch (i, 1); }
+ int atomic_cmpxchg(int *i, int j, int k) { return __sync_val_compare_and_swap (i, j, k); }
+ ''',
+--
+2.18.0
+
diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
index 06b1144616..65ed01bb16 100644
--- a/package/libdrm/libdrm.mk
+++ b/package/libdrm/libdrm.mk
@@ -10,111 +10,104 @@ LIBDRM_SITE = https://dri.freedesktop.org/libdrm
LIBDRM_LICENSE = MIT
LIBDRM_INSTALL_STAGING = YES
-# patch 0003-configure-Makefile.am-use-pkg-config-to-discover-lib.patch
-# touching configure.ac/Makefile.am (and host-xutil_util-macros dependency)
-LIBDRM_AUTORECONF = YES
-
LIBDRM_DEPENDENCIES = \
libpthread-stubs \
- host-pkgconf \
- host-xutil_util-macros
+ host-pkgconf
LIBDRM_CONF_OPTS = \
- --disable-cairo-tests \
- --disable-manpages
-
-LIBDRM_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
+ -Dcairo-tests=false \
+ -Dmanpages=false
ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
LIBDRM_DEPENDENCIES += libatomic_ops
ifeq ($(BR2_sparc_v8)$(BR2_sparc_leon3),y)
-LIBDRM_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -DAO_NO_SPARC_V9"
+LIBDRM_MESON_CFLAGS += "\"-DAO_NO_SPARC_V9\","
endif
endif
ifeq ($(BR2_PACKAGE_LIBDRM_INTEL),y)
-LIBDRM_CONF_OPTS += --enable-intel
+LIBDRM_CONF_OPTS += -Dintel=true
LIBDRM_DEPENDENCIES += libpciaccess
else
-LIBDRM_CONF_OPTS += --disable-intel
+LIBDRM_CONF_OPTS += -Dintel=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_RADEON),y)
-LIBDRM_CONF_OPTS += --enable-radeon
+LIBDRM_CONF_OPTS += -Dradeon=true
else
-LIBDRM_CONF_OPTS += --disable-radeon
+LIBDRM_CONF_OPTS += -Dradeon=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_AMDGPU),y)
-LIBDRM_CONF_OPTS += --enable-amdgpu
+LIBDRM_CONF_OPTS += -Damdgpu=true
else
-LIBDRM_CONF_OPTS += --disable-amdgpu
+LIBDRM_CONF_OPTS += -Damdgpu=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_NOUVEAU),y)
-LIBDRM_CONF_OPTS += --enable-nouveau
+LIBDRM_CONF_OPTS += -Dnouveau=true
else
-LIBDRM_CONF_OPTS += --disable-nouveau
+LIBDRM_CONF_OPTS += -Dnouveau=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_VMWGFX),y)
-LIBDRM_CONF_OPTS += --enable-vmwgfx
+LIBDRM_CONF_OPTS += -Dvmwgfx=true
else
-LIBDRM_CONF_OPTS += --disable-vmwgfx
+LIBDRM_CONF_OPTS += -Dvmwgfx=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_OMAP),y)
-LIBDRM_CONF_OPTS += --enable-omap-experimental-api
+LIBDRM_CONF_OPTS += -Domap=true
else
-LIBDRM_CONF_OPTS += --disable-omap-experimental-api
+LIBDRM_CONF_OPTS += -Domap=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_ETNAVIV),y)
-LIBDRM_CONF_OPTS += --enable-etnaviv-experimental-api
+LIBDRM_CONF_OPTS += -Detnaviv=true
else
-LIBDRM_CONF_OPTS += --disable-etnaviv-experimental-api
+LIBDRM_CONF_OPTS += -Detnaviv=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_EXYNOS),y)
-LIBDRM_CONF_OPTS += --enable-exynos-experimental-api
+LIBDRM_CONF_OPTS += -Dexynos=true
else
-LIBDRM_CONF_OPTS += --disable-exynos-experimental-api
+LIBDRM_CONF_OPTS += -Dexynos=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_FREEDRENO),y)
-LIBDRM_CONF_OPTS += --enable-freedreno
+LIBDRM_CONF_OPTS += -Dfreedreno=true
else
-LIBDRM_CONF_OPTS += --disable-freedreno
+LIBDRM_CONF_OPTS += -Dfreedreno=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_TEGRA),y)
-LIBDRM_CONF_OPTS += --enable-tegra-experimental-api
+LIBDRM_CONF_OPTS += -Dtegra=true
else
-LIBDRM_CONF_OPTS += --disable-tegra-experimental-api
+LIBDRM_CONF_OPTS += -Dtegra=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_VC4),y)
-LIBDRM_CONF_OPTS += --enable-vc4
+LIBDRM_CONF_OPTS += -Dvc4=true
else
-LIBDRM_CONF_OPTS += --disable-vc4
+LIBDRM_CONF_OPTS += -Dvc4=false
endif
ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
-LIBDRM_CONF_OPTS += --enable-udev
+LIBDRM_CONF_OPTS += -Dudev=true
LIBDRM_DEPENDENCIES += udev
else
-LIBDRM_CONF_OPTS += --disable-udev
+LIBDRM_CONF_OPTS += -Dudev=false
endif
ifeq ($(BR2_PACKAGE_VALGRIND),y)
-LIBDRM_CONF_OPTS += --enable-valgrind
+LIBDRM_CONF_OPTS += -Dvalgrind=true
LIBDRM_DEPENDENCIES += valgrind
else
-LIBDRM_CONF_OPTS += --disable-valgrind
+LIBDRM_CONF_OPTS += -Dvalgrind=false
endif
ifeq ($(BR2_PACKAGE_LIBDRM_INSTALL_TESTS),y)
-LIBDRM_CONF_OPTS += --enable-install-test-programs
+LIBDRM_CONF_OPTS += -Dinstall-test-programs=true
endif
-$(eval $(autotools-package))
+$(eval $(meson-package))
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 4/4] libinput: bump version to 1.11.0 and convert to meson build
2018-07-17 19:16 [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 2/4] meson: change from global to per package cross-compilation.conf Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 3/4] libdrm: change to meson build system Peter Seiderer
@ 2018-07-17 19:16 ` Peter Seiderer
2018-07-17 20:02 ` [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Baruch Siach
2018-07-17 20:23 ` Eric Le Bihan
4 siblings, 0 replies; 12+ messages in thread
From: Peter Seiderer @ 2018-07-17 19:16 UTC (permalink / raw)
To: buildroot
For details since 1.8.x see [1], [2] and [3].
Build system changed from autotools to meson exclusively
since 1.9.0 (see [1]).
[1] https://lists.freedesktop.org/archives/wayland-devel/2017-October/035469.html
[2] https://lists.freedesktop.org/archives/wayland-devel/2018-February/036957.html
[3] https://lists.freedesktop.org/archives/wayland-devel/2018-June/038349.html
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
- new patch
---
package/libinput/libinput.hash | 10 +++++-----
package/libinput/libinput.mk | 10 +++++-----
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/package/libinput/libinput.hash b/package/libinput/libinput.hash
index 4e64568ca3..5707ee9fa3 100644
--- a/package/libinput/libinput.hash
+++ b/package/libinput/libinput.hash
@@ -1,5 +1,5 @@
-# From https://lists.freedesktop.org/archives/wayland-devel/2017-September/034949.html
-md5 e94e9aa765da9533c23b80b440638de9 libinput-1.8.2.tar.xz
-sha1 1c55462eb598b91c9c360f31170a408fb8d38d22 libinput-1.8.2.tar.xz
-sha256 013518ee0adb2287e6e1f08412efba2137320738cadb5399b783738f04cbab38 libinput-1.8.2.tar.xz
-sha512 555a7680cc8aaf62c5370a865f3aff0a933d42d94a3d8861c072666b02c9e1be45ea39de9a749a9575cdfb613b6150e412e18559d94d4919f21ca4680a3c76a7 libinput-1.8.2.tar.xz
+# From https://lists.freedesktop.org/archives/wayland-devel/2018-June/038349.html
+md5 a182dab52f4d33bc1ef50668dcf53cc6 libinput-1.11.0.tar.xz
+sha1 5c242a99c7e4c678e15f7bd100f94fa338b81240 libinput-1.11.0.tar.xz
+sha256 64a36c4f826f4b5d473bf2cb803122f96390a18243ec810f2ce8ac5076a0bc12 libinput-1.11.0.tar.xz
+sha512 382a6c9ec4aaf13ac209ee5a7f507c7a6d2dd399c5104703ac7c6ac62fb3f393de6f4e15d7895b18c8b8d845ce8fc1f551a90aa7532f0de4cc17e57a09cfe857 libinput-1.11.0.tar.xz
diff --git a/package/libinput/libinput.mk b/package/libinput/libinput.mk
index f904b796b7..8c4870f269 100644
--- a/package/libinput/libinput.mk
+++ b/package/libinput/libinput.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBINPUT_VERSION = 1.8.2
+LIBINPUT_VERSION = 1.11.0
LIBINPUT_SOURCE = libinput-$(LIBINPUT_VERSION).tar.xz
LIBINPUT_SITE = http://www.freedesktop.org/software/libinput
LIBINPUT_DEPENDENCIES = host-pkgconf libevdev mtdev udev
@@ -12,13 +12,13 @@ LIBINPUT_INSTALL_STAGING = YES
LIBINPUT_LICENSE = MIT
LIBINPUT_LICENSE_FILES = COPYING
# Tests need fork, so just disable them everywhere.
-LIBINPUT_CONF_OPTS = --disable-tests --disable-libwacom
+LIBINPUT_CONF_OPTS = -Dtests=false -Dlibwacom=false -Ddocumentation=false
ifeq ($(BR2_PACKAGE_LIBGTK3),y)
-LIBINPUT_CONF_OPTS += --enable-debug-gui
+LIBINPUT_CONF_OPTS += -Ddebug-gui=true
LIBINPUT_DEPENDENCIES += libgtk3
else
-LIBINPUT_CONF_OPTS += --disable-debug-gui
+LIBINPUT_CONF_OPTS += -Ddebug-gui=false
endif
-$(eval $(autotools-package))
+$(eval $(meson-package))
--
2.18.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-17 19:16 [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Peter Seiderer
` (2 preceding siblings ...)
2018-07-17 19:16 ` [Buildroot] [RFC v2 4/4] libinput: bump version to 1.11.0 and convert to meson build Peter Seiderer
@ 2018-07-17 20:02 ` Baruch Siach
2018-07-17 21:23 ` Peter Seiderer
2018-07-17 20:23 ` Eric Le Bihan
4 siblings, 1 reply; 12+ messages in thread
From: Baruch Siach @ 2018-07-17 20:02 UTC (permalink / raw)
To: buildroot
Hi Peter,
Peter Seiderer writes:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Notes:
> Hash not checked against the pgp signature, tried
> $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> gpg: Can't check signature: No public key
>
> Any advice which public key is used to sign the meson package?
The key ID is shown in the message above. You can import the key and
verify with:
gpg --recv-keys 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
gpg --verify meson-0.47.1.tar.gz.asc
gpg: Signature made Wed 11 Jul 2018 12:28:12 AM IDT
gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>" [marginal]
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-17 19:16 [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Peter Seiderer
` (3 preceding siblings ...)
2018-07-17 20:02 ` [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Baruch Siach
@ 2018-07-17 20:23 ` Eric Le Bihan
2018-07-18 20:16 ` Peter Seiderer
4 siblings, 1 reply; 12+ messages in thread
From: Eric Le Bihan @ 2018-07-17 20:23 UTC (permalink / raw)
To: buildroot
Hi!
On 2018-07-17 21:16, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Notes:
> Hash not checked against the pgp signature, tried
> $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> gpg: Can't check signature: No public key
>
> Any advice which public key is used to sign the meson package?
I check the signature as follows:
```
$ gpg --recv-keys 3BF4693BFEEB9428
$ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
gpg: Signature made Tue Jul 10 23:28:12 2018 CEST using RSA key ID
FEEB9428
gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner.
Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB
9428
```
BTW, shouldn't a signed-off-by line be added to the refreshed patch? I
was about to send this package bump, so I can send mine if you want.
Regards,
--
ELB
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-17 20:02 ` [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Baruch Siach
@ 2018-07-17 21:23 ` Peter Seiderer
2018-07-18 3:03 ` Baruch Siach
0 siblings, 1 reply; 12+ messages in thread
From: Peter Seiderer @ 2018-07-17 21:23 UTC (permalink / raw)
To: buildroot
Hello Baruch, Eric,
On Tue, 17 Jul 2018 23:02:32 +0300, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Peter,
>
> Peter Seiderer writes:
>
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > Notes:
> > Hash not checked against the pgp signature, tried
> > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> > gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> > gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> > gpg: Can't check signature: No public key
> >
> > Any advice which public key is used to sign the meson package?
>
> The key ID is shown in the message above. You can import the key and
> verify with:
>
> gpg --recv-keys 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> gpg --verify meson-0.47.1.tar.gz.asc
>
> gpg: Signature made Wed 11 Jul 2018 12:28:12 AM IDT
> gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>" [marginal]
Thanks for the hint!
I get the same warning as Eric:
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB 9428
To 'trust' the signing I need a trust-chain (or an 'official' signed public key) or
an second source where I can compare the fingerprint against? Your seem to have
an 'marginal' trust-chain?
Regards,
Peter
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-17 21:23 ` Peter Seiderer
@ 2018-07-18 3:03 ` Baruch Siach
2018-07-18 19:46 ` Peter Seiderer
0 siblings, 1 reply; 12+ messages in thread
From: Baruch Siach @ 2018-07-18 3:03 UTC (permalink / raw)
To: buildroot
Hi Peter,
Peter Seiderer writes:
> On Tue, 17 Jul 2018 23:02:32 +0300, Baruch Siach <baruch@tkos.co.il> wrote:
>> Peter Seiderer writes:
>>
>> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>> > ---
>> > Notes:
>> > Hash not checked against the pgp signature, tried
>> > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
>> > gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
>> > gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
>> > gpg: Can't check signature: No public key
>> >
>> > Any advice which public key is used to sign the meson package?
>>
>> The key ID is shown in the message above. You can import the key and
>> verify with:
>>
>> gpg --recv-keys 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
>> gpg --verify meson-0.47.1.tar.gz.asc
>>
>> gpg: Signature made Wed 11 Jul 2018 12:28:12 AM IDT
>> gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
>> gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>" [marginal]
>
> Thanks for the hint!
>
> I get the same warning as Eric:
>
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the owner.
> Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB 9428
>
> To 'trust' the signing I need a trust-chain (or an 'official' signed public key) or
> an second source where I can compare the fingerprint against? Your seem to have
> an 'marginal' trust-chain?
I enabled TOFU[1] in my gpg configuration. TOFU makes more sense to me
for my use of gpg.
baruch
[1] https://www.gnupg.org/ftp/people/neal/tofu.pdf
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-18 3:03 ` Baruch Siach
@ 2018-07-18 19:46 ` Peter Seiderer
0 siblings, 0 replies; 12+ messages in thread
From: Peter Seiderer @ 2018-07-18 19:46 UTC (permalink / raw)
To: buildroot
Hello Baruch,
On Wed, 18 Jul 2018 06:03:04 +0300, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Peter,
>
> Peter Seiderer writes:
> > On Tue, 17 Jul 2018 23:02:32 +0300, Baruch Siach <baruch@tkos.co.il> wrote:
> >> Peter Seiderer writes:
> >>
> >> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> >> > ---
> >> > Notes:
> >> > Hash not checked against the pgp signature, tried
> >> > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> >> > gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> >> > gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> >> > gpg: Can't check signature: No public key
> >> >
> >> > Any advice which public key is used to sign the meson package?
> >>
> >> The key ID is shown in the message above. You can import the key and
> >> verify with:
> >>
> >> gpg --recv-keys 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> >> gpg --verify meson-0.47.1.tar.gz.asc
> >>
> >> gpg: Signature made Wed 11 Jul 2018 12:28:12 AM IDT
> >> gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> >> gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>" [marginal]
> >
> > Thanks for the hint!
> >
> > I get the same warning as Eric:
> >
> > gpg: WARNING: This key is not certified with a trusted signature!
> > gpg: There is no indication that the signature belongs to the owner.
> > Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB 9428
> >
> > To 'trust' the signing I need a trust-chain (or an 'official' signed public key) or
> > an second source where I can compare the fingerprint against? Your seem to have
> > an 'marginal' trust-chain?
>
> I enabled TOFU[1] in my gpg configuration. TOFU makes more sense to me
> for my use of gpg.
Thanks for tip, will take look at it and try...
Regards,
Peter
>
> baruch
>
> [1] https://www.gnupg.org/ftp/people/neal/tofu.pdf
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-17 20:23 ` Eric Le Bihan
@ 2018-07-18 20:16 ` Peter Seiderer
2018-07-19 6:00 ` Eric Le Bihan
0 siblings, 1 reply; 12+ messages in thread
From: Peter Seiderer @ 2018-07-18 20:16 UTC (permalink / raw)
To: buildroot
Hello Eric,
On Tue, 17 Jul 2018 22:23:11 +0200, Eric Le Bihan <eric.le.bihan.dev@free.fr> wrote:
> Hi!
>
> On 2018-07-17 21:16, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > Notes:
> > Hash not checked against the pgp signature, tried
> > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> > gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> > gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> > gpg: Can't check signature: No public key
> >
> > Any advice which public key is used to sign the meson package?
>
> I check the signature as follows:
>
> ```
> $ gpg --recv-keys 3BF4693BFEEB9428
> $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> gpg: Signature made Tue Jul 10 23:28:12 2018 CEST using RSA key ID
> FEEB9428
> gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>"
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner.
> Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB
> 9428
> ```
>
> BTW, shouldn't a signed-off-by line be added to the refreshed patch? I
> was about to send this package bump, so I can send mine if you want.
Which Signed-off-by line do you think is missing? Sorry for the double
effort, will send an updated version of the patch series soon (some
fixes for libdrm conversion), maybe better send a Reviewed-by to
my patch?
Regards,
Peter
>
> Regards,
>
> --
> ELB
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-18 20:16 ` Peter Seiderer
@ 2018-07-19 6:00 ` Eric Le Bihan
2018-07-19 20:48 ` Peter Seiderer
0 siblings, 1 reply; 12+ messages in thread
From: Eric Le Bihan @ 2018-07-19 6:00 UTC (permalink / raw)
To: buildroot
On 2018-07-18 22:16, Peter Seiderer wrote:
> Hello Eric,
>
> On Tue, 17 Jul 2018 22:23:11 +0200, Eric Le Bihan <eric.le.bihan.dev@free.fr> wrote:
>
> > Hi!
> >
> > On 2018-07-17 21:16, Peter Seiderer wrote:
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > > ---
> > > Notes:
> > > Hash not checked against the pgp signature, tried
> > > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> > > gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> > > gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> > > gpg: Can't check signature: No public key
> > >
> > > Any advice which public key is used to sign the meson package?
> >
> > I check the signature as follows:
> >
> > ```
> > $ gpg --recv-keys 3BF4693BFEEB9428
> > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> > gpg: Signature made Tue Jul 10 23:28:12 2018 CEST using RSA key ID
> > FEEB9428
> > gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>"
> > gpg: WARNING: This key is not certified with a trusted signature!
> > gpg: There is no indication that the signature belongs to the
> > owner.
> > Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB
> > 9428
> > ```
> >
> > BTW, shouldn't a signed-off-by line be added to the refreshed patch? I
> > was about to send this package bump, so I can send mine if you want.
>
> Which Signed-off-by line do you think is missing? Sorry for the double
> effort, will send an updated version of the patch series soon (some
> fixes for libdrm conversion), maybe better send a Reviewed-by to
> my patch?
Sorry, I misread your patch. I thought it refreshed the
Buildroot-specific patch for fixing RPATH, whereas it removed it. See
commit 7a23af4773665d2ee40e2d4e525746ebe38456dd for details.
This specific patch applies to 0.46.1 but not to 0.47.1, as the function
to modify is not in mesonbuild/scripts/meson_install.py anymore, but in
mesonbuild/minstall.py:
```
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1
2018-07-19 6:00 ` Eric Le Bihan
@ 2018-07-19 20:48 ` Peter Seiderer
0 siblings, 0 replies; 12+ messages in thread
From: Peter Seiderer @ 2018-07-19 20:48 UTC (permalink / raw)
To: buildroot
Hello Eric,
On Thu, 19 Jul 2018 08:00:53 +0200, Eric Le Bihan <eric.le.bihan.dev@free.fr> wrote:
> On 2018-07-18 22:16, Peter Seiderer wrote:
> > Hello Eric,
> >
> > On Tue, 17 Jul 2018 22:23:11 +0200, Eric Le Bihan <eric.le.bihan.dev@free.fr> wrote:
> >
> > > Hi!
> > >
> > > On 2018-07-17 21:16, Peter Seiderer wrote:
> > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > > > ---
> > > > Notes:
> > > > Hash not checked against the pgp signature, tried
> > > > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> > > > gpg: Signature made Di 10 Jul 2018 23:28:12 CEST
> > > > gpg: using RSA key 95181F4EED14FDF4E41B518D3BF4693BFEEB9428
> > > > gpg: Can't check signature: No public key
> > > >
> > > > Any advice which public key is used to sign the meson package?
> > >
> > > I check the signature as follows:
> > >
> > > ```
> > > $ gpg --recv-keys 3BF4693BFEEB9428
> > > $ gpg --verify meson-0.47.1.tar.gz.asc meson-0.47.1.tar.gz
> > > gpg: Signature made Tue Jul 10 23:28:12 2018 CEST using RSA key ID
> > > FEEB9428
> > > gpg: Good signature from "Jussi Pakkanen <jpakkane@gmail.com>"
> > > gpg: WARNING: This key is not certified with a trusted signature!
> > > gpg: There is no indication that the signature belongs to the
> > > owner.
> > > Primary key fingerprint: 9518 1F4E ED14 FDF4 E41B 518D 3BF4 693B FEEB
> > > 9428
> > > ```
> > >
> > > BTW, shouldn't a signed-off-by line be added to the refreshed patch? I
> > > was about to send this package bump, so I can send mine if you want.
> >
> > Which Signed-off-by line do you think is missing? Sorry for the double
> > effort, will send an updated version of the patch series soon (some
> > fixes for libdrm conversion), maybe better send a Reviewed-by to
> > my patch?
>
> Sorry, I misread your patch. I thought it refreshed the
> Buildroot-specific patch for fixing RPATH, whereas it removed it. See
> commit 7a23af4773665d2ee40e2d4e525746ebe38456dd for details.
>
> This specific patch applies to 0.46.1 but not to 0.47.1, as the function
> to modify is not in mesonbuild/scripts/meson_install.py anymore, but in
> mesonbuild/minstall.py:
>
> ```
> From cb5af88b1102ea8379323f95b9588c0bef71f175 Mon Sep 17 00:00:00 2001
> From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> Date: Sat, 14 Jul 2018 11:18:45 +0200
> Subject: [PATCH] Only fix RPATH if install_rpath is not empty
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
> mesonbuild/minstall.py | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mesonbuild/minstall.py b/mesonbuild/minstall.py
> index 4615b6dd..dd476ea8 100644
> --- a/mesonbuild/minstall.py
> +++ b/mesonbuild/minstall.py
> @@ -440,6 +440,14 @@ class Installer:
> try:
> depfixer.fix_rpath(outname, install_rpath, final_path,
> install_name_mappings, verbose=False)
> + # Buildroot check-host-rpath script expects RPATH
> + # But if install_rpath is empty, it will stripped.
> + # So, preserve it in this case
> + if install_rpath:
> + depfixer.fix_rpath(outname, install_rpath, final_path,
> + install_name_mappings, verbose=False)
> + else:
> + print("Skipping RPATH fixing")
> except SystemExit as e:
> if isinstance(e.code, int) and e.code == 0:
> pass
> --
> 2.14.4
> ```
>
> If Buildroot does not complain on RPATH when generating a new image if
> this patch is missing, then no need for it and the Signed-off-by line
> ;-)
No RPATH complains here, additional checked via:
$ ./support/scripts/check-host-rpath meson .../host
Please double check after the meson update without the RPATH patch...
>
> I'll happily review your updated version.
Many Thanks in advance ;-), just sent out an new patch series version...
Regards,
Peter
>
> Regards,
>
> --
> ELB
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-07-19 20:48 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 19:16 [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 2/4] meson: change from global to per package cross-compilation.conf Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 3/4] libdrm: change to meson build system Peter Seiderer
2018-07-17 19:16 ` [Buildroot] [RFC v2 4/4] libinput: bump version to 1.11.0 and convert to meson build Peter Seiderer
2018-07-17 20:02 ` [Buildroot] [RFC v2 1/4] meson: bump version to 0.47.1 Baruch Siach
2018-07-17 21:23 ` Peter Seiderer
2018-07-18 3:03 ` Baruch Siach
2018-07-18 19:46 ` Peter Seiderer
2018-07-17 20:23 ` Eric Le Bihan
2018-07-18 20:16 ` Peter Seiderer
2018-07-19 6:00 ` Eric Le Bihan
2018-07-19 20:48 ` Peter Seiderer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox