From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] libostree: override path to gpg-error-config
Date: Thu, 26 Jul 2018 15:27:14 +0200 [thread overview]
Message-ID: <20180726152714.045942f5@windsurf> (raw)
In-Reply-To: <20180726080800.5564-1-marcus.folkesson@gmail.com>
Hello,
On Thu, 26 Jul 2018 10:08:00 +0200, Marcus Folkesson wrote:
> libostree has begun to use `gpg-error-config` in their configuration
> script.
> Point out gpg-error-config in staging dir to avoid using the one
> installed on the host system.
>
> Fixes:
> http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>
> Notes:
> v2:
> - override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG
>
> package/libostree/libostree.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
> index 24eda0d1db..414cca104a 100644
> --- a/package/libostree/libostree.mk
> +++ b/package/libostree/libostree.mk
> @@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
> LIBOSTREE_LICENSE_FILES = COPYING
> LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
> LIBOSTREE_INSTALL_STAGING = YES
> +LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
So libostree is using libgpg-error directly, not only indirectly
through libgpgme. Should we add libgpg-error in libostree dependencies
explicitly to document this direct dependency ?
It is a bit weird to pass GPG_ERROR_CONFIG with this package not
depending on libgpg-error.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-26 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 8:08 [Buildroot] [PATCH v2] libostree: override path to gpg-error-config Marcus Folkesson
2018-07-26 8:11 ` Marcus Folkesson
2018-07-26 8:40 ` Arnout Vandecappelle
2018-07-26 13:27 ` Thomas Petazzoni [this message]
2018-07-26 13:52 ` Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180726152714.045942f5@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox