* [Buildroot] [PATCH v2] libostree: override path to gpg-error-config
@ 2018-07-26 8:08 Marcus Folkesson
2018-07-26 8:11 ` Marcus Folkesson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marcus Folkesson @ 2018-07-26 8:08 UTC (permalink / raw)
To: buildroot
libostree has begun to use `gpg-error-config` in their configuration
script.
Point out gpg-error-config in staging dir to avoid using the one
installed on the host system.
Fixes:
http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
Notes:
v2:
- override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG
package/libostree/libostree.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
index 24eda0d1db..414cca104a 100644
--- a/package/libostree/libostree.mk
+++ b/package/libostree/libostree.mk
@@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
LIBOSTREE_LICENSE_FILES = COPYING
LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
LIBOSTREE_INSTALL_STAGING = YES
+LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
LIBOSTREE_CONF_OPTS += \
--with-gpgme-prefix=$(STAGING_DIR)/usr \
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libostree: override path to gpg-error-config
2018-07-26 8:08 [Buildroot] [PATCH v2] libostree: override path to gpg-error-config Marcus Folkesson
@ 2018-07-26 8:11 ` Marcus Folkesson
2018-07-26 8:40 ` Arnout Vandecappelle
2018-07-26 13:27 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Marcus Folkesson @ 2018-07-26 8:11 UTC (permalink / raw)
To: buildroot
On Thu, Jul 26, 2018 at 10:08:00AM +0200, Marcus Folkesson wrote:
> libostree has begun to use `gpg-error-config` in their configuration
> script.
> Point out gpg-error-config in staging dir to avoid using the one
> installed on the host system.
>
> Fixes:
> http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>
> Notes:
> v2:
> - override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG
Eum...
- override GPG_ERROR_CONFIG instead of ac_cv_path_GPG_ERROR_CONFIG
:-)
>
> package/libostree/libostree.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
> index 24eda0d1db..414cca104a 100644
> --- a/package/libostree/libostree.mk
> +++ b/package/libostree/libostree.mk
> @@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
> LIBOSTREE_LICENSE_FILES = COPYING
> LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
> LIBOSTREE_INSTALL_STAGING = YES
> +LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
>
> LIBOSTREE_CONF_OPTS += \
> --with-gpgme-prefix=$(STAGING_DIR)/usr \
> --
> 2.18.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180726/554dfadc/attachment.asc>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libostree: override path to gpg-error-config
2018-07-26 8:08 [Buildroot] [PATCH v2] libostree: override path to gpg-error-config Marcus Folkesson
2018-07-26 8:11 ` Marcus Folkesson
@ 2018-07-26 8:40 ` Arnout Vandecappelle
2018-07-26 13:27 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2018-07-26 8:40 UTC (permalink / raw)
To: buildroot
On 26-07-18 10:08, Marcus Folkesson wrote:
> libostree has begun to use `gpg-error-config` in their configuration
> script.
> Point out gpg-error-config in staging dir to avoid using the one
> installed on the host system.
>
> Fixes:
> http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
>
> Notes:
> v2:
> - override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG
>
> package/libostree/libostree.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
> index 24eda0d1db..414cca104a 100644
> --- a/package/libostree/libostree.mk
> +++ b/package/libostree/libostree.mk
> @@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
> LIBOSTREE_LICENSE_FILES = COPYING
> LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
> LIBOSTREE_INSTALL_STAGING = YES
> +LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
>
> LIBOSTREE_CONF_OPTS += \
> --with-gpgme-prefix=$(STAGING_DIR)/usr \
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libostree: override path to gpg-error-config
2018-07-26 8:08 [Buildroot] [PATCH v2] libostree: override path to gpg-error-config Marcus Folkesson
2018-07-26 8:11 ` Marcus Folkesson
2018-07-26 8:40 ` Arnout Vandecappelle
@ 2018-07-26 13:27 ` Thomas Petazzoni
2018-07-26 13:52 ` Marcus Folkesson
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-07-26 13:27 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 26 Jul 2018 10:08:00 +0200, Marcus Folkesson wrote:
> libostree has begun to use `gpg-error-config` in their configuration
> script.
> Point out gpg-error-config in staging dir to avoid using the one
> installed on the host system.
>
> Fixes:
> http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
>
> Notes:
> v2:
> - override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG
>
> package/libostree/libostree.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
> index 24eda0d1db..414cca104a 100644
> --- a/package/libostree/libostree.mk
> +++ b/package/libostree/libostree.mk
> @@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
> LIBOSTREE_LICENSE_FILES = COPYING
> LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
> LIBOSTREE_INSTALL_STAGING = YES
> +LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
So libostree is using libgpg-error directly, not only indirectly
through libgpgme. Should we add libgpg-error in libostree dependencies
explicitly to document this direct dependency ?
It is a bit weird to pass GPG_ERROR_CONFIG with this package not
depending on libgpg-error.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] libostree: override path to gpg-error-config
2018-07-26 13:27 ` Thomas Petazzoni
@ 2018-07-26 13:52 ` Marcus Folkesson
0 siblings, 0 replies; 5+ messages in thread
From: Marcus Folkesson @ 2018-07-26 13:52 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, Jul 26, 2018 at 03:27:14PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 26 Jul 2018 10:08:00 +0200, Marcus Folkesson wrote:
> > libostree has begun to use `gpg-error-config` in their configuration
> > script.
> > Point out gpg-error-config in staging dir to avoid using the one
> > installed on the host system.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/447b96e449e881cf1bd9644cda0f386aa4c75724
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> > ---
> >
> > Notes:
> > v2:
> > - override ac_cv_path_GPG_ERROR_CONFIG instead of GPG_ERROR_CONFIG
> >
> > package/libostree/libostree.mk | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/libostree/libostree.mk b/package/libostree/libostree.mk
> > index 24eda0d1db..414cca104a 100644
> > --- a/package/libostree/libostree.mk
> > +++ b/package/libostree/libostree.mk
> > @@ -12,6 +12,7 @@ LIBOSTREE_LICENSE = LGPL-2.0+
> > LIBOSTREE_LICENSE_FILES = COPYING
> > LIBOSTREE_DEPENDENCIES = e2fsprogs host-bison host-pkgconf libfuse libglib2 libgpgme xz
> > LIBOSTREE_INSTALL_STAGING = YES
> > +LIBOSTREE_CONF_ENV = GPG_ERROR_CONFIG=$(STAGING_DIR)/usr/bin/gpg-error-config
>
> So libostree is using libgpg-error directly, not only indirectly
> through libgpgme. Should we add libgpg-error in libostree dependencies
> explicitly to document this direct dependency ?
That would be good. I will add it in v3. Thanks
>
> It is a bit weird to pass GPG_ERROR_CONFIG with this package not
> depending on libgpg-error.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best regards
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180726/b574b30e/attachment.asc>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-26 13:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-26 8:08 [Buildroot] [PATCH v2] libostree: override path to gpg-error-config Marcus Folkesson
2018-07-26 8:11 ` Marcus Folkesson
2018-07-26 8:40 ` Arnout Vandecappelle
2018-07-26 13:27 ` Thomas Petazzoni
2018-07-26 13:52 ` Marcus Folkesson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox