From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added
Date: Fri, 27 Jul 2018 09:31:14 +0200 [thread overview]
Message-ID: <20180727093114.4943db9a@windsurf> (raw)
In-Reply-To: <AD312B93A689234094FC24F3B98DBF33437A1708@INNO-EX-2010.innovaphone.sifi>
Hello Thomas,
On Fri, 27 Jul 2018 07:06:48 +0000, Thomas Ehrhardt wrote:
> The postgresql package is now built with --with-libxml if BR2_PACKAGE_LIBXML2 is selected to allow the use of XML functions in postgresql.
>
> Signed-off-by: Daniel Deterding <dde@innovaphone.com>
Thanks for your patch, it looks good, but there's one issue: the From
doesn't match the Signed-off-by.
If I understand correctly, the patch was done by your colleague Daniel
Deterding, and you are sending it on his behalf. If that is correct,
then you need to add your own Signed-off-by below the one from Daniel.
While you're at it, could you fix the minor issues below (I had fixed
them locally as I was about to apply the patch, but realized the
Signed-off-by issue) :
- The commit title should have the format:
<package>: <description>
A better commit title is:
postgresql: add optional dependency on libxml2
- The commit log text should be wrapped at 72 characters.
Except these, it looks good. Could you resend an updated version ?
Thanks a lot for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-27 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180608062231.2345-1-dde@innovaphone.com>
[not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F4424CD47@INNO-EX-2010.innovaphone.sifi>
[not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F443662EA@INNO-EX-2010.innovaphone.sifi>
2018-07-27 7:06 ` [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added Thomas Ehrhardt
2018-07-27 7:31 ` Thomas Petazzoni [this message]
2018-07-27 9:55 ` Arnout Vandecappelle
2018-07-27 21:39 ` Adam Duskett
2018-07-27 21:49 ` Thomas Petazzoni
[not found] <549ffe67-ad9f-b607-6735-09faa86f0b09@gmx.de>
2018-06-11 20:19 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727093114.4943db9a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox