From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added
Date: Fri, 27 Jul 2018 23:49:30 +0200 [thread overview]
Message-ID: <20180727234930.3a42d30c@windsurf> (raw)
In-Reply-To: <CAFSsvmqDUkMg4-=pQ94UR2Q7BynejSDT55HMq4WFYYmw4K4kpw@mail.gmail.com>
Hello,
On Fri, 27 Jul 2018 17:39:57 -0400, Adam Duskett wrote:
> Another nitpick I would have is that there should probably be a
> Config.in entry for this as well.
No, probably not. As a general rule in Buildroot, we prefer automatic
handling of optional dependencies, in order to avoid a proliferation of
gazillion of Config.in options. In addition, postgresql.mk already
handles all its optional dependencies this way.
The only reason to not do this in this case would be if the XML2
support in postgresql increases significantly the size of the
postgresql binary.
But again, in general, automatic handling of optional dependencies is
preferred.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-27 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180608062231.2345-1-dde@innovaphone.com>
[not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F4424CD47@INNO-EX-2010.innovaphone.sifi>
[not found] ` <F73717A01AEC1F4CB9A3D10E39CBB88F443662EA@INNO-EX-2010.innovaphone.sifi>
2018-07-27 7:06 ` [Buildroot] [PATCH 1/1] postgresql --with-libxml configure option added Thomas Ehrhardt
2018-07-27 7:31 ` Thomas Petazzoni
2018-07-27 9:55 ` Arnout Vandecappelle
2018-07-27 21:39 ` Adam Duskett
2018-07-27 21:49 ` Thomas Petazzoni [this message]
[not found] <549ffe67-ad9f-b607-6735-09faa86f0b09@gmx.de>
2018-06-11 20:19 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727234930.3a42d30c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox