From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch
Date: Sat, 28 Jul 2018 14:56:47 +0200 [thread overview]
Message-ID: <20180728145647.70ac1d52@windsurf> (raw)
In-Reply-To: <f1e71e0d-6728-78d1-0431-c1e2846ab885@infradead.org>
Hello,
On Fri, 27 Jul 2018 15:23:28 -0700, Geoff Levand wrote:
> Fixes pylibfdt cross compile errors.
>
> http://autobuild.buildroot.net/?reason=%dtc-1.4.7
Are you sure your patch is fixing the host-dtc build issues ?
I am seeing two different build issues:
- One for host-dtc, which looks like this:
INSTALL-PYLIB
pylibfdt/libfdt_wrap.c: In function 'SWIG_Python_NewShadowInstance':
pylibfdt/libfdt_wrap.c:2483:65: error: declaration of 'swig_this' shadows a global declaration [-Werror=shadow]
SWIG_Python_NewShadowInstance(SwigPyClientData *data, PyObject *swig_this)
^
pylibfdt/libfdt_wrap.c:2224:18: error: shadowed declaration is here [-Werror=shadow]
static PyObject *swig_this = NULL;
- One for dtc, which looks like this:
LD fdtoverlay
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: error adding symbols: File in wrong format
Your patch probably fixes the "dtc" issue, but I'm not sure it fixes the host-dtc issue.
> diff --git a/package/dtc/set-ldshared.patch b/package/dtc/set-ldshared.patch
> new file mode 100644
> index 0000000000..09220da359
> --- /dev/null
> +++ b/package/dtc/set-ldshared.patch
> @@ -0,0 +1,13 @@
Patches should be Git formatted, have a description and a Signed-off-by.
> +diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt
> +index 9507d3d..c2ac8e9 100644
> +--- a/pylibfdt/Makefile.pylibfdt
> ++++ b/pylibfdt/Makefile.pylibfdt
> +@@ -8,7 +8,7 @@ PYMODULE = $(PYLIBFDT_objdir)/_libfdt.so
> + define run_setup
> + SOURCES="$(1)" CPPFLAGS="$(CPPFLAGS)" OBJDIR="$(PYLIBFDT_objdir)"
> + VERSION="$(dtc_version)"
> +- $(PYLIBFDT_objdir)/setup.py --quiet $(2)
> ++ LDSHARED="$(CC) -shared" $(PYLIBFDT_objdir)/setup.py --quiet $(2)
Do we know why it was working before, and why it fails since the dtc update ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-28 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 19:32 [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7 Geoff Levand
2018-07-25 20:53 ` Thomas Petazzoni
2018-07-27 9:07 ` Thomas Petazzoni
2018-07-27 17:09 ` Geoff Levand
[not found] ` <CAPnjgZ1297i1+K=SUB-Y37jjabqxdJRA13iPxPe=MND5da44WA@mail.gmail.com>
2018-07-27 18:56 ` Geoff Levand
2018-07-27 22:23 ` [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch Geoff Levand
2018-07-28 12:56 ` Thomas Petazzoni [this message]
2018-07-28 13:43 ` Thomas Petazzoni
2018-07-30 14:46 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728145647.70ac1d52@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox