* [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7
@ 2018-07-24 19:32 Geoff Levand
2018-07-25 20:53 ` Thomas Petazzoni
2018-07-27 9:07 ` Thomas Petazzoni
0 siblings, 2 replies; 9+ messages in thread
From: Geoff Levand @ 2018-07-24 19:32 UTC (permalink / raw)
To: buildroot
Bump from 1.4.4 to 1.4.7.
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
package/dtc/dtc.hash | 2 +-
package/dtc/dtc.mk | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/dtc/dtc.hash b/package/dtc/dtc.hash
index 75c2e40eea..b402c2249b 100644
--- a/package/dtc/dtc.hash
+++ b/package/dtc/dtc.hash
@@ -1,2 +1,2 @@
# from https://www.kernel.org/pub/software/utils/dtc/sha256sums.asc
-sha256 470731d5c015b160d26a96645dbb1c7337d6e7b8c98244612002b66bedf6cffb dtc-1.4.4.tar.xz
+sha256 6643e8f00ff86350f465bb54b2185058b5b1b7bac01a0842c81a52b86589cde7 dtc-1.4.7.tar.xz
diff --git a/package/dtc/dtc.mk b/package/dtc/dtc.mk
index 1bcee29bb3..8388793c01 100644
--- a/package/dtc/dtc.mk
+++ b/package/dtc/dtc.mk
@@ -4,7 +4,7 @@
#
################################################################################
-DTC_VERSION = 1.4.4
+DTC_VERSION = 1.4.7
DTC_SOURCE = dtc-$(DTC_VERSION).tar.xz
DTC_SITE = https://www.kernel.org/pub/software/utils/dtc
DTC_LICENSE = GPL-2.0+ or BSD-2-Clause (library)
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7
2018-07-24 19:32 [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7 Geoff Levand
@ 2018-07-25 20:53 ` Thomas Petazzoni
2018-07-27 9:07 ` Thomas Petazzoni
1 sibling, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2018-07-25 20:53 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 24 Jul 2018 19:32:17 +0000, Geoff Levand wrote:
> Bump from 1.4.4 to 1.4.7.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> package/dtc/dtc.hash | 2 +-
> package/dtc/dtc.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7
2018-07-24 19:32 [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7 Geoff Levand
2018-07-25 20:53 ` Thomas Petazzoni
@ 2018-07-27 9:07 ` Thomas Petazzoni
2018-07-27 17:09 ` Geoff Levand
2018-07-27 22:23 ` [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch Geoff Levand
1 sibling, 2 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2018-07-27 9:07 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 24 Jul 2018 19:32:17 +0000, Geoff Levand wrote:
> Bump from 1.4.4 to 1.4.7.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
> package/dtc/dtc.hash | 2 +-
> package/dtc/dtc.mk | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
This is failing all over the place in the autobuilders:
http://autobuild.buildroot.net/?reason=%dtc-1.4.7
Could you look into those issues and provide a patch to address them ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7
2018-07-27 9:07 ` Thomas Petazzoni
@ 2018-07-27 17:09 ` Geoff Levand
[not found] ` <CAPnjgZ1297i1+K=SUB-Y37jjabqxdJRA13iPxPe=MND5da44WA@mail.gmail.com>
2018-07-27 22:23 ` [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch Geoff Levand
1 sibling, 1 reply; 9+ messages in thread
From: Geoff Levand @ 2018-07-27 17:09 UTC (permalink / raw)
To: buildroot
Hi Simon,
Any ideas about what's wrong?
Some builds show this error:
LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)
Which seems to be triggered from this:
https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Include/pyport.h#L701
I'll continue to look into it.
-Geoff
On 07/27/2018 02:07 AM, Thomas Petazzoni wrote:
> On Tue, 24 Jul 2018 19:32:17 +0000, Geoff Levand wrote:
>> Bump from 1.4.4 to 1.4.7.
>>
>> Signed-off-by: Geoff Levand <geoff@infradead.org>
>> ---
>> package/dtc/dtc.hash | 2 +-
>> package/dtc/dtc.mk | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> This is failing all over the place in the autobuilders:
>
> http://autobuild.buildroot.net/?reason=%dtc-1.4.7
>
> Could you look into those issues and provide a patch to address them ?
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch
2018-07-27 9:07 ` Thomas Petazzoni
2018-07-27 17:09 ` Geoff Levand
@ 2018-07-27 22:23 ` Geoff Levand
2018-07-28 12:56 ` Thomas Petazzoni
1 sibling, 1 reply; 9+ messages in thread
From: Geoff Levand @ 2018-07-27 22:23 UTC (permalink / raw)
To: buildroot
Fixes pylibfdt cross compile errors.
http://autobuild.buildroot.net/?reason=%dtc-1.4.7
Signed-off-by: Geoff Levand <geoff@infradead.org>
---
Hi Thomas,
This gets the dtc package to build with python support, but
it seems the real problem is that python distutils doesn't
set LDSHARED correctly, which should default to CC.
-Geoff
package/dtc/set-ldshared.patch | 13 +++++++++++++
1 file changed, 13 insertions(+)
create mode 100644 package/dtc/set-ldshared.patch
diff --git a/package/dtc/set-ldshared.patch b/package/dtc/set-ldshared.patch
new file mode 100644
index 0000000000..09220da359
--- /dev/null
+++ b/package/dtc/set-ldshared.patch
@@ -0,0 +1,13 @@
+diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt
+index 9507d3d..c2ac8e9 100644
+--- a/pylibfdt/Makefile.pylibfdt
++++ b/pylibfdt/Makefile.pylibfdt
+@@ -8,7 +8,7 @@ PYMODULE = $(PYLIBFDT_objdir)/_libfdt.so
+ define run_setup
+ SOURCES="$(1)" CPPFLAGS="$(CPPFLAGS)" OBJDIR="$(PYLIBFDT_objdir)"
+ VERSION="$(dtc_version)"
+- $(PYLIBFDT_objdir)/setup.py --quiet $(2)
++ LDSHARED="$(CC) -shared" $(PYLIBFDT_objdir)/setup.py --quiet $(2)
+ endef
+
+ $(PYMODULE): $(PYLIBFDT_srcs)
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch
2018-07-27 22:23 ` [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch Geoff Levand
@ 2018-07-28 12:56 ` Thomas Petazzoni
2018-07-28 13:43 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2018-07-28 12:56 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 27 Jul 2018 15:23:28 -0700, Geoff Levand wrote:
> Fixes pylibfdt cross compile errors.
>
> http://autobuild.buildroot.net/?reason=%dtc-1.4.7
Are you sure your patch is fixing the host-dtc build issues ?
I am seeing two different build issues:
- One for host-dtc, which looks like this:
INSTALL-PYLIB
pylibfdt/libfdt_wrap.c: In function 'SWIG_Python_NewShadowInstance':
pylibfdt/libfdt_wrap.c:2483:65: error: declaration of 'swig_this' shadows a global declaration [-Werror=shadow]
SWIG_Python_NewShadowInstance(SwigPyClientData *data, PyObject *swig_this)
^
pylibfdt/libfdt_wrap.c:2224:18: error: shadowed declaration is here [-Werror=shadow]
static PyObject *swig_this = NULL;
- One for dtc, which looks like this:
LD fdtoverlay
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
/usr/bin/ld: build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: Relocations in generic ELF (EM: 8)
build/temp.linux-x86_64-2.7/usr/lfs/v0/rc-buildroot-test/scripts/instance-2/output/build/dtc-1.4.7/libfdt/fdt.o: error adding symbols: File in wrong format
Your patch probably fixes the "dtc" issue, but I'm not sure it fixes the host-dtc issue.
> diff --git a/package/dtc/set-ldshared.patch b/package/dtc/set-ldshared.patch
> new file mode 100644
> index 0000000000..09220da359
> --- /dev/null
> +++ b/package/dtc/set-ldshared.patch
> @@ -0,0 +1,13 @@
Patches should be Git formatted, have a description and a Signed-off-by.
> +diff --git a/pylibfdt/Makefile.pylibfdt b/pylibfdt/Makefile.pylibfdt
> +index 9507d3d..c2ac8e9 100644
> +--- a/pylibfdt/Makefile.pylibfdt
> ++++ b/pylibfdt/Makefile.pylibfdt
> +@@ -8,7 +8,7 @@ PYMODULE = $(PYLIBFDT_objdir)/_libfdt.so
> + define run_setup
> + SOURCES="$(1)" CPPFLAGS="$(CPPFLAGS)" OBJDIR="$(PYLIBFDT_objdir)"
> + VERSION="$(dtc_version)"
> +- $(PYLIBFDT_objdir)/setup.py --quiet $(2)
> ++ LDSHARED="$(CC) -shared" $(PYLIBFDT_objdir)/setup.py --quiet $(2)
Do we know why it was working before, and why it fails since the dtc update ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread* [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch
2018-07-28 12:56 ` Thomas Petazzoni
@ 2018-07-28 13:43 ` Thomas Petazzoni
2018-07-30 14:46 ` Geoff Levand
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2018-07-28 13:43 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 28 Jul 2018 14:56:47 +0200, Thomas Petazzoni wrote:
> Are you sure your patch is fixing the host-dtc build issues ?
>
> I am seeing two different build issues:
>
> - One for host-dtc, which looks like this:
[...]
> - One for dtc, which looks like this:
Since all those problems are due to pylibfdt, which is new since 1.4.5,
and that we don't use in Buildroot, I applied a simpler fix: pass
NO_PYTHON=1 so that we don't build the Python support, even if the
necessary dependencies are found.
See:
https://git.buildroot.org/buildroot/commit/?id=b50c95e914c6366e30145378fa82f286d4412c51
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-30 14:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-24 19:32 [Buildroot] [PATCH v1 1/2] dtc: bump version to 1.4.7 Geoff Levand
2018-07-25 20:53 ` Thomas Petazzoni
2018-07-27 9:07 ` Thomas Petazzoni
2018-07-27 17:09 ` Geoff Levand
[not found] ` <CAPnjgZ1297i1+K=SUB-Y37jjabqxdJRA13iPxPe=MND5da44WA@mail.gmail.com>
2018-07-27 18:56 ` Geoff Levand
2018-07-27 22:23 ` [Buildroot] [PATCH v1] dtc: Add set-ldshared.patch Geoff Levand
2018-07-28 12:56 ` Thomas Petazzoni
2018-07-28 13:43 ` Thomas Petazzoni
2018-07-30 14:46 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox