* [Buildroot] [PATCH 1/1] libjwt: new package. @ 2018-08-11 20:29 Mikael 2018-08-12 12:39 ` Thomas Petazzoni 0 siblings, 1 reply; 8+ messages in thread From: Mikael @ 2018-08-11 20:29 UTC (permalink / raw) To: buildroot Signed-off-by: Mikael <mikael@robomagi.com> --- package/libjwt/Config.in | 13 +++++++++++++ package/libjwt/libjwt.hash | 2 ++ package/libjwt/libjwt.mk | 14 ++++++++++++++ 3 files changed, 29 insertions(+) create mode 100644 package/libjwt/Config.in create mode 100644 package/libjwt/libjwt.hash create mode 100644 package/libjwt/libjwt.mk diff --git a/package/libjwt/Config.in b/package/libjwt/Config.in new file mode 100644 index 0000000000..81e33e6d93 --- /dev/null +++ b/package/libjwt/Config.in @@ -0,0 +1,13 @@ +config BR2_PACKAGE_LIBJWT + bool "libjwt" + depends on BR2_INSTALL_LIBSTDCPP + select BR2_PACKAGE_JANSSON + select BR2_PACKAGE_OPENSSL + help + JSON Web Tokens are an open, industry standard RFC 7519 + method for representing claims securely between two parties. + + https://github.com/benmcollins/libjwt + +comment "libjwt needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP diff --git a/package/libjwt/libjwt.hash b/package/libjwt/libjwt.hash new file mode 100644 index 0000000000..c8b7ed168a --- /dev/null +++ b/package/libjwt/libjwt.hash @@ -0,0 +1,2 @@ +#Locally computed +sha256 cc694dfc3abe17d1f5cde4bf6714e39dc17f7cbad352a85ffb0fe6418c584076 libjwt-v1.9.0.tar.gz diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk new file mode 100644 index 0000000000..2007d6c541 --- /dev/null +++ b/package/libjwt/libjwt.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# libjwt +# +################################################################################ + +LIBJWT_VERSION = v1.9.0 +LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) +LIBJWT_INSTALL_STAGING = YES +LIBJWT_DEPENDENCIES = jansson openssl +LIBJWT_LICENSE = LGPL-3.0-only +LIBJWT_LICENSE_FILES = COPYING.LIB + +$(eval $(cmake-package)) -- 2.17.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-11 20:29 [Buildroot] [PATCH 1/1] libjwt: new package Mikael @ 2018-08-12 12:39 ` Thomas Petazzoni 2018-08-12 16:08 ` Mikael Eliasson 0 siblings, 1 reply; 8+ messages in thread From: Thomas Petazzoni @ 2018-08-12 12:39 UTC (permalink / raw) To: buildroot Hello Mikael, First of all, thanks for your contribution! On Sat, 11 Aug 2018 22:29:25 +0200, Mikael wrote: > Signed-off-by: Mikael <mikael@robomagi.com> Could you use your full first name + last name when contributing? This is important for legal reasons. > diff --git a/package/libjwt/Config.in b/package/libjwt/Config.in > new file mode 100644 > index 0000000000..81e33e6d93 > --- /dev/null > +++ b/package/libjwt/Config.in > @@ -0,0 +1,13 @@ > +config BR2_PACKAGE_LIBJWT > + bool "libjwt" > + depends on BR2_INSTALL_LIBSTDCPP There is no C++ anywhere in this package, and none of the dependencies require C++. To me, it seems like the CMakeLists.txt should be changed from: project (jwt) to project (jwt C) which tells CMake that the project is using C only, and no C++. > + select BR2_PACKAGE_JANSSON > + select BR2_PACKAGE_OPENSSL Are you sure OpenSSL is mandatory ? I see a possibility to use GnuTLS as well: if (WITHOUT_OPENSSL) find_package (GnuTLS REQUIRED) set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-openssl.c) set (SSL_LIBRARY_INCLUDE_DIR ${GNUTLS_INCLUDE_DIR}) set (SSL_LIBRARIES_DEBUG ${GNUTLS_LIBRARY}) set (SSL_LIBRARIES_OPTIMIZED ${GNUTLS_LIBRARY}) else () if (MSVC AND STATIC_RUNTIME) set (OPENSSL_MSVC_STATIC_RT TRUE) endif () find_package (OpenSSL REQUIRED) set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-gnutls.c) set (SSL_LIBRARY_INCLUDE_DIR ${OPENSSL_INCLUDE_DIR}) if (MSVC) set (SSL_LIBRARIES_DEBUG ${LIB_EAY_DEBUG} ${SSL_EAY_DEBUG}) set (SSL_LIBRARIES_OPTIMIZED ${LIB_EAY_RELEASE} ${SSL_EAY_RELEASE}) else () set (SSL_LIBRARIES_DEBUG ${OPENSSL_CRYPTO_LIBRARY}) set (SSL_LIBRARIES_OPTIMIZED ${OPENSSL_CRYPTO_LIBRARY}) endif () endif () So perhaps, you could do: select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS And the in the .mk file, pass -DWITHOUT_OPENSSL= if GnuTLS is available, but not OpenSSL: ifeq ($(BR2_PACKAGE_OPENSSL),y) LIBJWT_DEPENDENCIES += openssl else LIBJWT_DEPENDENCIES += gnutls LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1 endif > + help > + JSON Web Tokens are an open, industry standard RFC 7519 > + method for representing claims securely between two parties. > + > + https://github.com/benmcollins/libjwt > + > +comment "libjwt needs a toolchain w/ C++" > + depends on !BR2_INSTALL_LIBSTDCPP > diff --git a/package/libjwt/libjwt.hash b/package/libjwt/libjwt.hash > new file mode 100644 > index 0000000000..c8b7ed168a > --- /dev/null > +++ b/package/libjwt/libjwt.hash > @@ -0,0 +1,2 @@ > +#Locally computed > +sha256 cc694dfc3abe17d1f5cde4bf6714e39dc17f7cbad352a85ffb0fe6418c584076 libjwt-v1.9.0.tar.gz Could you add the hash of the COPYING.LIB license file ? > diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk > new file mode 100644 > index 0000000000..2007d6c541 > --- /dev/null > +++ b/package/libjwt/libjwt.mk > @@ -0,0 +1,14 @@ > +################################################################################ > +# > +# libjwt > +# > +################################################################################ > + > +LIBJWT_VERSION = v1.9.0 > +LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) > +LIBJWT_INSTALL_STAGING = YES > +LIBJWT_DEPENDENCIES = jansson openssl > +LIBJWT_LICENSE = LGPL-3.0-only We use LGPL-3.0 in this case (i.e we don't obey strictly to SPDX, we probably should, but we don't yet, and we should have a single package deviates from what we do in the rest of Buildroot). > +LIBJWT_LICENSE_FILES = COPYING.LIB > + > +$(eval $(cmake-package)) Finally, could you test this package with "utils/test-pkg" ? I am wondering if it builds properly in a static-only configuration. utils/test-pkg will test this for you. Could you take into account those comments, and send an updated version ? Thanks a lot! Thomas Petazzoni -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-12 12:39 ` Thomas Petazzoni @ 2018-08-12 16:08 ` Mikael Eliasson 2018-08-12 19:25 ` Yann E. MORIN 0 siblings, 1 reply; 8+ messages in thread From: Mikael Eliasson @ 2018-08-12 16:08 UTC (permalink / raw) To: buildroot Hi Thomas, Not used to using mailing lists so this may not be the correct way to send a follow up patch. It is attached. I think I have made all the changes you requested. I had also missed including package/Config.in. Tested with test-pkg -a: 47 builds, 0 skipped, 0 build failed, 0 legal-info failed /Regards Mikael 2018-08-12 14:39 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>: > Hello Mikael, > > First of all, thanks for your contribution! > > On Sat, 11 Aug 2018 22:29:25 +0200, Mikael wrote: > > Signed-off-by: Mikael <mikael@robomagi.com> > > Could you use your full first name + last name when contributing? This > is important for legal reasons. > > > diff --git a/package/libjwt/Config.in b/package/libjwt/Config.in > > new file mode 100644 > > index 0000000000..81e33e6d93 > > --- /dev/null > > +++ b/package/libjwt/Config.in > > @@ -0,0 +1,13 @@ > > +config BR2_PACKAGE_LIBJWT > > + bool "libjwt" > > + depends on BR2_INSTALL_LIBSTDCPP > > There is no C++ anywhere in this package, and none of the dependencies > require C++. To me, it seems like the CMakeLists.txt should be changed > from: > > project (jwt) > > to > > project (jwt C) > > which tells CMake that the project is using C only, and no C++. > > > + select BR2_PACKAGE_JANSSON > > + select BR2_PACKAGE_OPENSSL > > Are you sure OpenSSL is mandatory ? I see a possibility to use GnuTLS > as well: > > if (WITHOUT_OPENSSL) > find_package (GnuTLS REQUIRED) > set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-openssl.c) > set (SSL_LIBRARY_INCLUDE_DIR ${GNUTLS_INCLUDE_DIR}) > set (SSL_LIBRARIES_DEBUG ${GNUTLS_LIBRARY}) > set (SSL_LIBRARIES_OPTIMIZED ${GNUTLS_LIBRARY}) > else () > if (MSVC AND STATIC_RUNTIME) > set (OPENSSL_MSVC_STATIC_RT TRUE) > endif () > find_package (OpenSSL REQUIRED) > set (FILES_TO_REMOVE ${CMAKE_CURRENT_SOURCE_DIR}/jwt-gnutls.c) > set (SSL_LIBRARY_INCLUDE_DIR ${OPENSSL_INCLUDE_DIR}) > if (MSVC) > set (SSL_LIBRARIES_DEBUG ${LIB_EAY_DEBUG} ${SSL_EAY_DEBUG}) > set (SSL_LIBRARIES_OPTIMIZED ${LIB_EAY_RELEASE} > ${SSL_EAY_RELEASE}) > else () > set (SSL_LIBRARIES_DEBUG ${OPENSSL_CRYPTO_LIBRARY}) > set (SSL_LIBRARIES_OPTIMIZED ${OPENSSL_CRYPTO_LIBRARY}) > endif () > endif () > > So perhaps, you could do: > > select BR2_PACKAGE_OPENSSL if !BR2_PACKAGE_GNUTLS > > And the in the .mk file, pass -DWITHOUT_OPENSSL= if GnuTLS is > available, but not OpenSSL: > > ifeq ($(BR2_PACKAGE_OPENSSL),y) > LIBJWT_DEPENDENCIES += openssl > else > LIBJWT_DEPENDENCIES += gnutls > LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1 > endif > > > + help > > + JSON Web Tokens are an open, industry standard RFC 7519 > > + method for representing claims securely between two parties. > > + > > + https://github.com/benmcollins/libjwt > > + > > +comment "libjwt needs a toolchain w/ C++" > > + depends on !BR2_INSTALL_LIBSTDCPP > > diff --git a/package/libjwt/libjwt.hash b/package/libjwt/libjwt.hash > > new file mode 100644 > > index 0000000000..c8b7ed168a > > --- /dev/null > > +++ b/package/libjwt/libjwt.hash > > @@ -0,0 +1,2 @@ > > +#Locally computed > > +sha256 cc694dfc3abe17d1f5cde4bf6714e39dc17f7cbad352a85ffb0fe6418c584076 > libjwt-v1.9.0.tar.gz > > Could you add the hash of the COPYING.LIB license file ? > > > diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk > > new file mode 100644 > > index 0000000000..2007d6c541 > > --- /dev/null > > +++ b/package/libjwt/libjwt.mk > > @@ -0,0 +1,14 @@ > > +########################################################### > ##################### > > +# > > +# libjwt > > +# > > +########################################################### > ##################### > > + > > +LIBJWT_VERSION = v1.9.0 > > +LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) > > +LIBJWT_INSTALL_STAGING = YES > > +LIBJWT_DEPENDENCIES = jansson openssl > > +LIBJWT_LICENSE = LGPL-3.0-only > > We use LGPL-3.0 in this case (i.e we don't obey strictly to SPDX, we > probably should, but we don't yet, and we should have a single package > deviates from what we do in the rest of Buildroot). > > > +LIBJWT_LICENSE_FILES = COPYING.LIB > > + > > +$(eval $(cmake-package)) > > Finally, could you test this package with "utils/test-pkg" ? I am > wondering if it builds properly in a static-only configuration. > utils/test-pkg will test this for you. > > Could you take into account those comments, and send an updated > version ? > > Thanks a lot! > > Thomas Petazzoni > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com > -- Mikael Eliasson Telefon: +46703900837 Email: mikael at robomagi.com Adress: Robomagi AB T?ngringsgatan 26A 78430 Borl?nge -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180812/1060078a/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-libjwt-new-package.patch Type: text/x-patch Size: 3520 bytes Desc: not available URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180812/1060078a/attachment.bin> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-12 16:08 ` Mikael Eliasson @ 2018-08-12 19:25 ` Yann E. MORIN 2018-08-21 18:34 ` Mikael Eliasson 0 siblings, 1 reply; 8+ messages in thread From: Yann E. MORIN @ 2018-08-12 19:25 UTC (permalink / raw) To: buildroot Mickael, All, On 2018-08-12 18:08 +0200, Mikael Eliasson spake thusly: > Hi Thomas, > Not used to using mailing lists so this may not be the correct way to send a follow up patch. It is attached. Just send it again with git send-email. Also, it is customary to not top-post like you did, but to reply in-line (like I'm doing). > I think I have made all the changes you requested. I had also missed including?package/Config.in. > Tested with test-pkg -a: > 47 builds, 0 skipped, 0 build failed, 0 legal-info failed Great! :-) Yet, I have a very small comment, see below... [--SNIP--] > diff --git a/package/libjwt/0001-Declare-project-C-only.patch b/package/libjwt/0001-Declare-project-C-only.patch > new file mode 100644 > index 0000000000..cfb3cc8425 > --- /dev/null > +++ b/package/libjwt/0001-Declare-project-C-only.patch > @@ -0,0 +1,16 @@ > +Declares project C only. > + > +Signed-off-by: Mikael Eliasson <mikael@robomagi.com> > +diff --git a/CMakeLists.txt b/CMakeLists.txt > +index 5cd1910..aefb87d 100644 > +--- a/CMakeLists.txt > ++++ b/CMakeLists.txt > +@@ -4,7 +4,7 @@ if (MSVC) > + set (CMAKE_SYSTEM_VERSION 8.1 CACHE TYPE INTERNAL FORCE) > + endif () > + > +-project (jwt) > ++project (jwt C) It would be great if you were to send this change upstream, so that we can drop this patch next time we update the package. > + list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") > + [--SNIP--] > diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk > new file mode 100644 > index 0000000000..8863fb436a > --- /dev/null > +++ b/package/libjwt/libjwt.mk > @@ -0,0 +1,21 @@ > +################################################################################ > +# > +# libjwt > +# > +################################################################################ > + > +LIBJWT_VERSION = v1.9.0 > +LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) > +LIBJWT_INSTALL_STAGING = YES > +LIBJWT_DEPENDENCIES = jansson > +LIBJWT_LICENSE = LGPL-3.0 > +LIBJWT_LICENSE_FILES = COPYING.LIB I know there is no strongly documented ordering, but I like that the descriptive metadata goes first, while the building metadata goes last, with adequate spacing to separate the types of data, like so: LIBJWT_VERSION = v1.9.0 LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) LIBJWT_LICENSE = LGPL-3.0 LIBJWT_LICENSE_FILES = COPYING.LIB LIBJWT_DEPENDENCIES = jansson LIBJWT_INSTALL_STAGING = YES It kind of follows some "logic": where to get it, what itslicensing is, what it needs, what it provides, how we build it. No need to re-send. If a maintainer agrees, he can re-reorder when applying, or he can just apply it as-is if he believes that is OK as-is. Regards, Yann E. MORIN. > +ifeq ($(BR2_PACKAGE_OPENSSL),y) > +LIBJWT_DEPENDENCIES += openssl > +else > +LIBJWT_DEPENDENCIES += gnutls > +LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1 > +endif > + > +$(eval $(cmake-package)) > -- > 2.17.1 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-12 19:25 ` Yann E. MORIN @ 2018-08-21 18:34 ` Mikael Eliasson 2018-08-21 19:54 ` Yann E. MORIN 0 siblings, 1 reply; 8+ messages in thread From: Mikael Eliasson @ 2018-08-21 18:34 UTC (permalink / raw) To: buildroot Hi, 2018-08-12 21:25 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > Mickael, All, > > On 2018-08-12 18:08 +0200, Mikael Eliasson spake thusly: > > Hi Thomas, > > Not used to using mailing lists so this may not be the correct way to > send a follow up patch. It is attached. > > Just send it again with git send-email. > > Also, it is customary to not top-post like you did, but to reply in-line > (like I'm doing). > > > I think I have made all the changes you requested. I had also missed > including package/Config.in. > > Tested with test-pkg -a: > > 47 builds, 0 skipped, 0 build failed, 0 legal-info failed > > Great! :-) > > Yet, I have a very small comment, see below... > > [--SNIP--] > > diff --git a/package/libjwt/0001-Declare-project-C-only.patch > b/package/libjwt/0001-Declare-project-C-only.patch > > new file mode 100644 > > index 0000000000..cfb3cc8425 > > --- /dev/null > > +++ b/package/libjwt/0001-Declare-project-C-only.patch > > @@ -0,0 +1,16 @@ > > +Declares project C only. > > + > > +Signed-off-by: Mikael Eliasson <mikael@robomagi.com> > > +diff --git a/CMakeLists.txt b/CMakeLists.txt > > +index 5cd1910..aefb87d 100644 > > +--- a/CMakeLists.txt > > ++++ b/CMakeLists.txt > > +@@ -4,7 +4,7 @@ if (MSVC) > > + set (CMAKE_SYSTEM_VERSION 8.1 CACHE TYPE INTERNAL FORCE) > > + endif () > > + > > +-project (jwt) > > ++project (jwt C) > > It would be great if you were to send this change upstream, so that we > can drop this patch next time we update the package. > > > + list (APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") > > + > [--SNIP--] > > diff --git a/package/libjwt/libjwt.mk b/package/libjwt/libjwt.mk > > new file mode 100644 > > index 0000000000..8863fb436a > > --- /dev/null > > +++ b/package/libjwt/libjwt.mk > > @@ -0,0 +1,21 @@ > > +########################################################### > ##################### > > +# > > +# libjwt > > +# > > +########################################################### > ##################### > > + > > +LIBJWT_VERSION = v1.9.0 > > +LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) > > +LIBJWT_INSTALL_STAGING = YES > > +LIBJWT_DEPENDENCIES = jansson > > +LIBJWT_LICENSE = LGPL-3.0 > > +LIBJWT_LICENSE_FILES = COPYING.LIB > > I know there is no strongly documented ordering, but I like that the > descriptive metadata goes first, while the building metadata goes last, > with adequate spacing to separate the types of data, like so: > > LIBJWT_VERSION = v1.9.0 > LIBJWT_SITE = $(call github,benmcollins,libjwt,$(LIBJWT_VERSION)) > LIBJWT_LICENSE = LGPL-3.0 > LIBJWT_LICENSE_FILES = COPYING.LIB > > LIBJWT_DEPENDENCIES = jansson > > LIBJWT_INSTALL_STAGING = YES > > It kind of follows some "logic": where to get it, what itslicensing is, > what it needs, what it provides, how we build it. > > No need to re-send. If a maintainer agrees, he can re-reorder when > applying, or he can just apply it as-is if he believes that is OK as-is. > Is there anything else you need me to do to include this package? I cannot see that it has been added in github yet. > > Regards, > Yann E. MORIN. > > > +ifeq ($(BR2_PACKAGE_OPENSSL),y) > > +LIBJWT_DEPENDENCIES += openssl > > +else > > +LIBJWT_DEPENDENCIES += gnutls > > +LIBJWT_CONF_OPTS += -DWITHOUT_OPENSSL=1 > > +endif > > + > > +$(eval $(cmake-package)) > > -- > > 2.17.1 > > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > > -- > .-----------------.--------------------.------------------.- > -------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > '------------------------------^-------^------------------^- > -------------------' > -- Mikael Eliasson Telefon: +46703900837 Email: mikael at robomagi.com Adress: Robomagi AB T?ngringsgatan 26A 78430 Borl?nge -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180821/92ed0ce2/attachment.html> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-21 18:34 ` Mikael Eliasson @ 2018-08-21 19:54 ` Yann E. MORIN 2018-08-21 20:20 ` Mikael Eliasson 0 siblings, 1 reply; 8+ messages in thread From: Yann E. MORIN @ 2018-08-21 19:54 UTC (permalink / raw) To: buildroot Mikael, All, On 2018-08-21 20:34 +0200, Mikael Eliasson spake thusly: > Is there anything else you need me to do to include this package? I > cannot see that it has been added in github yet. Don;t worry, it is not lost, but: 1. There are currently 197 patches pending: https://patchwork.ozlabs.org/project/buildroot/list/ 2. We are in feature-freeze for the release scheduled by the end of the month. 3. The Github repository is not the official tree; it is only a mirror. The official tree is: https://git.buildroot.org/buildroot/ Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-21 19:54 ` Yann E. MORIN @ 2018-08-21 20:20 ` Mikael Eliasson 2018-08-21 20:25 ` Thomas Petazzoni 0 siblings, 1 reply; 8+ messages in thread From: Mikael Eliasson @ 2018-08-21 20:20 UTC (permalink / raw) To: buildroot Hi, 2018-08-21 21:54 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > Mikael, All, > > On 2018-08-21 20:34 +0200, Mikael Eliasson spake thusly: > > Is there anything else you need me to do to include this package? I > > cannot see that it has been added in github yet. > > Don;t worry, it is not lost, but: > > 1. There are currently 197 patches pending: > https://patchwork.ozlabs.org/project/buildroot/list/ > > 2. We are in feature-freeze for the release scheduled by the end of the > month. > > 3. The Github repository is not the official tree; it is only a mirror. > The official tree is: https://git.buildroot.org/buildroot/ OK. Just wanted to know if it was worth putting in the effort on the next patch I'm working on. > > > Regards, > Yann E. MORIN. > > -- > .-----------------.--------------------.------------------.- > -------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' > conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ > | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is > no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v > conspiracy. | > '------------------------------^-------^------------------^- > -------------------' > /Thanks Mikael -- Mikael Eliasson Telefon: +46703900837 Email: mikael at robomagi.com Adress: Robomagi AB T?ngringsgatan 26A 78430 Borl?nge -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180821/8d00b3cb/attachment.html> ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] libjwt: new package. 2018-08-21 20:20 ` Mikael Eliasson @ 2018-08-21 20:25 ` Thomas Petazzoni 0 siblings, 0 replies; 8+ messages in thread From: Thomas Petazzoni @ 2018-08-21 20:25 UTC (permalink / raw) To: buildroot Hello, On Tue, 21 Aug 2018 22:20:32 +0200, Mikael Eliasson wrote: > > Don;t worry, it is not lost, but: > > > > 1. There are currently 197 patches pending: > > https://patchwork.ozlabs.org/project/buildroot/list/ > > > > 2. We are in feature-freeze for the release scheduled by the end of the > > month. > > > > 3. The Github repository is not the official tree; it is only a mirror. > > The official tree is: https://git.buildroot.org/buildroot/ > > OK. Just wanted to know if it was worth putting in the effort on the next > patch I'm working on. Yes, it is definitely worth the effort. The latency to get patches merged can be pretty high, but no patches gets forgotten, thanks to our patch tracking system. New packages are rarely controversial (unless they have some significant complexity or strange things) and are very likely to be merged. But it does take some time. Thanks for your contributions! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-08-21 20:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-08-11 20:29 [Buildroot] [PATCH 1/1] libjwt: new package Mikael 2018-08-12 12:39 ` Thomas Petazzoni 2018-08-12 16:08 ` Mikael Eliasson 2018-08-12 19:25 ` Yann E. MORIN 2018-08-21 18:34 ` Mikael Eliasson 2018-08-21 19:54 ` Yann E. MORIN 2018-08-21 20:20 ` Mikael Eliasson 2018-08-21 20:25 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox