Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] openresolv: new package
Date: Tue, 14 Aug 2018 16:12:00 +0200	[thread overview]
Message-ID: <20180814161200.08d4a984@windsurf> (raw)
In-Reply-To: <1533648586-60818-1-git-send-email-matthew.weber@rockwellcollins.com>

Hello Matt,

On Tue,  7 Aug 2018 08:29:46 -0500, Matt Weber wrote:

>  package/Config.in                  |  1 +
>  package/openresolv/Config.in       | 13 +++++++++++++
>  package/openresolv/openresolv.hash |  3 +++
>  package/openresolv/openresolv.mk   | 12 ++++++++++++
>  4 files changed, 29 insertions(+)

Entry in DEVELOPERS file is missing.

> diff --git a/package/Config.in b/package/Config.in
> index f5a1749..2ad6687 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1843,6 +1843,7 @@ endif
>  	source "package/open-plc-utils/Config.in"
>  	source "package/openntpd/Config.in"
>  	source "package/openobex/Config.in"
> +	source "package/openresolv/Config.in"
>  	source "package/openssh/Config.in"
>  	source "package/openswan/Config.in"
>  	source "package/openvpn/Config.in"
> diff --git a/package/openresolv/Config.in b/package/openresolv/Config.in
> new file mode 100644
> index 0000000..3eb736f
> --- /dev/null
> +++ b/package/openresolv/Config.in
> @@ -0,0 +1,13 @@
> +comment "openresolv needs a bash shell"
> +	depends on !BR2_SYSTEM_BIN_SH_BASH

Are you sure it needs a bash shell ? Indeed in
https://github.com/rsmarples/openresolv, the #1 argument for resolvconf
compared to its Debian variant is:

""
Works with POSIX shell and userland
""

> $(eval $(autotools-package))

This package is not using the autotools. The configure script is not
generated by autoconf, the Makefile is not generated by automake. So,
generic-package should be used, and not autotools-package.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-08-14 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07 13:29 [Buildroot] [PATCH] openresolv: new package Matt Weber
2018-08-14 14:12 ` Thomas Petazzoni [this message]
2018-08-14 14:37   ` Matthew Weber
2018-08-14 14:55     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180814161200.08d4a984@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox