Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1] qt5serialbus: examples need qt5 widgets module
@ 2018-08-14 21:13 Peter Seiderer
  2018-08-14 21:42 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Seiderer @ 2018-08-14 21:13 UTC (permalink / raw)
  To: buildroot

Fixes [1]:

  make[2]: Entering directory '.../build/qt5serialbus-5.11.1/examples'
  Some of the required modules (qtHaveModule(widgets)) are not available.
  Skipped.
  [...]
  cp -dpfr .../host/mips64el-buildroot-linux-gnu/sysroot/usr/lib/qt/examples/serialbus .../target/usr/lib/qt/examples/
  cp: cannot stat '.../host/mips64el-buildroot-linux-gnu/sysroot/usr/lib/qt/examples/serialbus': No such file or directory

[1] http://autobuild.buildroot.net/results/147809b5f8758af935bee48c0fc83fd86a8509e9

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/qt5/qt5serialbus/qt5serialbus.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/qt5/qt5serialbus/qt5serialbus.mk b/package/qt5/qt5serialbus/qt5serialbus.mk
index 6de9f9b7d3..98c4466cb8 100644
--- a/package/qt5/qt5serialbus/qt5serialbus.mk
+++ b/package/qt5/qt5serialbus/qt5serialbus.mk
@@ -36,7 +36,7 @@ define QT5SERIALBUS_INSTALL_TARGET_LIBS
 endef
 endif
 
-ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
+ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES)$(BR2_PACKAGE_QT5BASE_WIDGETS),yy)
 define QT5SERIALBUS_INSTALL_TARGET_EXAMPLES
 	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/serialbus $(TARGET_DIR)/usr/lib/qt/examples/
 endef
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v1] qt5serialbus: examples need qt5 widgets module
  2018-08-14 21:13 [Buildroot] [PATCH v1] qt5serialbus: examples need qt5 widgets module Peter Seiderer
@ 2018-08-14 21:42 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-08-14 21:42 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue, 14 Aug 2018 23:13:09 +0200, Peter Seiderer wrote:
> Fixes [1]:
> 
>   make[2]: Entering directory '.../build/qt5serialbus-5.11.1/examples'
>   Some of the required modules (qtHaveModule(widgets)) are not available.
>   Skipped.
>   [...]
>   cp -dpfr .../host/mips64el-buildroot-linux-gnu/sysroot/usr/lib/qt/examples/serialbus .../target/usr/lib/qt/examples/
>   cp: cannot stat '.../host/mips64el-buildroot-linux-gnu/sysroot/usr/lib/qt/examples/serialbus': No such file or directory
> 
> [1] http://autobuild.buildroot.net/results/147809b5f8758af935bee48c0fc83fd86a8509e9
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/qt5/qt5serialbus/qt5serialbus.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks. We really need to switch to using "make
install" for target installation of Qt5 modules at some point. This
will allow to avoid duplicating all the installation logic in our .mk
file, including all those conditionals.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-14 21:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-14 21:13 [Buildroot] [PATCH v1] qt5serialbus: examples need qt5 widgets module Peter Seiderer
2018-08-14 21:42 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox