From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/7 v4] support/dependencies: check for system-provided bison and flex
Date: Sat, 18 Aug 2018 23:29:05 +0200 [thread overview]
Message-ID: <20180818232905.70811759@windsurf> (raw)
In-Reply-To: <20180818231758.69bc7209@windsurf>
Hello,
On Sat, 18 Aug 2018 23:17:58 +0200, Thomas Petazzoni wrote:
> This solution (which differs from what we do for other dependencies,
> that are using suitable-host-package) has a drawback: it shows stderr
> on the terminal, despite the 2>/dev/null:
>
> $ make
> which: no bison in (/usr/local/bin:/usr/bin:/bin:/home/thomas/.rvm/bin:/usr/local/sbin:/usr/sbin:/home/thomas/.rvm/bin:/home/thomas/sys/bin:/home/thomas/.gem/ruby/2.1.0/bin:/home/thomas/.rvm/bin)
>
> I'm not sure why this happens.
Wait, wait, scratch that. Even without your patch it does that. This
error is displayed because of:
BISON := $(shell which bison || type -p bison)
in package/Makefile.in. I'm not even sure why we have this definition,
we don't use it anywhere, ditto for the FLEX definition.
So basically your patch looks good, we probably need to remove the
useless lines in package/Makefile.in, as a separate patch.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-18 21:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 16:06 [Buildroot] [PATCH 0/7 v4] core/pkg-kconfig: ensure we have necessary tools to run configurators Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 1/7 v4] linux: explain why we need host-{flex, bison} Yann E. MORIN
2018-08-18 21:13 ` Thomas Petazzoni
2018-08-17 16:06 ` [Buildroot] [PATCH 2/7 v4] support/dependencies: check for system-provided bison and flex Yann E. MORIN
2018-08-18 21:17 ` Thomas Petazzoni
2018-08-18 21:29 ` Thomas Petazzoni [this message]
2018-08-17 16:06 ` [Buildroot] [PATCH 3/7 v4] core/pkg-kconfig: allow dependencies before configurators Yann E. MORIN
2018-08-18 21:22 ` Thomas Petazzoni
2018-08-17 16:06 ` [Buildroot] [PATCH 4/7 v4] linux: kconfig may need host-{flex, bison} to build the configurators Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 5/7 v4] linux: host-{flex, bison} only needed for DTS Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 6/7 v4] linux: kconfig needs the toolchain Yann E. MORIN
2018-08-17 16:06 ` [Buildroot] [PATCH 7/7 v4] boot/uboot: needs host-{flex,bison} Yann E. MORIN
2018-09-13 19:04 ` Thomas Petazzoni
2018-08-20 14:10 ` [Buildroot] [PATCH 0/7 v4] core/pkg-kconfig: ensure we have necessary tools to run configurators Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180818232905.70811759@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox