[Buildroot] [PATCH] synopsys/hsdk: Boot log cleanup

[Buildroot] [PATCH] synopsys/hsdk: Boot log cleanup

[Evgeniy Didin]

Remove duplicate messages in boot log on HSDK board.
Console ttyS3 is already set in Linux bootargs.

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: arc-buildroot at synopsys.com
---
 board/synopsys/hsdk/uboot.env.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/synopsys/hsdk/uboot.env.txt b/board/synopsys/hsdk/uboot.env.txt
index 6bcfb56a77..216f0c9043 100644
--- a/board/synopsys/hsdk/uboot.env.txt
+++ b/board/synopsys/hsdk/uboot.env.txt
@@ -1,5 +1,5 @@
 baudrate=115200
-bootargs=console=ttyS3,115200n8 root=/dev/mmcblk0p2 rootwait
+bootargs=root=/dev/mmcblk0p2 rootwait
 bootcmd=fatload mmc 0:1; bootm
 bootdelay=2
 bootfile=uImage
-- 
2.16.2

[Buildroot] [PATCH] synopsys/hsdk: Boot log cleanup

[Thomas Petazzoni]

Hello,

On Mon, 20 Aug 2018 20:39:38 +0300, Evgeniy Didin wrote:
> Remove duplicate messages in boot log on HSDK board.
> Console ttyS3 is already set in Linux bootargs.
> 
> Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: arc-buildroot at synopsys.com
> ---
>  board/synopsys/hsdk/uboot.env.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/synopsys/hsdk/uboot.env.txt b/board/synopsys/hsdk/uboot.env.txt
> index 6bcfb56a77..216f0c9043 100644
> --- a/board/synopsys/hsdk/uboot.env.txt
> +++ b/board/synopsys/hsdk/uboot.env.txt
> @@ -1,5 +1,5 @@
>  baudrate=115200
> -bootargs=console=ttyS3,115200n8 root=/dev/mmcblk0p2 rootwait
> +bootargs=root=/dev/mmcblk0p2 rootwait

Well, *these* are the Linux bootargs.

Do you mean that something else is re-adding "console=ttyS3" to the
bootargs ?

Could you clarify ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] synopsys/hsdk: Boot log cleanup

[Evgeniy Didin]

Hello Thomas,

On Mon, 2018-08-20 at 19:48 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 20 Aug 2018 20:39:38 +0300, Evgeniy Didin wrote:
> > Remove duplicate messages in boot log on HSDK board.
> > Console ttyS3 is already set in Linux bootargs.
> > 
> > Signed-off-by: Evgeniy Didin <didin@synopsys.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Cc: arc-buildroot at synopsys.com
> > ---
> >  board/synopsys/hsdk/uboot.env.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/board/synopsys/hsdk/uboot.env.txt b/board/synopsys/hsdk/uboot.env.txt
> > index 6bcfb56a77..216f0c9043 100644
> > --- a/board/synopsys/hsdk/uboot.env.txt
> > +++ b/board/synopsys/hsdk/uboot.env.txt
> > @@ -1,5 +1,5 @@
> >  baudrate=115200
> > -bootargs=console=ttyS3,115200n8 root=/dev/mmcblk0p2 rootwait
> > +bootargs=root=/dev/mmcblk0p2 rootwait
> 
> Well, *these* are the Linux bootargs.
> 
> Do you mean that something else is re-adding "console=ttyS3" to the
> bootargs ?
> 
> Could you clarify ?

For HSDK board we setup bootargs via device tree, see https://elixir.bootlin.com/linux/latest/source/arch/arc/boot/dts/hsdk.dts#L25
"console=ttyS3" was mistakenly placed in u-boot bootargs which are appended to Kernel bootargs.

> Thanks,
> 
> Thomas

Best regards,
Evgeniy Didin

[Buildroot] [PATCH] synopsys/hsdk: Boot log cleanup

[Thomas Petazzoni]

Hello,

On Mon, 20 Aug 2018 18:13:15 +0000, Evgeniy Didin wrote:

> For HSDK board we setup bootargs via device tree, see https://elixir.bootlin.com/linux/latest/source/arch/arc/boot/dts/hsdk.dts#L25
> "console=ttyS3" was mistakenly placed in u-boot bootargs which are appended to Kernel bootargs.

OK. This must be an ARC-specific behavior, because on ARM, the U-Boot
bootargs *replace* the DT bootargs.

Thanks for the additional explanation.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com