From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libssh: fix cross compile with older cmake
Date: Thu, 23 Aug 2018 08:39:07 +0200 [thread overview]
Message-ID: <20180823063907.GC9365@scaer> (raw)
In-Reply-To: <87h8jlvjdi.fsf@tkos.co.il>
Baruch, All,
On 2018-08-23 06:42 +0300, Baruch Siach spake thusly:
> Yann E. MORIN writes:
> > On 2018-08-23 00:09 +0200, Yann E. MORIN spake thusly:
> >> On 2018-08-23 00:58 +0300, Baruch Siach spake thusly:
> >> > Old version of cmake break cross-compilation when FindThreads is used
> >> > because of a try_run call. Add a workaround that avoids try_run.
> >> >
> >> > cmake bug report: https://gitlab.kitware.com/cmake/cmake/issues/16920
> >> >
> >> > Should fix:
> >> > http://autobuild.buildroot.net/results/8aa/8aa2bd894416a4508ca7140f8947ff46243f8b78/
> >> > http://autobuild.buildroot.net/results/f2c/f2cc965bb134bf4fd9e625eb267b67c949c202fc/
> >> >
> >> > Cc: Scott Fan <fancp2007@gmail.com>
> >> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> >> > ---
> >> > Hi Peter, Yann,
> >> >
> >> > Can one of you test this fix on one of the affected autobuilders?
> >> >
> >> > http://autobuild.buildroot.net/?reason=libssh-0.8.1
[--SNIP--]
> > Here are the results of the configure step, using the config from my
> > autobuilder referenced above, and running 'make libssh-depends' first:
>
> You meant to say 'make libssh-configure' here, right?
No I meant that I ran:
$ make libssh-depends
[...]
$ make libssh-configure
[...]
And I only pasted starting with the second command.
> So I reproduced the build failure and the fix with host-cmake here as
> well.
Thanks for finding the issue and fixing it. :-)
[--SNIP--]
> > CMake Warning:
> > Manually-specified variables were not used by the project:
[--SNIP--]
> > THREADS_PTHREAD_ARG
I find it weird that THREADS_PTHREAD_ARG is reported as unused, when it
is actually it that fixes the issue... :-/
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-08-23 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 21:58 [Buildroot] [PATCH] libssh: fix cross compile with older cmake Baruch Siach
2018-08-22 22:09 ` Yann E. MORIN
2018-08-22 22:27 ` Yann E. MORIN
2018-08-23 3:42 ` Baruch Siach
2018-08-23 6:39 ` Yann E. MORIN [this message]
2018-08-23 9:24 ` Jan Kundrát
2018-08-23 9:45 ` Thomas Petazzoni
2018-08-23 9:47 ` Thomas Petazzoni
2018-10-24 11:21 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823063907.GC9365@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox