From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libssh: fix cross compile with older cmake
Date: Thu, 23 Aug 2018 11:45:53 +0200 [thread overview]
Message-ID: <20180823114553.31dca123@windsurf> (raw)
In-Reply-To: <6362092b-e799-47b1-9066-97b8118d27b5@cesnet.cz>
Hello,
On Thu, 23 Aug 2018 11:24:47 +0200, Jan Kundr?t wrote:
> Are you sure that this is a correct fix? From reading the
> FindThreads.cmake, passing OFF looks like it results in not feeding the
> -pthread option to the compiler. That breaks some scenarios such as ASAN,
> see [1] for details.
At least, we are doing it in a number of other packages:
package/exiv2/exiv2.mk:EXIV2_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/i2pd/i2pd.mk:I2PD_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/librtlsdr/librtlsdr.mk:LIBRTLSDR_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
package/rabbitmq-c/rabbitmq-c.mk:RABBITMQ_C_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
It doesn't mean it's correct, but at least that's how we are working
around this problem at the moment. If it's not the correct way, then we
should fix it globally :-)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-23 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 21:58 [Buildroot] [PATCH] libssh: fix cross compile with older cmake Baruch Siach
2018-08-22 22:09 ` Yann E. MORIN
2018-08-22 22:27 ` Yann E. MORIN
2018-08-23 3:42 ` Baruch Siach
2018-08-23 6:39 ` Yann E. MORIN
2018-08-23 9:24 ` Jan Kundrát
2018-08-23 9:45 ` Thomas Petazzoni [this message]
2018-08-23 9:47 ` Thomas Petazzoni
2018-10-24 11:21 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823114553.31dca123@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox