[Buildroot] [PATCH v3 0/2] i2c-tools: license and staging installation fixes

[Buildroot] [PATCH v3 0/2] i2c-tools: license and staging installation fixes

[Brad Love]

Patch 1/2 updates i2c-tools.mk to include the LGPL-2.1+ license which
applies to the library libi2c.

Patch 2/2 enables staging installation, using make targets to install
the header and dynamic or static library for use by external packages.

since v2:
- Added COPYING.LGPL and README to license files
- Expand commit message for newly included files
- Regen patch 2/2

since v1:
- condensed make install-lib and make install-include to make install
- Updated commit message
- fixed patch typo (library to libi2c)

 
Brad Love (2):
  i2c-tools: include LGPL-2.1+ license for libi2c
  i2c-tools: install library and header to staging

 package/i2c-tools/i2c-tools.mk | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.7.4

[Buildroot] [PATCH v3 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Brad Love]

Extend i2c-tools SPDX identifiers to include the library license.
Also include COPYING.LGPL and README to license files.

The ic2-tools readme states:

LICENSE

Check the documentation of individual tools for licensing information.
The library is released under the LGPL version 2.1 or later, while most
tools are released under the GPL version 2 or later, but there are a few
exceptions.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
since v2:
- Added COPYING.LGPL and README to license files
- Expand commit message for newly included files

 package/i2c-tools/i2c-tools.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index db26647..ec06c73 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -7,8 +7,8 @@
 I2C_TOOLS_VERSION = 4.0
 I2C_TOOLS_SOURCE = i2c-tools-$(I2C_TOOLS_VERSION).tar.xz
 I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
-I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus)
-I2C_TOOLS_LICENSE_FILES = COPYING
+I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
+I2C_TOOLS_LICENSE_FILES = COPYING COPYING.LGPL README
 I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
 
 ifeq ($(BR2_PACKAGE_PYTHON),y)
-- 
2.7.4

[Buildroot] [PATCH v3 2/2] i2c-tools: install library and header to staging

[Brad Love]

When the dynamic/static library of i2c-tools is enabled it is installed
to the target destination. However, in order for external packages to
link against it, it must also be installed to staging.

Here, the flag is set to install the package to staging. The
INSTALL_STAGING command is included to complete the operation.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
since v2:
- regen

since v1:
- condensed make install-lib and make install-include to make install
- Updated commit message
- fixed patch typo (library to libi2c)

 package/i2c-tools/i2c-tools.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/i2c-tools/i2c-tools.mk b/package/i2c-tools/i2c-tools.mk
index ec06c73..11d0cf9 100644
--- a/package/i2c-tools/i2c-tools.mk
+++ b/package/i2c-tools/i2c-tools.mk
@@ -10,6 +10,7 @@ I2C_TOOLS_SITE = https://www.kernel.org/pub/software/utils/i2c-tools
 I2C_TOOLS_LICENSE = GPL-2.0+, GPL-2.0 (py-smbus), LGPL-2.1+ (libi2c)
 I2C_TOOLS_LICENSE_FILES = COPYING COPYING.LGPL README
 I2C_TOOLS_MAKE_OPTS = EXTRA=eeprog
+I2C_TOOLS_INSTALL_STAGING = YES
 
 ifeq ($(BR2_PACKAGE_PYTHON),y)
 I2C_TOOLS_DEPENDENCIES += python
@@ -62,4 +63,9 @@ define I2C_TOOLS_INSTALL_TARGET_CMDS
 	$(I2C_TOOLS_INSTALL_PYSMBUS)
 endef
 
+define I2C_TOOLS_INSTALL_STAGING_CMDS
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) $(I2C_TOOLS_MAKE_OPTS) \
+		DESTDIR="$(STAGING_DIR)" prefix=/usr -C $(@D) install
+endef
+
 $(eval $(generic-package))
-- 
2.7.4

[Buildroot] [PATCH v3 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Thomas Petazzoni]

Hello,

On Fri, 24 Aug 2018 08:54:06 -0500, Brad Love wrote:
> Extend i2c-tools SPDX identifiers to include the library license.
> Also include COPYING.LGPL and README to license files.
> 
> The ic2-tools readme states:
> 
> LICENSE
> 
> Check the documentation of individual tools for licensing information.
> The library is released under the LGPL version 2.1 or later, while most
> tools are released under the GPL version 2 or later, but there are a few
> exceptions.
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>

I've applied to master, but after adding the hashes of the additional
license files to i2c-tools.hash.

Yann: is it expected than missing hashes for license files is not a
hard failure, when a hash file is present ? Perhaps it was back in the
days, but maybe we should tighten up this ?

Or at least in the case where one of the license files has a hash that
is present, which was the case here.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v3 2/2] i2c-tools: install library and header to staging

[Thomas Petazzoni]

Hello,

On Fri, 24 Aug 2018 08:54:07 -0500, Brad Love wrote:
> When the dynamic/static library of i2c-tools is enabled it is installed
> to the target destination. However, in order for external packages to
> link against it, it must also be installed to staging.
> 
> Here, the flag is set to install the package to staging. The
> INSTALL_STAGING command is included to complete the operation.
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>
> ---
> since v2:
> - regen

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v3 1/2] i2c-tools: include LGPL-2.1+ license for libi2c

[Yann E. MORIN]

Thomas, All,

On 2018-08-24 23:57 +0200, Thomas Petazzoni spake thusly:
> On Fri, 24 Aug 2018 08:54:06 -0500, Brad Love wrote:
> > Extend i2c-tools SPDX identifiers to include the library license.
> > Also include COPYING.LGPL and README to license files.
> > 
> > The ic2-tools readme states:
> > 
> > LICENSE
> > 
> > Check the documentation of individual tools for licensing information.
> > The library is released under the LGPL version 2.1 or later, while most
> > tools are released under the GPL version 2 or later, but there are a few
> > exceptions.
> > 
> > Signed-off-by: Brad Love <brad@nextdimension.cc>
> 
> I've applied to master, but after adding the hashes of the additional
> license files to i2c-tools.hash.
> 
> Yann: is it expected than missing hashes for license files is not a
> hard failure, when a hash file is present ? Perhaps it was back in the
> days, but maybe we should tighten up this ?

Definitely, we should make it a hard error, yes.

> Or at least in the case where one of the license files has a hash that
> is present, which was the case here.

If the .hash file is present, then all files must have a corresponding
hash in there. That's the rule for downloaded files; it should also be
the rule for license files.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'