* [Buildroot] [PATCH] gst1-plugins-good: enable jack plugins if jack2 is on
@ 2018-08-23 20:18 Brad Love
2018-08-24 21:24 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Brad Love @ 2018-08-23 20:18 UTC (permalink / raw)
To: buildroot
Jack2 audio server is part of buildroot, but the jack gst plugins
are disabled completely in gst1-plugins-good, whether or not jack2
is selected. This changes the logic to where if the build system
determines jack2 audio server is selected, then the jack plugins are
enabled. If the plugins are enabled, then jack2 is also added as a
dependency to gst1-plugins-good.
Signed-off-by: Brad Love <brad@nextdimension.cc>
---
package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
index c1ed039..21a7668 100644
--- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
+++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
@@ -25,13 +25,19 @@ GST1_PLUGINS_GOOD_CONF_OPTS = \
# Options which require currently unpackaged libraries
GST1_PLUGINS_GOOD_CONF_OPTS += \
- --disable-jack \
--disable-libdv \
--disable-dv1394 \
--disable-shout2
GST1_PLUGINS_GOOD_DEPENDENCIES = gstreamer1 gst1-plugins-base
+ifeq ($(BR2_PACKAGE_JACK2),y)
+GST1_PLUGINS_GOOD_CONF_OPTS += --enable-jack
+GST1_PLUGINS_GOOD_DEPENDENCIES += jack2
+else
+GST1_PLUGINS_GOOD_CONF_OPTS += --disable-jack
+endif
+
ifeq ($(BR2_PACKAGE_LIBV4L),y)
GST1_PLUGINS_GOOD_CONF_OPTS += --with-libv4l2
GST1_PLUGINS_GOOD_DEPENDENCIES += libv4l
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] gst1-plugins-good: enable jack plugins if jack2 is on
2018-08-23 20:18 [Buildroot] [PATCH] gst1-plugins-good: enable jack plugins if jack2 is on Brad Love
@ 2018-08-24 21:24 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-08-24 21:24 UTC (permalink / raw)
To: buildroot
Hello Brad,
On Thu, 23 Aug 2018 15:18:05 -0500, Brad Love wrote:
> Jack2 audio server is part of buildroot, but the jack gst plugins
> are disabled completely in gst1-plugins-good, whether or not jack2
> is selected. This changes the logic to where if the build system
> determines jack2 audio server is selected, then the jack plugins are
> enabled. If the plugins are enabled, then jack2 is also added as a
> dependency to gst1-plugins-good.
>
>
> Signed-off-by: Brad Love <brad@nextdimension.cc>
> ---
> package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-24 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-23 20:18 [Buildroot] [PATCH] gst1-plugins-good: enable jack plugins if jack2 is on Brad Love
2018-08-24 21:24 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox