From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/brltty: fix cross-compilation
Date: Sat, 25 Aug 2018 14:40:11 +0200 [thread overview]
Message-ID: <20180825144011.20ed76af@windsurf> (raw)
In-Reply-To: <20180822082832.7497-1-yann.morin.1998@free.fr>
Hello,
On Wed, 22 Aug 2018 10:28:32 +0200, Yann E. MORIN wrote:
> brltty has a very inventive buildsystem, where it internall runs
> ./configure for the build machine In doing so, it generates a list
> of make variables to define what the build machine supports, like
> it does for the target.
>
> However, the build variables are generated with a convoluted sed
> script that scans the target list, and appends _FOR_BUILD to each
> target variables. Then, both lists are included from the Makefile,
> on the assumption that the build variables will not clash with the
> target variables.
>
> Where it gets interesting, is that that sed script considers the
> variables names to match '[A-Za-z][A-Za-z0-9_]*'
>
> And there we see why ATSPI2_PACKAGE does not match: it contains a
> digit.
>
> So, some build variables will inevitably override target ones.
>
> Fix that by simply expanding the matching regexp to allow digits
> in variable names.
>
> Fixes:
> http://autobuild.buildroot.org/results/a37/a37782b3cfc1a96cc129db8fade20a36a7b2d470/
> http://autobuild.buildroot.org/results/97e/97edc6a47d2140968e84b409cdc960604e5896f2/
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Mario Lang <mlang@blind.guru>
> Cc: Baruch Siach <baruch@tkos.co.il>
> ---
> .../0004-buildsys-fix-cross-compilation.patch | 41 ++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 package/brltty/0004-buildsys-fix-cross-compilation.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-25 12:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 8:28 [Buildroot] [PATCH] package/brltty: fix cross-compilation Yann E. MORIN
2018-08-22 10:04 ` Baruch Siach
2018-08-22 20:05 ` Yann E. MORIN
2018-08-22 10:12 ` Mario Lang
2018-08-22 15:34 ` Yann E. MORIN
2018-08-22 18:01 ` Peter Seiderer
2018-08-22 20:02 ` Yann E. MORIN
2018-08-25 12:40 ` Thomas Petazzoni [this message]
2018-08-26 21:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825144011.20ed76af@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox