From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 4/4] configs: add linux boot logo to a selection of configs
Date: Mon, 27 Aug 2018 11:08:10 +0200 [thread overview]
Message-ID: <20180827110810.1cdea92c@windsurf> (raw)
In-Reply-To: <1535118300-26815-4-git-send-email-angelo@amarulasolutions.com>
Hello,
On Fri, 24 Aug 2018 15:45:00 +0200, Angelo Compagnucci wrote:
> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
> This patch adds the buildroot logo as a boot log to a selection of
> defconfigs.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
I won't oppose to this very strongly, but I wanted to voice my opinion
that I am not sure it is very useful to adjust all those defconfigs to
make them use the "Buildroot Linux logo".
One aspect of Buildroot that I like a lot is that we don't try to do a
lot of "integration": we use upstream stuff as-is, and leave it up to
the Buildroot user to do all the polishing/integration. Having a
default logo with Buildroot branding goes a bit against this principle.
We'll have a random set of defconfigs using the logo, another random
set not using the logo. This really doesn't had much value overall.
So I'm very fine with PATCH 1/4 and 2/4 to help people customizing the
logo. Perhaps 3/4 to have an example logo (but not even sure it is
that useful), but I'm more skeptical about PATCH 4/4.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-27 9:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 13:44 [Buildroot] [PATCH v4 1/4] package/imagemagick: add host package Angelo Compagnucci
2018-08-24 13:44 ` [Buildroot] [PATCH v4 2/4] linux: add custom linux logo Angelo Compagnucci
2018-08-24 21:19 ` Yann E. MORIN
2018-10-21 16:15 ` Peter Korsgaard
2018-08-24 13:44 ` [Buildroot] [PATCH v4 3/4] docs/images: adding default buildroot " Angelo Compagnucci
2018-08-24 21:27 ` Yann E. MORIN
2018-08-27 9:05 ` Thomas Petazzoni
2018-08-27 9:07 ` Angelo Compagnucci
2018-08-24 13:45 ` [Buildroot] [PATCH v4 4/4] configs: add linux boot logo to a selection of configs Angelo Compagnucci
2018-08-24 21:49 ` Yann E. MORIN
2018-08-24 22:55 ` Angelo Compagnucci
2018-08-25 7:33 ` Yann E. MORIN
2018-08-27 9:08 ` Thomas Petazzoni [this message]
2018-08-27 17:34 ` Angelo Compagnucci
2018-08-24 21:17 ` [Buildroot] [PATCH v4 1/4] package/imagemagick: add host package Yann E. MORIN
2018-10-21 15:23 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827110810.1cdea92c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox