Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/4] package/imagemagick: add host package
Date: Sun, 21 Oct 2018 17:23:00 +0200	[thread overview]
Message-ID: <871s8j7297.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1535118300-26815-1-git-send-email-angelo@amarulasolutions.com> (Angelo Compagnucci's message of "Fri, 24 Aug 2018 15:44:57 +0200")

>>>>> "Angelo" == Angelo Compagnucci <angelo@amarulasolutions.com> writes:

 > From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
 > This patch adds the host package for imagemagick.
 > It comes with a minimal selection of configure options to
 > compile fast cause it is used only to convert
 > the image files for the custom linux logo.

 > Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
 > ---
 >  package/imagemagick/imagemagick.mk | 11 +++++++++++
 >  1 file changed, 11 insertions(+)

 > diff --git a/package/imagemagick/imagemagick.mk b/package/imagemagick/imagemagick.mk
 > index 4aa9d56..0eb94b7 100644
 > --- a/package/imagemagick/imagemagick.mk
 > +++ b/package/imagemagick/imagemagick.mk
 > @@ -143,4 +143,15 @@ else
 >  IMAGEMAGICK_CONF_OPTS += --without-bzlib
 >  endif
 
 > +HOST_IMAGEMAGICK_CONF_OPTS = \
 > +	--with-jpeg \
 > +	--with-png \
 > +	--with-zlib

You forgot to explicitly disable all the other configure options like we
do for the target variant.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2018-10-21 15:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 13:44 [Buildroot] [PATCH v4 1/4] package/imagemagick: add host package Angelo Compagnucci
2018-08-24 13:44 ` [Buildroot] [PATCH v4 2/4] linux: add custom linux logo Angelo Compagnucci
2018-08-24 21:19   ` Yann E. MORIN
2018-10-21 16:15   ` Peter Korsgaard
2018-08-24 13:44 ` [Buildroot] [PATCH v4 3/4] docs/images: adding default buildroot " Angelo Compagnucci
2018-08-24 21:27   ` Yann E. MORIN
2018-08-27  9:05   ` Thomas Petazzoni
2018-08-27  9:07     ` Angelo Compagnucci
2018-08-24 13:45 ` [Buildroot] [PATCH v4 4/4] configs: add linux boot logo to a selection of configs Angelo Compagnucci
2018-08-24 21:49   ` Yann E. MORIN
2018-08-24 22:55     ` Angelo Compagnucci
2018-08-25  7:33       ` Yann E. MORIN
2018-08-27  9:08   ` Thomas Petazzoni
2018-08-27 17:34     ` Angelo Compagnucci
2018-08-24 21:17 ` [Buildroot] [PATCH v4 1/4] package/imagemagick: add host package Yann E. MORIN
2018-10-21 15:23 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871s8j7297.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox