From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] python-falcon: new package
Date: Wed, 29 Aug 2018 21:44:16 +0200 [thread overview]
Message-ID: <20180829214416.3f0effe0@windsurf> (raw)
In-Reply-To: <20180828101618.4746-2-grzegorz@blach.pl>
Hello,
Thanks for your contribution!
On Tue, 28 Aug 2018 12:16:18 +0200, Grzegorz Blach wrote:
> An unladen web framework for building APIs and app backends.
>
> http://falconframework.org
>
> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
I've applied to next. Two nits below though.
> N: Grzegorz Blach <grzegorz@blach.pl>
> +F: package/python-falcon
The final slash was missing here.
> +PYTHON_FALCON_VERSION = 1.4.1
> +PYTHON_FALCON_SOURCE = falcon-$(PYTHON_FALCON_VERSION).tar.gz
> +PYTHON_FALCON_SITE = https://files.pythonhosted.org/packages/2f/e6/5045da9df509b9259037f065d15608930fd6c997ee930ad230f9fbfecf15
> +PYTHON_FALCON_SETUP_TYPE = setuptools
> +PYTHON_FALCON_LICENSE_FILES = LICENSE
The PYTHON_FALCON_LICENSE variable was missing. Interestingly, it was
present in your first version of the patch, but following Yegor's
review, you re-did the package using scanpypi, and scanpypi didn't add
the license information.
Yegor: could you tweak scanpypi so that it warns if no licensing
information could be added to the package ? Perhaps it should even in
this case generate something like:
PYTHON_FALCON_LICENSE = FIXME before submitting
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-29 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 10:16 [Buildroot] [PATCH 1/2] python-mimeparse: new package Grzegorz Blach
2018-08-28 10:16 ` [Buildroot] [PATCH 2/2] python-falcon: " Grzegorz Blach
2018-08-28 10:18 ` Yegor Yefremov
2018-08-28 16:34 ` Joseph Kogut
2018-08-29 19:47 ` Thomas Petazzoni
2018-08-29 20:25 ` Grzegorz Blach
2018-08-29 20:37 ` Thomas Petazzoni
2018-08-29 21:58 ` Joseph Kogut
2018-08-30 7:31 ` Thomas Petazzoni
2018-08-30 10:20 ` Grzegorz Blach
2018-08-29 19:44 ` Thomas Petazzoni [this message]
2018-08-29 19:45 ` Yegor Yefremov
2018-08-28 10:18 ` [Buildroot] [PATCH 1/2] python-mimeparse: " Yegor Yefremov
2018-08-29 19:17 ` Thomas Petazzoni
2018-08-29 19:46 ` Thomas Petazzoni
2018-08-29 20:03 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829214416.3f0effe0@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox