Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] python-mimeparse: new package
Date: Wed, 29 Aug 2018 21:46:03 +0200	[thread overview]
Message-ID: <20180829214603.1bc17321@windsurf> (raw)
In-Reply-To: <20180828101618.4746-1-grzegorz@blach.pl>

Hello,

Another small nit that I realized afterwards and fixed, see below.

On Tue, 28 Aug 2018 12:16:17 +0200, Grzegorz Blach wrote:

> +PYTHON_MIMEPARSE_SOURCE = python-mimeparse-$(PYTHON_MIMEPARSE_VERSION).tar.gz

This is the default value of the _SOURCE variable, defined by the
python-package infrastructure when _SOURCE is not provided. Therefore,
there is no need to specify the _SOURCE variable in this case. This is
detected by our check-package checker:

package/python-mimeparse/python-mimeparse.mk:8: remove default value of _SOURCE variable

Yegor: scanpypi should be fixed to not emit the _SOURCE variable in
this case.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-08-29 19:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 10:16 [Buildroot] [PATCH 1/2] python-mimeparse: new package Grzegorz Blach
2018-08-28 10:16 ` [Buildroot] [PATCH 2/2] python-falcon: " Grzegorz Blach
2018-08-28 10:18   ` Yegor Yefremov
2018-08-28 16:34   ` Joseph Kogut
2018-08-29 19:47     ` Thomas Petazzoni
2018-08-29 20:25       ` Grzegorz Blach
2018-08-29 20:37         ` Thomas Petazzoni
2018-08-29 21:58       ` Joseph Kogut
2018-08-30  7:31         ` Thomas Petazzoni
2018-08-30 10:20           ` Grzegorz Blach
2018-08-29 19:44   ` Thomas Petazzoni
2018-08-29 19:45     ` Yegor Yefremov
2018-08-28 10:18 ` [Buildroot] [PATCH 1/2] python-mimeparse: " Yegor Yefremov
2018-08-29 19:17 ` Thomas Petazzoni
2018-08-29 19:46 ` Thomas Petazzoni [this message]
2018-08-29 20:03   ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829214603.1bc17321@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox