[Buildroot] [PATCH 1/1] domoticz: do not use static version of openssl

[Buildroot] [PATCH 1/1] domoticz: do not use static version of openssl

[Fabrice Fontaine]

Due to the dependency on mosquitto, domoticz depends on !BR2_STATIC_LIBS
so set USE_OPENSSL_STATIC to OFF (default value is ON)

This could fix this non reproducible failure:
 - http://autobuild.buildroot.net/results/b1b84b8c12d31b9242b5732fcdd1eb76b1217366

Indeed, domoticz finds the static version of openssl:

-- Found OpenSSL:
/home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a (found version "1.0.2p")
-- OPENSSL_LIBRARIES:
/home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a;/home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a

But fails to link with the shared version:

/home/test/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/6.4.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld:
CMakeFiles/domoticz.dir/hardware/plugins/PluginTransports.cpp.o: undefined reference to symbol 'SSL_get_error'
/home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libssl.so.1.0.0: error adding symbols: DSO missing from command line

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/domoticz/domoticz.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/domoticz/domoticz.mk b/package/domoticz/domoticz.mk
index 3d6cae4746..7f094d0976 100644
--- a/package/domoticz/domoticz.mk
+++ b/package/domoticz/domoticz.mk
@@ -19,8 +19,10 @@ DOMOTICZ_DEPENDENCIES = \
 	zlib
 
 # Due to the dependency on mosquitto, domoticz depends on
-# !BR2_STATIC_LIBS so set USE_STATIC_BOOST to OFF
-DOMOTICZ_CONF_OPTS += -DUSE_STATIC_BOOST=OFF
+# !BR2_STATIC_LIBS so set USE_STATIC_BOOST and USE_OPENSSL_STATIC to OFF
+DOMOTICZ_CONF_OPTS += \
+	-DUSE_STATIC_BOOST=OFF \
+	-DUSE_OPENSSL_STATIC=OFF
 
 # Do not use any built-in libraries which are enabled by default for
 # lua, sqlite and mqtt
-- 
2.14.1

[Buildroot] [PATCH 1/1] domoticz: do not use static version of openssl

[Thomas Petazzoni]

Hello,

On Wed, 29 Aug 2018 18:53:12 +0200, Fabrice Fontaine wrote:
> Due to the dependency on mosquitto, domoticz depends on !BR2_STATIC_LIBS
> so set USE_OPENSSL_STATIC to OFF (default value is ON)
> 
> This could fix this non reproducible failure:
>  - http://autobuild.buildroot.net/results/b1b84b8c12d31b9242b5732fcdd1eb76b1217366
> 
> Indeed, domoticz finds the static version of openssl:
> 
> -- Found OpenSSL:
> /home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a (found version "1.0.2p")
> -- OPENSSL_LIBRARIES:
> /home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a;/home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a
> 
> But fails to link with the shared version:
> 
> /home/test/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/6.4.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld:
> CMakeFiles/domoticz.dir/hardware/plugins/PluginTransports.cpp.o: undefined reference to symbol 'SSL_get_error'
> /home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libssl.so.1.0.0: error adding symbols: DSO missing from command line
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Hum. So I guess reading the wording of your commit message that you
didn't manage to reproduce the problem, nor verify that the patch was
fixing it ?

Looking at http://autobuild.buildroot.net/?reason=domoticz%, the
problem clearly started suddenly appearing on July 4th.

The previous failure of domoticz was on March 1st, then no failures for
several months, and then suddenly on July 4th, we start to see this
failure, which was not seen before it seems.

The "bump to version 4.9700" was committed on June 27. Is it possible
that it is the reason for the new build failure ? So it means this case
would not have been tested between June 27 and July 4 ? Possible.

I'm running right now a build of one specific build failure to see if I
can reproduce and get more details about what's going.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] domoticz: do not use static version of openssl

[Fabrice Fontaine]

Dear Thomas,

Le mer. 29 ao?t 2018 ? 21:39, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a ?crit :

> Hello,
>
> On Wed, 29 Aug 2018 18:53:12 +0200, Fabrice Fontaine wrote:
> > Due to the dependency on mosquitto, domoticz depends on !BR2_STATIC_LIBS
> > so set USE_OPENSSL_STATIC to OFF (default value is ON)
> >
> > This could fix this non reproducible failure:
> >  -
> http://autobuild.buildroot.net/results/b1b84b8c12d31b9242b5732fcdd1eb76b1217366
> >
> > Indeed, domoticz finds the static version of openssl:
> >
> > -- Found OpenSSL:
> >
> /home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a
> (found version "1.0.2p")
> > -- OPENSSL_LIBRARIES:
> >
> /home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libssl.a;/home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libcrypto.a
> >
> > But fails to link with the shared version:
> >
> >
> /home/test/autobuild/run/instance-0/output/host/opt/ext-toolchain/bin/../lib/gcc/mipsel-buildroot-linux-uclibc/6.4.0/../../../../mipsel-buildroot-linux-uclibc/bin/ld:
> > CMakeFiles/domoticz.dir/hardware/plugins/PluginTransports.cpp.o:
> undefined reference to symbol 'SSL_get_error'
> >
> /home/test/autobuild/run/instance-0/output/host/mipsel-buildroot-linux-uclibc/sysroot/usr/lib/libssl.so.1.0.0:
> error adding symbols: DSO missing from command line
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Hum. So I guess reading the wording of your commit message that you
> didn't manage to reproduce the problem, nor verify that the patch was
> fixing it ?
>
Thats's right, I was not able to reproduce it.

>
> Looking at http://autobuild.buildroot.net/?reason=domoticz%, the
> problem clearly started suddenly appearing on July 4th.
>
> The previous failure of domoticz was on March 1st, then no failures for
> several months, and then suddenly on July 4th, we start to see this
> failure, which was not seen before it seems.
>
> The "bump to version 4.9700" was committed on June 27. Is it possible
> that it is the reason for the new build failure ? So it means this case
> would not have been tested between June 27 and July 4 ? Possible.
>
It shoud be noted that the USE_OPENSSL_STATIC option was added in 4.9700:
https://github.com/domoticz/domoticz/commit/2ae1d315d16962ff1c22f539aa5ddc708b95241a.
Before this version, openssl was not statically linked by default.

> I'm running right now a build of one specific build failure to see if I
> can reproduce and get more details about what's going.
>
Thanks for your help.

>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180829/143bdb28/attachment.html>

[Buildroot] [PATCH 1/1] domoticz: do not use static version of openssl

[Thomas Petazzoni]

Hello,

On Wed, 29 Aug 2018 23:26:52 +0200, Fabrice Fontaine wrote:

> > Hum. So I guess reading the wording of your commit message that you
> > didn't manage to reproduce the problem, nor verify that the patch was
> > fixing it ?
> >  
> Thats's right, I was not able to reproduce it.

I was able to reproduce it. You can do it using the br-reproduce-build
script [1]:

./br-reproduce-build 8e072a91ded61a3c2ae1f740f098d3ada274d52b

[1] https://git.buildroot.net/buildroot-test/plain/utils/br-reproduce-build

> > Looking at http://autobuild.buildroot.net/?reason=domoticz%, the
> > problem clearly started suddenly appearing on July 4th.
> >
> > The previous failure of domoticz was on March 1st, then no failures for
> > several months, and then suddenly on July 4th, we start to see this
> > failure, which was not seen before it seems.
> >
> > The "bump to version 4.9700" was committed on June 27. Is it possible
> > that it is the reason for the new build failure ? So it means this case
> > would not have been tested between June 27 and July 4 ? Possible.
> >  
> It shoud be noted that the USE_OPENSSL_STATIC option was added in 4.9700:
> https://github.com/domoticz/domoticz/commit/2ae1d315d16962ff1c22f539aa5ddc708b95241a.
> Before this version, openssl was not statically linked by default.
> 
> > I'm running right now a build of one specific build failure to see if I
> > can reproduce and get more details about what's going.
> >  
> Thanks for your help.

I was able to reproduce it with the command above, I'll see if I have
some time to investigate further, but if you do have some time, don't
hesitate to do so :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com