* [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3
@ 2018-08-30 10:14 Asaf Kahlon
2018-08-30 15:10 ` Thomas Petazzoni
2018-09-01 13:53 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Asaf Kahlon @ 2018-08-30 10:14 UTC (permalink / raw)
To: buildroot
The tld-parser script in libsoup is now written in Python,
and needs python3 to run.
Fixes:
http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af
Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
Maybe this specific script can run even with python2, but I don't think patchting the
"/usr/bin/env python3" line would be the right solution, especially considering
the fact that they already have python3-only code in recent commits.
---
package/libsoup/libsoup.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libsoup/libsoup.mk b/package/libsoup/libsoup.mk
index 95bd682010..ef17f27fcd 100644
--- a/package/libsoup/libsoup.mk
+++ b/package/libsoup/libsoup.mk
@@ -14,7 +14,7 @@ LIBSOUP_INSTALL_STAGING = YES
LIBSOUP_CONF_ENV = ac_cv_path_GLIB_GENMARSHAL=$(LIBGLIB2_HOST_BINARY)
LIBSOUP_CONF_OPTS = --disable-glibtest --enable-vala=no --with-gssapi=no
LIBSOUP_DEPENDENCIES = host-pkgconf host-libglib2 \
- libglib2 libxml2 sqlite host-intltool
+ libglib2 libxml2 sqlite host-intltool host-python3
ifeq ($(BR2_PACKAGE_LIBSOUP_GNOME),y)
LIBSOUP_CONF_OPTS += --with-gnome
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3
2018-08-30 10:14 [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3 Asaf Kahlon
@ 2018-08-30 15:10 ` Thomas Petazzoni
2018-08-30 18:11 ` Baruch Siach
2018-09-01 13:53 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-08-30 15:10 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote:
> The tld-parser script in libsoup is now written in Python,
> and needs python3 to run.
>
> Fixes:
> http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
> http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af
>
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
>
> ---
>
> Maybe this specific script can run even with python2, but I don't think patchting the
> "/usr/bin/env python3" line would be the right solution, especially considering
> the fact that they already have python3-only code in recent commits.
Meh, I was hoping we could avoid the host-python3 dependency :-/
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3
2018-08-30 15:10 ` Thomas Petazzoni
@ 2018-08-30 18:11 ` Baruch Siach
2018-08-30 18:51 ` Asaf Kahlon
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2018-08-30 18:11 UTC (permalink / raw)
To: buildroot
Hi Asaf, Thomas,
Thomas Petazzoni writes:
> On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote:
>> The tld-parser script in libsoup is now written in Python,
>> and needs python3 to run.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
>> http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af
>>
>> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
>>
>> ---
>>
>> Maybe this specific script can run even with python2, but I don't think patchting the
>> "/usr/bin/env python3" line would be the right solution, especially considering
>> the fact that they already have python3-only code in recent commits.
Which commits do you refer to? The get_apache_module_dirs.py script is
only used by the meson build system, as far as I can see.
> Meh, I was hoping we could avoid the host-python3 dependency :-/
Later commits remove this script entirely. So we might be able to remove
this dependency in the future.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3
2018-08-30 18:11 ` Baruch Siach
@ 2018-08-30 18:51 ` Asaf Kahlon
0 siblings, 0 replies; 5+ messages in thread
From: Asaf Kahlon @ 2018-08-30 18:51 UTC (permalink / raw)
To: buildroot
Thomas, Baruch,
Indeed I meant to the get_apache_module_dirs.py script.
After looking deeper I can agree that the script seems to be used only with
meson-context.
Therefore, it seems like this dependency is relevant only for this version,
and after we bump the version it will be removed.
Asaf.
On Thu, Aug 30, 2018 at 9:11 PM Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Asaf, Thomas,
>
> Thomas Petazzoni writes:
> > On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote:
> >> The tld-parser script in libsoup is now written in Python,
> >> and needs python3 to run.
> >>
> >> Fixes:
> >>
> http://autobuild.buildroot.net/results/91c2d6a1ca011787130db06695d6cd9e882f7258
> >>
> http://autobuild.buildroot.net/results/a318e595f02937534b3f8698ef4c04194a8b34af
> >>
> >> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> >>
> >> ---
> >>
> >> Maybe this specific script can run even with python2, but I don't think
> patchting the
> >> "/usr/bin/env python3" line would be the right solution, especially
> considering
> >> the fact that they already have python3-only code in recent commits.
>
> Which commits do you refer to? The get_apache_module_dirs.py script is
> only used by the meson build system, as far as I can see.
>
> > Meh, I was hoping we could avoid the host-python3 dependency :-/
>
> Later commits remove this script entirely. So we might be able to remove
> this dependency in the future.
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open
> Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180830/07439f5d/attachment.html>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3
2018-08-30 10:14 [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3 Asaf Kahlon
2018-08-30 15:10 ` Thomas Petazzoni
@ 2018-09-01 13:53 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-09-01 13:53 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 30 Aug 2018 13:14:30 +0300, Asaf Kahlon wrote:
> Maybe this specific script can run even with python2, but I don't think patchting the
> "/usr/bin/env python3" line would be the right solution, especially considering
> the fact that they already have python3-only code in recent commits.
I disagree: the tld-parser.py script was changed from python to python3
with no reason other than "hey, let's use Python 3", and the script
works fine with Python 2. Plus in newer versions of libsoup, the script
has been removed entirely, and libsoup relies on a separate library to
provide TLD information.
So for now, I've committed a change that simply reverts the script to
use "python".
Thanks for your initial research on this topic!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-01 13:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-30 10:14 [Buildroot] [PATCH 1/1] package/libsoup: needs host-python3 Asaf Kahlon
2018-08-30 15:10 ` Thomas Petazzoni
2018-08-30 18:11 ` Baruch Siach
2018-08-30 18:51 ` Asaf Kahlon
2018-09-01 13:53 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox