From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] synergy: change upstream location to fix download issues
Date: Tue, 4 Sep 2018 10:03:50 +0200 [thread overview]
Message-ID: <20180904100350.15acb6fc@windsurf> (raw)
In-Reply-To: <1262e995-3152-4014-dad5-770f2e83a4ac@mind.be>
Hello,
On Tue, 4 Sep 2018 00:25:27 +0200, Arnout Vandecappelle wrote:
> > My idea was to have it on master and next, but indeed I did not think
> > about 2018.02.x/2018.05.x being broken :-/
>
> Wait, how are these broken? Quoting the commit message:
>
> On master as of 811734ef9044bbdfc067da76358153061fae2031, we use
> v1.8.8, which fails to download from github.com, so we fallback to
> sources.buildroot.net, which has the tarball.
synergy is using version 1.8.8 since commit
caa16c13e0fef18ae1142f502ee39d2af8f5172e, which was merged in 2017.05.
> >> Looking at the synergy git history, a hack could be to bump the version
> >> to the commit just after v1.8.8 together with changing the URL so we end
> >> up with a new tarball name:
> >>
> >> commit ec56ac4485ef8e3cf986107b8456949b5aec3527
> >> Author: Andrew Nelless <andrew@symless.com>
> >> Date: Fri Mar 3 14:51:23 2017 +0000
> >>
> >> Fix version number in Changelog
> >
> > Or perhaps we simply don't fix it in master, and only in next ? The big
> > downside I see with not fixing in master is that people who look at
> > their build log will see the upstream download fail due to the hash
> > mismatch, and the fallback to sources.buildroot.net.
>
> It's not a hash mismatch, it's a 404. So in my book, that's fine.
True. But if people fix to use the new upstream, then the hash becomes
different. But perhaps that's OK.
So all in all, you're saying that we should keep it as-is in
master/2018.02.x/2018.05.x, and simply change in next ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-04 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-02 20:45 [Buildroot] [PATCH] synergy: change upstream location to fix download issues Thomas Petazzoni
2018-09-03 7:20 ` Peter Korsgaard
2018-09-03 8:26 ` Thomas Petazzoni
2018-09-03 8:54 ` Peter Korsgaard
2018-09-03 22:25 ` Arnout Vandecappelle
2018-09-04 8:03 ` Thomas Petazzoni [this message]
2018-09-04 8:52 ` Arnout Vandecappelle
2018-09-06 7:05 ` Peter Korsgaard
2018-09-08 20:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904100350.15acb6fc@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox