Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] synergy: change upstream location to fix download issues
Date: Mon, 03 Sep 2018 10:54:26 +0200	[thread overview]
Message-ID: <87sh2r2c71.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180903102655.6f7f8df4@windsurf> (Thomas Petazzoni's message of "Mon, 3 Sep 2018 10:26:55 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello,
 > On Mon, 03 Sep 2018 09:20:10 +0200, Peter Korsgaard wrote:

 >> >  SYNERGY_VERSION = v1.8.8-stable
 >> > -SYNERGY_SITE = $(call github,symless,synergy,$(SYNERGY_VERSION))
 >> > +SYNERGY_SITE = $(call github,symless,synergy-core,$(SYNERGY_VERSION))  
 >> 
 >> So is the idea to apply this to next or to master? If we change the hash
 >> for the 1.8.8 version, then this will break download for the 2018.02.x /
 >> 2018.05.x releases.

 > My idea was to have it on master and next, but indeed I did not think
 > about 2018.02.x/2018.05.x being broken :-/

 >> Looking at the synergy git history, a hack could be to bump the version
 >> to the commit just after v1.8.8 together with changing the URL so we end
 >> up with a new tarball name:
 >> 
 >> commit ec56ac4485ef8e3cf986107b8456949b5aec3527
 >> Author: Andrew Nelless <andrew@symless.com>
 >> Date:   Fri Mar 3 14:51:23 2017 +0000
 >> 
 >> Fix version number in Changelog

 > Or perhaps we simply don't fix it in master, and only in next ? The big
 > downside I see with not fixing in master is that people who look at
 > their build log will see the upstream download fail due to the hash
 > mismatch, and the fallback to sources.buildroot.net. A
 > security-conscious user could rightfully think that Buildroot is trying
 > to sneak in a backdoor in the synergy code by providing a different
 > version on sources.buildroot.net than what upstream provides.

s/not fixing in master/not fixing in master and 2018.0{2,5}.x/.

I guess the best solution is to bump to the git hash just after the
1.8.8 at the new upstream location (perhaps with a comment that this is
1.8.8) and apply that to all 3 branches.

I will do a last release of 2018.05.x in a week or 2 and mark it as EOL.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2018-09-03  8:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-02 20:45 [Buildroot] [PATCH] synergy: change upstream location to fix download issues Thomas Petazzoni
2018-09-03  7:20 ` Peter Korsgaard
2018-09-03  8:26   ` Thomas Petazzoni
2018-09-03  8:54     ` Peter Korsgaard [this message]
2018-09-03 22:25     ` Arnout Vandecappelle
2018-09-04  8:03       ` Thomas Petazzoni
2018-09-04  8:52         ` Arnout Vandecappelle
2018-09-06  7:05           ` Peter Korsgaard
2018-09-08 20:41 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sh2r2c71.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox