From: "Gaël PORTAY" <gael.portay@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/3] qt5webkit: fix build issue using system leveldb
Date: Tue, 4 Sep 2018 11:11:01 -0400 [thread overview]
Message-ID: <20180904151101.2vz46vm7q33scp4c@archlinux> (raw)
In-Reply-To: <92bebe0f-479a-a17d-219c-834fadf318f3@mind.be>
Arnout,
On Tue, Sep 04, 2018 at 12:53:17AM +0200, Arnout Vandecappelle wrote:
> (...)
>
> > Note: Also, since leveldb has moved to cmake, this symbol is now a part
> > of libleveldb.so and there is not more libmemenv.a [2] :/
>
> So, wouldn't a bump of leveldb which moves to cmake solve the issue entirely?
>
First of all, the version is not yet out (1.21).
I think, the bump will partially solve that issue (not tested, but I can
give it a try).
With the bump, QtWebKit would compile it as a third-party (fair but not
wanted) and would link against libleveldb.so which will be provided by
buildroot (1.21 with the missing symbol). In that situation, the
third-party is compiled but not used and the build will succeed.
If the configure flag WEBKIT_CONFIG+=use_system_leveldb is added,
QtWebKit would not compile leveldb as a third-party (wanted) but it
would try to link against libraries liblevel.db (okay) *AND* libmemenv.a
from buildroot's staging. But the last one will not exist and the
compilation would fail.
Even with the bump, (and if the configure flag is added) QtWebKit needs
to be patched to remove the -lmemenv from the compilation line; because
the libmemenv will disappear.
A good fix consists in to force QtWebKit to use its third-party library
(giving the full path?) so it will not link against the copy from
buildroot's staging.
> >> (...)
> >>
> >> All in all, I'm just worried by the installation of what looks like
> >> some internal library/headers of leveldb. Could you comment on this ?
> >>
> >
> > We can consider memenv as an option of leveldb which installs the memenv
> > development files (static library and header).
>
> Since it's only a static library and a header, it only gets installed to
> staging, not target, so there is no reason to make it optional.
>
Okay, I will drop the option and respin a new version.
> Regards,
> Arnout
>
>
> [snip]
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Regards,
Ga?l
next prev parent reply other threads:[~2018-09-04 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 20:22 [Buildroot] [PATCH 0/3] qt5webkit: fix build issue using system leveldb Gaël PORTAY
2018-08-31 20:22 ` [Buildroot] [PATCH 1/3] leveldb: install memenv static library and headers Gaël PORTAY
2018-08-31 20:22 ` [Buildroot] [PATCH 2/3] leveldb: generate pic for static libraries Gaël PORTAY
2018-08-31 20:22 ` [Buildroot] [PATCH 3/3] qt5webkit: select leveldb package Gaël PORTAY
2018-09-04 21:10 ` Arnout Vandecappelle
2018-09-05 6:53 ` Thomas Petazzoni
2018-08-31 21:19 ` [Buildroot] [PATCH 0/3] qt5webkit: fix build issue using system leveldb Thomas Petazzoni
2018-09-02 20:21 ` Gaël PORTAY
2018-09-03 22:53 ` Arnout Vandecappelle
2018-09-04 15:11 ` Gaël PORTAY [this message]
2018-09-04 21:09 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904151101.2vz46vm7q33scp4c@archlinux \
--to=gael.portay@savoirfairelinux.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox