Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] qt5webkit: select leveldb package
Date: Wed, 5 Sep 2018 08:53:18 +0200	[thread overview]
Message-ID: <20180905085318.4ae7a818@windsurf> (raw)
In-Reply-To: <01e51af4-335b-7b8b-7c03-c8c00960eb20@mind.be>

Hello,

On Tue, 4 Sep 2018 23:10:46 +0200, Arnout Vandecappelle wrote:
> On 31/08/2018 22:22, Ga?l PORTAY wrote:
> > +	depends on BR2_INSTALL_LIBSTDCPP # leveldb  
> 
>  I don't think we need to propagate this particular dependency - qt5webkit
> already depends on libstdcpp indirectly through Qt5.

I think we need at some point to define a real policy for this. When a
dependency is redundant, should we:

 (1) Avoid duplicating it, to simplify things, but with the risk that
     if we remove the dependency at a higher-level, we forget to re-add
     back to the sub-options.

 (2) Always duplicate them, even if they are useless right now, so
     that we don't forget them in the future if the higher-level option
     drops this dependency. Drawback of this solution is that such
     dependencies don't get "exercised" by autobuilder testing so they
     are often wrong.

I don't have a strong opinion, but we're doing (1) or (2) depending on
the package developer and/or situation, and this isn't really nice.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-05  6:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 20:22 [Buildroot] [PATCH 0/3] qt5webkit: fix build issue using system leveldb Gaël PORTAY
2018-08-31 20:22 ` [Buildroot] [PATCH 1/3] leveldb: install memenv static library and headers Gaël PORTAY
2018-08-31 20:22 ` [Buildroot] [PATCH 2/3] leveldb: generate pic for static libraries Gaël PORTAY
2018-08-31 20:22 ` [Buildroot] [PATCH 3/3] qt5webkit: select leveldb package Gaël PORTAY
2018-09-04 21:10   ` Arnout Vandecappelle
2018-09-05  6:53     ` Thomas Petazzoni [this message]
2018-08-31 21:19 ` [Buildroot] [PATCH 0/3] qt5webkit: fix build issue using system leveldb Thomas Petazzoni
2018-09-02 20:21   ` Gaël PORTAY
2018-09-03 22:53     ` Arnout Vandecappelle
2018-09-04 15:11       ` Gaël PORTAY
2018-09-04 21:09         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905085318.4ae7a818@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox