[Buildroot] [PATCH v2, 1/1] moarvm: fix build on powerpc64 / powerpc64le

[Buildroot] [PATCH v2, 1/1] moarvm: fix build on powerpc64 / powerpc64le

[Fabrice Fontaine]

Build fails with:
 In file included from dyncall_callback.c:35:0:
dyncall_callback_ppc64.c: In function 'dcbNewCallback':
dyncall_callback_ppc64.c:42:13: warning: implicit declaration of function 'dcAllocWX' [-Wimplicit-function-declaration]
   int err = dcAllocWX(sizeof(DCCallback), (void**) &pcb);
             ^~~~~~~~~
dyncall_callback_ppc64.c: In function 'dcbFreeCallback':
dyncall_callback_ppc64.c:53:3: warning: implicit declaration of function 'dcFreeWX' [-Wimplicit-function-declaration]
   dcFreeWX(pcb, sizeof(DCCallback));
   ^~~~~~~~
dyncall_callback_ppc64.S: Assembler messages:
dyncall_callback_ppc64.S:180: Error: operand out of range (3 is not between 0 and 1)

So select BR2_PACKAGE_LIBFFI for BR2_powerpc64 and BR2_powerpc64le as it
is already done for MIPS

Fixes:
 - http://autobuild.buildroot.org/results/97b53a74d9847c07f26178daeb1daff3b6c24813
 - http://autobuild.buildroot.org/results/c35ac4bbc5fb04aabf5a719eddeedf55f7f1f4eb

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2:
 - Fix error in Config.in (use || instead of |)

 package/moarvm/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/moarvm/Config.in b/package/moarvm/Config.in
index 3ff4f827e0..c370a0f229 100644
--- a/package/moarvm/Config.in
+++ b/package/moarvm/Config.in
@@ -12,7 +12,8 @@ config BR2_PACKAGE_MOARVM
 	select BR2_PACKAGE_LIBATOMIC_OPS
 	# dyncall does not work on MIPS; libffi needs to be used.
 	# See: https://github.com/MoarVM/MoarVM/issues/222
-	select BR2_PACKAGE_LIBFFI if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+	# dyncall does not work also on powerpc64 and powerpc64le
+	select BR2_PACKAGE_LIBFFI if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || BR2_powerpc64 || BR2_powerpc64le
 	help
 	  Short for "Metamodel On A Runtime", MoarVM is a virtual
 	  machine built especially for Rakudo Perl 6 and the NQP
-- 
2.17.1

[Buildroot] [PATCH v2, 1/1] moarvm: fix build on powerpc64 / powerpc64le

[Thomas Petazzoni]

Hello,

On Wed,  5 Sep 2018 00:18:07 +0200, Fabrice Fontaine wrote:
> Build fails with:
>  In file included from dyncall_callback.c:35:0:
> dyncall_callback_ppc64.c: In function 'dcbNewCallback':
> dyncall_callback_ppc64.c:42:13: warning: implicit declaration of function 'dcAllocWX' [-Wimplicit-function-declaration]
>    int err = dcAllocWX(sizeof(DCCallback), (void**) &pcb);
>              ^~~~~~~~~
> dyncall_callback_ppc64.c: In function 'dcbFreeCallback':
> dyncall_callback_ppc64.c:53:3: warning: implicit declaration of function 'dcFreeWX' [-Wimplicit-function-declaration]
>    dcFreeWX(pcb, sizeof(DCCallback));
>    ^~~~~~~~
> dyncall_callback_ppc64.S: Assembler messages:
> dyncall_callback_ppc64.S:180: Error: operand out of range (3 is not between 0 and 1)
> 
> So select BR2_PACKAGE_LIBFFI for BR2_powerpc64 and BR2_powerpc64le as it
> is already done for MIPS
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/97b53a74d9847c07f26178daeb1daff3b6c24813
>  - http://autobuild.buildroot.org/results/c35ac4bbc5fb04aabf5a719eddeedf55f7f1f4eb
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
>  - Fix error in Config.in (use || instead of |)

Applied to master, thanks. Could you please report the issue to the
upstream project ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2, 1/1] moarvm: fix build on powerpc64 / powerpc64le

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Build fails with:
 >  In file included from dyncall_callback.c:35:0:
 > dyncall_callback_ppc64.c: In function 'dcbNewCallback':
 > dyncall_callback_ppc64.c:42:13: warning: implicit declaration of function 'dcAllocWX' [-Wimplicit-function-declaration]
 >    int err = dcAllocWX(sizeof(DCCallback), (void**) &pcb);
 >              ^~~~~~~~~
 > dyncall_callback_ppc64.c: In function 'dcbFreeCallback':
 > dyncall_callback_ppc64.c:53:3: warning: implicit declaration of function 'dcFreeWX' [-Wimplicit-function-declaration]
 >    dcFreeWX(pcb, sizeof(DCCallback));
 >    ^~~~~~~~
 > dyncall_callback_ppc64.S: Assembler messages:
 > dyncall_callback_ppc64.S:180: Error: operand out of range (3 is not between 0 and 1)

 > So select BR2_PACKAGE_LIBFFI for BR2_powerpc64 and BR2_powerpc64le as it
 > is already done for MIPS

 > Fixes:
 >  - http://autobuild.buildroot.org/results/97b53a74d9847c07f26178daeb1daff3b6c24813
 >  - http://autobuild.buildroot.org/results/c35ac4bbc5fb04aabf5a719eddeedf55f7f1f4eb

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2:
 >  - Fix error in Config.in (use || instead of |)

Committed to 2018.02.x and 2018.05.x, thanks.

-- 
Bye, Peter Korsgaard