[Buildroot] [PATCH 1/1] toolchain: add 4.18.x choice for headers

[Buildroot] [PATCH 1/1] toolchain: add 4.18.x choice for headers

[Thomas Petazzoni]

Hello J?r?me,

On Thu,  6 Sep 2018 09:42:16 +0200, Jerome Forissier wrote:
> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
> ---
>  toolchain/Config.in                                                  | 5 +++++
>  .../toolchain-external/toolchain-external-custom/Config.in.options   | 4 ++++
>  2 files changed, 9 insertions(+)
> 
> FYI, this is needed in order to use the GCC 8.2.x recently published by
> Arm [1] as an external toolchain.
> 
> [1] https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads

Thanks for this patch. In fact, we already have this in our "next"
branch:

  https://git.buildroot.org/buildroot/commit/toolchain?h=next&id=7f62d8122bc42b84608cad34fb005b4870c143d5

But we could indeed have it in the master branch, so that the most
recent toolchains can be used even with our upcoming 2018.08 release.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] toolchain: add 4.18.x choice for headers

[Jerome Forissier]

On 09/06/2018 10:05 AM, Thomas Petazzoni wrote:
> Hello J?r?me,
> 
> On Thu,  6 Sep 2018 09:42:16 +0200, Jerome Forissier wrote:
>> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
>> ---
>>  toolchain/Config.in                                                  | 5 +++++
>>  .../toolchain-external/toolchain-external-custom/Config.in.options   | 4 ++++
>>  2 files changed, 9 insertions(+)
>>
>> FYI, this is needed in order to use the GCC 8.2.x recently published by
>> Arm [1] as an external toolchain.
>>
>> [1] https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads
> 
> Thanks for this patch. In fact, we already have this in our "next"
> branch:
> 
>   https://git.buildroot.org/buildroot/commit/toolchain?h=next&id=7f62d8122bc42b84608cad34fb005b4870c143d5

Ah, sorry for missing it. In fact I did not know about the existence of
the "next" branch. Would you consider a patch to mention it in
docs/manual/contribute.txt? I also got bitten by the fact that you need
to be subscribed to the ML for patches to go through. Maybe another
thing that {c,sh}ould be mentioned in the doc?

> 
> But we could indeed have it in the master branch, so that the most
> recent toolchains can be used even with our upcoming 2018.08 release.

Yes, that would help indeed.

Thanks,
-- 
Jerome

> Best regards,
> 
> Thomas
> 

[Buildroot] [PATCH 1/1] toolchain: add 4.18.x choice for headers

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello J?r?me,
 > On Thu,  6 Sep 2018 09:42:16 +0200, Jerome Forissier wrote:
 >> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
 >> ---
 >> toolchain/Config.in                                                  | 5 +++++
 >> .../toolchain-external/toolchain-external-custom/Config.in.options   | 4 ++++
 >> 2 files changed, 9 insertions(+)
 >> 
 >> FYI, this is needed in order to use the GCC 8.2.x recently published by
 >> Arm [1] as an external toolchain.
 >> 
 >> [1] https://developer.arm.com/open-source/gnu-toolchain/gnu-a/downloads

 > Thanks for this patch. In fact, we already have this in our "next"
 > branch:

 >   https://git.buildroot.org/buildroot/commit/toolchain?h=next&id=7f62d8122bc42b84608cad34fb005b4870c143d5

 > But we could indeed have it in the master branch, so that the most
 > recent toolchains can be used even with our upcoming 2018.08 release.

I've now cherry picked this commit for master.

-- 
Bye, Peter Korsgaard