Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] flatcc: add dependency on C++11
Date: Thu, 6 Sep 2018 22:43:42 +0200	[thread overview]
Message-ID: <20180906224342.592e16dc@windsurf> (raw)
In-Reply-To: <CAAjKBV9WAQQwxCzqTGYFaAgZ+gwRU8SDNuwWKJmp3=MpQFT+Yg@mail.gmail.com>

Hello,

On Thu, 6 Sep 2018 13:58:15 -0600, Joel Carlson wrote:

> I will dig into this a bit deeper.  The immediate thing I had noticed
> was that CMakeLists.txt changed:
> - project (FlatCC C)
> + project (FlatCC C CXX)
> 
> I only see a single .cpp file, which is in a tests folder.  I will see
> if I can pass/set some options so that C++ isn't necessary, and will
> send a new patch if I find that to be the case.

I see two .cpp files, but indeed both in tests/

$ find . -name '*.cpp'
./test/benchmark/benchflatc/benchflatc.cpp
./test/monster_test_cpp/monster_test.cpp

There is already an option to enable/disable tests:

option(FLATCC_TEST "enable tests" ON)

and we already disable building tests in flatcc.mk:

# Disable build of tests and samples
FLATCC_CONF_OPTS += -DFLATCC_TEST=OFF
HOST_FLATCC_CONF_OPTS += -DFLATCC_TEST=OFF

The CMakeLists.txt needs to be fixed to only require a C++ compiler
when tests are enabled.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-09-06 20:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-06 19:20 [Buildroot] [PATCH] flatcc: add dependency on C++11 Joel Carlson
2018-09-06 19:34 ` Peter Korsgaard
2018-09-06 19:58   ` Joel Carlson
2018-09-06 20:43     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906224342.592e16dc@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox