From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] flatcc: add dependency on C++11
Date: Thu, 06 Sep 2018 21:34:18 +0200 [thread overview]
Message-ID: <87sh2m7745.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1536261611-13825-1-git-send-email-JoelsonCarl@gmail.com> (Joel Carlson's message of "Thu, 6 Sep 2018 13:20:11 -0600")
>>>>> "Joel" == Joel Carlson <joelsoncarl@gmail.com> writes:
> Some of the components built by flatcc require C++. Also, while older
> toolchains may work, C11/C++11 is the reference that is expected to
> always work.
> Fixes
> http://autobuild.buildroot.net/results/8fb0447eed1d55b7687f657530e31695cf77ce5c/
This is an autobuilder on the next branch. Does this mean that only
0.5.2 is affected and not 0.5.1 (the verison on master)?
> Signed-off-by: Joel Carlson <JoelsonCarl@gmail.com>
> ---
> package/flatcc/Config.in | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/package/flatcc/Config.in b/package/flatcc/Config.in
> index 6273f2b..557bd9b 100644
> --- a/package/flatcc/Config.in
> +++ b/package/flatcc/Config.in
> @@ -1,8 +1,15 @@
> config BR2_PACKAGE_FLATCC
> bool "flatcc"
> + # Some components require C++, and C11/C++11 is the reference
> + # expected to always work
> + depends on BR2_INSTALL_LIBSTDCPP
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> help
> flatcc is C language implementation of Google Flatbuffers. It
> consists of both a library for the target as well as a
> flatbuffer compiler tool for the host.
It is a bit odd that a "C language implementation" really needs C++. Are
you sure this isn't just for some kind of optional C++ binding?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-09-06 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 19:20 [Buildroot] [PATCH] flatcc: add dependency on C++11 Joel Carlson
2018-09-06 19:34 ` Peter Korsgaard [this message]
2018-09-06 19:58 ` Joel Carlson
2018-09-06 20:43 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh2m7745.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox