Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH v3 1/1] support/kconfig: Bump to kconfig from Linux 4.17-rc2
Date: Wed, 19 Sep 2018 16:07:57 +0200	[thread overview]
Message-ID: <20180919140756.GA2353@x230> (raw)
In-Reply-To: <20180919152848.616fc616@windsurf>

Hi Thomas,

> Thanks for working on this!

> On Wed, 19 Sep 2018 13:36:15 +0200, Petr Vorel wrote:
> > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > ---
> > Changes v2->v3:
> > * Fix issues with building more that we need (menuconfig require
> > unfortunately "make menuconfig" fails, because
> > it wants ? reported by Thomas in [1]).

> I don't understand this changelog. Could explain a bit more what you
> mean here?

Sure :). v2 build all code no matter whether it was actually needed. E.g. 'make
menuconfig' built gconf (gtk) or qconf (qt). That's a bug you pointed out in
[1].  I fixed it in v3. It was caused by removing ifeq clauses.
Here is the diff v2 vs. v3:

-hostprogs-y := conf nconf mconf kxgettext qconf gconf
+hostprogs-y := conf
+
+ifeq ($(MAKECMDGOALS),nconf)
+	hostprogs-y += nconf
+endif
+
+ifeq ($(MAKECMDGOALS),mconf)
+	hostprogs-y += mconf
+endif
+
+ifeq ($(MAKECMDGOALS),update-po-config)
+	hostprogs-y += kxgettext
+endif
+
+ifeq ($(MAKECMDGOALS),qconf)
+	qconf-target := 1
+endif
+
+ifeq ($(MAKECMDGOALS),gconf)
+	gconf-target := 1
+endif
+
+ifeq ($(qconf-target),1)
+	hostprogs-y += qconf
+endif
+
+ifeq ($(gconf-target),1)
+	hostprogs-y += gconf
+endif

Another change I did is little changes in docs
(support/kconfig/README.buildroot):

-This is a copy of the kconfig code in the kernel (currently 3.13-rc5) tweaked
+This is a copy of the kconfig code in the kernel (currently 4.17-rc2) tweaked
...
 	cd support/kconfig.new
+	# zconf.lex.c and zconf.tab.c needs to be generated by 'make menuconfig'

Kind regards,
Petr

  reply	other threads:[~2018-09-19 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 11:36 [Buildroot] [RFC PATCH v3 1/1] support/kconfig: Bump to kconfig from Linux 4.17-rc2 Petr Vorel
2018-09-19 13:28 ` Thomas Petazzoni
2018-09-19 14:07   ` Petr Vorel [this message]
2018-09-19 14:20     ` Thomas Petazzoni
2018-09-20 21:20 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919140756.GA2353@x230 \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox