From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Point libxslt to the correct location of libxml2
Date: Fri, 21 Sep 2018 13:43:18 +0200 [thread overview]
Message-ID: <20180921134318.78ba7545@windsurf> (raw)
In-Reply-To: <20180921101913.4366-1-ferdinand@ombud.nl>
Hello,
On Fri, 21 Sep 2018 12:19:14 +0200, Ferdinand van Aartsen wrote:
> Currently libxslt configure finds native /usr/bin/xml2-config.
>
> Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>
Thanks for this contribution! The commit title should always follow the
format:
<package>: <description>
so, something like:
libxslt: point to the correct location of xml2-config
> diff --git a/package/libxslt/libxslt.mk b/package/libxslt/libxslt.mk
> index 972d5b80d5..fb5d03ab44 100644
> --- a/package/libxslt/libxslt.mk
> +++ b/package/libxslt/libxslt.mk
> @@ -13,7 +13,8 @@ LIBXSLT_LICENSE_FILES = COPYING
> LIBXSLT_CONF_OPTS = \
> --with-gnu-ld \
> --without-debug \
> - --without-python
> + --without-python \
> + --with-libxml-prefix=$(STAGING_DIR)/usr
> LIBXSLT_CONFIG_SCRIPTS = xslt-config
> LIBXSLT_DEPENDENCIES = host-pkgconf libxml2
>
> @@ -25,7 +26,11 @@ else
> LIBXSLT_CONF_OPTS += --without-crypto
> endif
>
> -HOST_LIBXSLT_CONF_OPTS = --without-debug --without-python --without-crypto
> +HOST_LIBXSLT_CONF_OPTS = \
> + --without-debug \
> + --without-python \
> + --without-crypto \
> + --with-libxml-prefix=$(HOST_DIR)/usr
This should be just $(HOST_DIR), and not $(HOST_DIR)/usr.
Those two minor comments can be fixed when applying the patch, no need
to resend just for that.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-21 11:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 10:19 [Buildroot] [PATCH 1/1] Point libxslt to the correct location of libxml2 Ferdinand van Aartsen
2018-09-21 11:43 ` Thomas Petazzoni [this message]
2018-09-21 12:53 ` Ferdinand van Aartsen
2018-09-21 13:41 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921134318.78ba7545@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox