Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Point libxslt to the correct location of libxml2
Date: Fri, 21 Sep 2018 15:41:42 +0200	[thread overview]
Message-ID: <20180921154142.304957fa@windsurf> (raw)
In-Reply-To: <5f3afc03d1b11ebb3d8d4ceff8ef2a65@ombud.nl>

Hello,

On Fri, 21 Sep 2018 14:53:52 +0200, Ferdinand van Aartsen wrote:

> > Those two minor comments can be fixed when applying the patch, no need
> > to resend just for that.
> 
> I copied behaviour I saw in other .mk files.

If you see other places with $(HOST_DIR)/usr, they should be fixed.

> But I double-checked and saw that host-libxslt configure detects the
> right xml2-config without --with-libxml-prefix anyway. So the host
> part can be left as it was.

Indeed, for host packages, $(HOST_DIR)/bin is in the PATH before /bin
and /usr/bin, so it's going to pickup the xml2-config from Buildroot
prior to the system-installed one.

With those two things to fix, perhaps you could send an updated version
of your patch ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-09-21 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 10:19 [Buildroot] [PATCH 1/1] Point libxslt to the correct location of libxml2 Ferdinand van Aartsen
2018-09-21 11:43 ` Thomas Petazzoni
2018-09-21 12:53   ` Ferdinand van Aartsen
2018-09-21 13:41     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921154142.304957fa@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox