Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] domoticz: depends on gcc >= 4.8
@ 2018-09-20 22:01 Fabrice Fontaine
  2018-09-25 21:19 ` Thomas Petazzoni
  2018-10-05 18:26 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2018-09-20 22:01 UTC (permalink / raw)
  To: buildroot

sleep_for is not always defined with gcc <= 4.7, see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52680

To fix this issue, add a dependency to gcc >= 4.8

Fixes:
 - http://autobuild.buildroot.net/results/0dada8dd727f32a4500670f6620adb05943ed0b7

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/domoticz/Config.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
index 530027f273..4c5338df0a 100644
--- a/package/domoticz/Config.in
+++ b/package/domoticz/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_DOMOTICZ
 	depends on BR2_USE_MMU # mosquitto
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # mosquitto
 	depends on !BR2_STATIC_LIBS # mosquitto
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # sleep_for
 	# pthread_condattr_setclock
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_INSTALL_LIBSTDCPP
@@ -27,10 +28,11 @@ config BR2_PACKAGE_DOMOTICZ
 
 	  http://domoticz.com
 
-comment "domoticz needs lua >= 5.2 and a toolchain w/ C++, NPTL, wchar, dynamic library"
+comment "domoticz needs lua >= 5.2 and a toolchain w/ C++, gcc >= 4.8, NPTL, wchar, dynamic library"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_INSTALL_LIBSTDCPP || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
 		!BR2_USE_WCHAR || BR2_STATIC_LIBS || \
 		!(BR2_PACKAGE_LUA_5_2 || BR2_PACKAGE_LUA_5_3)
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] domoticz: depends on gcc >= 4.8
  2018-09-20 22:01 [Buildroot] [PATCH 1/1] domoticz: depends on gcc >= 4.8 Fabrice Fontaine
@ 2018-09-25 21:19 ` Thomas Petazzoni
  2018-10-05 18:26 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-09-25 21:19 UTC (permalink / raw)
  To: buildroot

Hello,

On Fri, 21 Sep 2018 00:01:18 +0200, Fabrice Fontaine wrote:
> sleep_for is not always defined with gcc <= 4.7, see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52680
> 
> To fix this issue, add a dependency to gcc >= 4.8
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/0dada8dd727f32a4500670f6620adb05943ed0b7
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/domoticz/Config.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] domoticz: depends on gcc >= 4.8
  2018-09-20 22:01 [Buildroot] [PATCH 1/1] domoticz: depends on gcc >= 4.8 Fabrice Fontaine
  2018-09-25 21:19 ` Thomas Petazzoni
@ 2018-10-05 18:26 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-10-05 18:26 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > sleep_for is not always defined with gcc <= 4.7, see
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52680

 > To fix this issue, add a dependency to gcc >= 4.8

 > Fixes:
 >  - http://autobuild.buildroot.net/results/0dada8dd727f32a4500670f6620adb05943ed0b7

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-05 18:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-20 22:01 [Buildroot] [PATCH 1/1] domoticz: depends on gcc >= 4.8 Fabrice Fontaine
2018-09-25 21:19 ` Thomas Petazzoni
2018-10-05 18:26 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox