Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] nilfs-utils: drop NPTL dependency
Date: Wed, 26 Sep 2018 22:23:56 +0200	[thread overview]
Message-ID: <20180926202356.GC27972@airbook.echont.local> (raw)
In-Reply-To: <20180926182045.28484-2-fontaine.fabrice@gmail.com>

On wo, 26 sep 2018 20:20:45 +0200, Fabrice Fontaine wrote:
> The latest uClibc-ng version (1.0.30) provides clock_nanosleep() even
> for non NPTL configurations.

Do you mean that buildroot must only be built with uClibc-ng > 1.0.30?

> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/nilfs-utils/Config.in | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
> index e245dc4656..7b239b1af5 100644
> --- a/package/nilfs-utils/Config.in
> +++ b/package/nilfs-utils/Config.in
> @@ -2,7 +2,6 @@ config BR2_PACKAGE_NILFS_UTILS
>  	bool "nilfs-utils"
>  	depends on BR2_USE_MMU # util-linux libmount, libblkid
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
> -	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()

I think you break other configurations here.
Did you try testbuilds with this change?

I remember a strong debate some time ago where the final outcome was
that this constructs is put on several places, and that it would be
better to introduce something like BR2_TOOLCHAIN_HAS_CLOCK_NANOSLEEP
or something alike instead. This would really solve the issue.

>  	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>  	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
>  	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> @@ -12,7 +11,6 @@ config BR2_PACKAGE_NILFS_UTILS
>  
>  	  https://github.com/nilfs-dev/nilfs-utils
>  
> -comment "nilfs-utils needs a toolchain w/ threads, NPTL"
> +comment "nilfs-utils needs a toolchain w/ threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
> -		!BR2_TOOLCHAIN_HAS_THREADS_NPTL
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Kurt

  reply	other threads:[~2018-09-26 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 18:20 [Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true Fabrice Fontaine
2018-09-26 18:20 ` [Buildroot] [PATCH 2/2] nilfs-utils: drop NPTL dependency Fabrice Fontaine
2018-09-26 20:23   ` Kurt Van Dijck [this message]
2018-09-27 12:11     ` Peter Korsgaard
2018-09-27 12:11   ` Peter Korsgaard
2018-09-26 20:12 ` [Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true Kurt Van Dijck
2018-09-27 12:01 ` Peter Korsgaard
2018-10-02 21:17   ` Arnout Vandecappelle
2018-10-05 18:36     ` Peter Korsgaard
2018-10-05 18:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180926202356.GC27972@airbook.echont.local \
    --to=dev.kurt@vandijck-laurijssen.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox