[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Fabrice Fontaine]

Don't display comment if BR2_USE_MMU is true
Moreover, move BR2_USE_MMU dependency at the top of dependency list

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/nilfs-utils/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
index e49cab369b..e245dc4656 100644
--- a/package/nilfs-utils/Config.in
+++ b/package/nilfs-utils/Config.in
@@ -1,8 +1,8 @@
 config BR2_PACKAGE_NILFS_UTILS
 	bool "nilfs-utils"
+	depends on BR2_USE_MMU # util-linux libmount, libblkid
 	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
-	depends on BR2_USE_MMU # util-linux libmount, libblkid
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
 	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
@@ -13,5 +13,6 @@ config BR2_PACKAGE_NILFS_UTILS
 	  https://github.com/nilfs-dev/nilfs-utils
 
 comment "nilfs-utils needs a toolchain w/ threads, NPTL"
+	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL
-- 
2.17.1

[Buildroot] [PATCH 2/2] nilfs-utils: drop NPTL dependency

[Fabrice Fontaine]

The latest uClibc-ng version (1.0.30) provides clock_nanosleep() even
for non NPTL configurations.

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/nilfs-utils/Config.in | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
index e245dc4656..7b239b1af5 100644
--- a/package/nilfs-utils/Config.in
+++ b/package/nilfs-utils/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_NILFS_UTILS
 	bool "nilfs-utils"
 	depends on BR2_USE_MMU # util-linux libmount, libblkid
 	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
-	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
 	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
 	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
 	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
@@ -12,7 +11,6 @@ config BR2_PACKAGE_NILFS_UTILS
 
 	  https://github.com/nilfs-dev/nilfs-utils
 
-comment "nilfs-utils needs a toolchain w/ threads, NPTL"
+comment "nilfs-utils needs a toolchain w/ threads"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.17.1

[Buildroot] [PATCH 2/2] nilfs-utils: drop NPTL dependency

[Kurt Van Dijck]

On wo, 26 sep 2018 20:20:45 +0200, Fabrice Fontaine wrote:
> The latest uClibc-ng version (1.0.30) provides clock_nanosleep() even
> for non NPTL configurations.

Do you mean that buildroot must only be built with uClibc-ng > 1.0.30?

> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/nilfs-utils/Config.in | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
> index e245dc4656..7b239b1af5 100644
> --- a/package/nilfs-utils/Config.in
> +++ b/package/nilfs-utils/Config.in
> @@ -2,7 +2,6 @@ config BR2_PACKAGE_NILFS_UTILS
>  	bool "nilfs-utils"
>  	depends on BR2_USE_MMU # util-linux libmount, libblkid
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
> -	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()

I think you break other configurations here.
Did you try testbuilds with this change?

I remember a strong debate some time ago where the final outcome was
that this constructs is put on several places, and that it would be
better to introduce something like BR2_TOOLCHAIN_HAS_CLOCK_NANOSLEEP
or something alike instead. This would really solve the issue.

>  	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>  	select BR2_PACKAGE_UTIL_LINUX_LIBBLKID
>  	select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
> @@ -12,7 +11,6 @@ config BR2_PACKAGE_NILFS_UTILS
>  
>  	  https://github.com/nilfs-dev/nilfs-utils
>  
> -comment "nilfs-utils needs a toolchain w/ threads, NPTL"
> +comment "nilfs-utils needs a toolchain w/ threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
> -		!BR2_TOOLCHAIN_HAS_THREADS_NPTL
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS

Kurt

[Buildroot] [PATCH 2/2] nilfs-utils: drop NPTL dependency

[Peter Korsgaard]

>>>>> "Kurt" == Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be> writes:

 > On wo, 26 sep 2018 20:20:45 +0200, Fabrice Fontaine wrote:
 >> The latest uClibc-ng version (1.0.30) provides clock_nanosleep() even
 >> for non NPTL configurations.

 > Do you mean that buildroot must only be built with uClibc-ng > 1.0.30?

I guess you mean >= . Indeed, only uClibc-ng 1.0.30 built with our
defconfig is really supported.

1.0.30 was released back in April, so requiring this for our November
release is IMHO OK.

 >> 
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> package/nilfs-utils/Config.in | 6 ++----
 >> 1 file changed, 2 insertions(+), 4 deletions(-)
 >> 
 >> diff --git a/package/nilfs-utils/Config.in b/package/nilfs-utils/Config.in
 >> index e245dc4656..7b239b1af5 100644
 >> --- a/package/nilfs-utils/Config.in
 >> +++ b/package/nilfs-utils/Config.in
 >> @@ -2,7 +2,6 @@ config BR2_PACKAGE_NILFS_UTILS
 >> bool "nilfs-utils"
 >> depends on BR2_USE_MMU # util-linux libmount, libblkid
 >> depends on BR2_TOOLCHAIN_HAS_THREADS # sem_open()
 >> -	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()

 > I think you break other configurations here.
 > Did you try testbuilds with this change?

It does not introduce breakage as such. Before, if you had an uClibc-ng
config without NPTL you couldn't enable this package - Now you can. If
you are using an old pre-1.0.30 external uClibc-ng toolchain then it
will not actually build, but that is a general problem with external
uClibc-ng toolchains if they are not in sync with the internal
toolchain.

In any case, the solution is simply - Just rebuild your toolchain.


 > I remember a strong debate some time ago where the final outcome was
 > that this constructs is put on several places, and that it would be
 > better to introduce something like BR2_TOOLCHAIN_HAS_CLOCK_NANOSLEEP
 > or something alike instead. This would really solve the issue.

The problem is that a user of an external uClibc-ng toolchain has to
answer all these fine grained configuration options (and we have to
verify them), so it doesn't really scale.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 2/2] nilfs-utils: drop NPTL dependency

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > The latest uClibc-ng version (1.0.30) provides clock_nanosleep() even
 > for non NPTL configurations.

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Kurt Van Dijck]

Acked-by: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>

On wo, 26 sep 2018 20:20:44 +0200, Fabrice Fontaine wrote:
> Don't display comment if BR2_USE_MMU is true
> Moreover, move BR2_USE_MMU dependency at the top of dependency list
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Don't display comment if BR2_USE_MMU is true
 > Moreover, move BR2_USE_MMU dependency at the top of dependency list

I'm not sure if that is really any better. I don't think we have any
strong rules about this, but in lack of other rules I would say sort
alphabetically.

But ok, I don't feel strongly about it.

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Arnout Vandecappelle]

On 27/09/2018 14:01, Peter Korsgaard wrote:
>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> 
>  > Don't display comment if BR2_USE_MMU is true
>  > Moreover, move BR2_USE_MMU dependency at the top of dependency list
> 
> I'm not sure if that is really any better. I don't think we have any
> strong rules about this, but in lack of other rules I would say sort
> alphabetically.

 I thought we had a weak rule of:

 - first arch dependencies (i.e. where you have no choice);

 - then toolchain dependencies (i.e. where you can enable them, and which need a
comment);

 - then package dependencies;

 - then select.

And alphabetical within each category.

 Regards,
 Arnout

> 
> But ok, I don't feel strongly about it.
> 
> Committed, thanks.
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 > On 27/09/2018 14:01, Peter Korsgaard wrote:
 >>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
 >> 
 >> > Don't display comment if BR2_USE_MMU is true
 >> > Moreover, move BR2_USE_MMU dependency at the top of dependency list
 >> 
 >> I'm not sure if that is really any better. I don't think we have any
 >> strong rules about this, but in lack of other rules I would say sort
 >> alphabetically.

 >  I thought we had a weak rule of:

 >  - first arch dependencies (i.e. where you have no choice);

 >  - then toolchain dependencies (i.e. where you can enable them, and which need a
 > comment);

 >  - then package dependencies;

 >  - then select.

 > And alphabetical within each category.

Sounds sensible, but I don't think this is written down anywhere
official.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] nilfs-utils: no comment if BR2_USE_MMU is true

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Don't display comment if BR2_USE_MMU is true
 > Moreover, move BR2_USE_MMU dependency at the top of dependency list

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2018.02.x, 2018.05.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard