Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] file: explicitly disable libseccomp support for host
@ 2018-10-08 20:28 Peter Korsgaard
  2018-10-09  6:59 ` Thomas Petazzoni
  2018-10-21 12:50 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-10-08 20:28 UTC (permalink / raw)
  To: buildroot

Fixes:
http://autobuild.buildroot.net/results/8a2/8a2ea2e4426416447705492237f526fc84b595d7/
http://autobuild.buildroot.net/results/a1f/a1f2369d31c2387efdec908877e0bcaa728b5aeb/

file-5.33 added optional seccomp support, but the filters did not cover all
needed syscalls, leading to errors when the freshly built host-file is
executed as part of the build on distributions with seccomp support (E.G.
Arch Linux):

checking for seccomp_init in -lseccomp... yes
..
../src/file -C -m magic
make[3]: *** [Makefile:764: magic.mgc] Bad system call

This has been fixed in file-5.34, but it anyway makes sense to explicitly
disable libseccomp support for consistency as we do not need it for the host
build.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/file/file.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/file/file.mk b/package/file/file.mk
index 42131c4888..b5b12978bc 100644
--- a/package/file/file.mk
+++ b/package/file/file.mk
@@ -12,6 +12,7 @@ FILE_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 FILE_INSTALL_STAGING = YES
 FILE_LICENSE = BSD-2-Clause, BSD-4-Clause (one file), BSD-3-Clause (one file)
 FILE_LICENSE_FILES = COPYING src/mygetopt.h src/vasprintf.c
+HOST_FILE_CONF_OPTS = --disable-libseccomp
 
 ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
 FILE_CONF_OPTS += --enable-libseccomp
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] file: explicitly disable libseccomp support for host
  2018-10-08 20:28 [Buildroot] [PATCH] file: explicitly disable libseccomp support for host Peter Korsgaard
@ 2018-10-09  6:59 ` Thomas Petazzoni
  2018-10-21 12:50 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-10-09  6:59 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon,  8 Oct 2018 22:28:34 +0200, Peter Korsgaard wrote:
> Fixes:
> http://autobuild.buildroot.net/results/8a2/8a2ea2e4426416447705492237f526fc84b595d7/
> http://autobuild.buildroot.net/results/a1f/a1f2369d31c2387efdec908877e0bcaa728b5aeb/
> 
> file-5.33 added optional seccomp support, but the filters did not cover all
> needed syscalls, leading to errors when the freshly built host-file is
> executed as part of the build on distributions with seccomp support (E.G.
> Arch Linux):
> 
> checking for seccomp_init in -lseccomp... yes
> ..
> ../src/file -C -m magic
> make[3]: *** [Makefile:764: magic.mgc] Bad system call
> 
> This has been fixed in file-5.34, but it anyway makes sense to explicitly
> disable libseccomp support for consistency as we do not need it for the host
> build.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/file/file.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] file: explicitly disable libseccomp support for host
  2018-10-08 20:28 [Buildroot] [PATCH] file: explicitly disable libseccomp support for host Peter Korsgaard
  2018-10-09  6:59 ` Thomas Petazzoni
@ 2018-10-21 12:50 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-10-21 12:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/8a2/8a2ea2e4426416447705492237f526fc84b595d7/
 > http://autobuild.buildroot.net/results/a1f/a1f2369d31c2387efdec908877e0bcaa728b5aeb/

 > file-5.33 added optional seccomp support, but the filters did not cover all
 > needed syscalls, leading to errors when the freshly built host-file is
 > executed as part of the build on distributions with seccomp support (E.G.
 > Arch Linux):

 > checking for seccomp_init in -lseccomp... yes
 > ..
 > ../src/file -C -m magic
 > make[3]: *** [Makefile:764: magic.mgc] Bad system call

 > This has been fixed in file-5.34, but it anyway makes sense to explicitly
 > disable libseccomp support for consistency as we do not need it for the host
 > build.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-21 12:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-08 20:28 [Buildroot] [PATCH] file: explicitly disable libseccomp support for host Peter Korsgaard
2018-10-09  6:59 ` Thomas Petazzoni
2018-10-21 12:50 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox