* [Buildroot] [PATCH] poco: disable fpenvironment for soft floating point configuration
@ 2018-10-10 8:22 yegorslists at googlemail.com
2018-10-10 8:47 ` Thomas Petazzoni
2018-10-23 22:53 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: yegorslists at googlemail.com @ 2018-10-10 8:22 UTC (permalink / raw)
To: buildroot
From: Yegor Yefremov <yegorslists@googlemail.com>
Many platforms don't provide all FPU features needed by Poco when
configured for soft floating point in their fenv.h header. So
disable fpenvironment for this configuration to avoid build breakage.
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
package/poco/poco.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/poco/poco.mk b/package/poco/poco.mk
index 018344d5c7..aa96d5127b 100644
--- a/package/poco/poco.mk
+++ b/package/poco/poco.mk
@@ -42,6 +42,11 @@ ifeq ($(BR2_sh4a)$(BR2_nios2),y)
POCO_CONF_OPTS += --no-fpenvironment
endif
+# disable fpenvironment for soft floating point configuration
+ifeq ($(BR2_SOFT_FLOAT),y)
+POCO_CONF_OPTS += --no-fpenvironment
+endif
+
ifeq ($(BR2_STATIC_LIBS),y)
POCO_MAKE_TARGET = static_release
else ifeq ($(BR2_SHARED_LIBS),y)
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] poco: disable fpenvironment for soft floating point configuration
2018-10-10 8:22 [Buildroot] [PATCH] poco: disable fpenvironment for soft floating point configuration yegorslists at googlemail.com
@ 2018-10-10 8:47 ` Thomas Petazzoni
2018-10-23 22:53 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-10-10 8:47 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 10 Oct 2018 10:22:14 +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Many platforms don't provide all FPU features needed by Poco when
> configured for soft floating point in their fenv.h header. So
> disable fpenvironment for this configuration to avoid build breakage.
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> package/poco/poco.mk | 5 +++++
> 1 file changed, 5 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] poco: disable fpenvironment for soft floating point configuration
2018-10-10 8:22 [Buildroot] [PATCH] poco: disable fpenvironment for soft floating point configuration yegorslists at googlemail.com
2018-10-10 8:47 ` Thomas Petazzoni
@ 2018-10-23 22:53 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-10-23 22:53 UTC (permalink / raw)
To: buildroot
>>>>> "yegorslists" == yegorslists <yegorslists@googlemail.com> writes:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> Many platforms don't provide all FPU features needed by Poco when
> configured for soft floating point in their fenv.h header. So
> disable fpenvironment for this configuration to avoid build breakage.
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Committed to 2018.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-23 22:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-10 8:22 [Buildroot] [PATCH] poco: disable fpenvironment for soft floating point configuration yegorslists at googlemail.com
2018-10-10 8:47 ` Thomas Petazzoni
2018-10-23 22:53 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox