* [Buildroot] [PATCH 1/1] pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS
@ 2018-10-11 12:36 Grzegorz Blach
2018-10-11 14:43 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Grzegorz Blach @ 2018-10-11 12:36 UTC (permalink / raw)
To: buildroot
piogpio needs pthreads
Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
---
package/pigpio/Config.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/pigpio/Config.in b/package/pigpio/Config.in
index fee496b2ef..2180ab0de6 100644
--- a/package/pigpio/Config.in
+++ b/package/pigpio/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_PIGPIO
bool "pigpio"
depends on BR2_aarch64 || BR2_arm
+ depends on BR2_TOOLCHAIN_HAS_THREADS
depends on !BR2_STATIC_LIBS
help
Pigpio is a library for the Raspberry Pi which allows
@@ -8,6 +9,6 @@ config BR2_PACKAGE_PIGPIO
http://abyz.me.uk/rpi/pigpio/
-comment "pigpio needs a toolchain w/ dynamic library"
+comment "pigpio needs a toolchain w/ threads, dynamic library"
depends on BR2_aarch64 || BR2_arm
- depends on !BR2_STATIC_LIBS
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS
2018-10-11 12:36 [Buildroot] [PATCH 1/1] pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS Grzegorz Blach
@ 2018-10-11 14:43 ` Thomas Petazzoni
2018-10-11 15:58 ` Grzegorz Blach
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-10-11 14:43 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 11 Oct 2018 14:36:41 +0200, Grzegorz Blach wrote:
> piogpio needs pthreads
>
> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
> ---
> package/pigpio/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks for your patch. When a patch fixes a build issue detected by the
autobuilders, we always add a reference to the autobuilder failure in
the commit log, like this:
"""
Fixes:
http://autobuild.buildroot.net/results/2f64c993db402decf92a5f8010033acdbc6b884f/
"""
I've fixed the commit log with this additional information before
applying, but I wanted to let you know for your future contributions!
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS
2018-10-11 14:43 ` Thomas Petazzoni
@ 2018-10-11 15:58 ` Grzegorz Blach
0 siblings, 0 replies; 3+ messages in thread
From: Grzegorz Blach @ 2018-10-11 15:58 UTC (permalink / raw)
To: buildroot
On 10/11/18 4:43 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 11 Oct 2018 14:36:41 +0200, Grzegorz Blach wrote:
>> piogpio needs pthreads
>>
>> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
>> ---
>> package/pigpio/Config.in | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Thanks for your patch. When a patch fixes a build issue detected by the
> autobuilders, we always add a reference to the autobuilder failure in
> the commit log, like this:
>
> """
> Fixes:
>
> http://autobuild.buildroot.net/results/2f64c993db402decf92a5f8010033acdbc6b884f/
> """
>
> I've fixed the commit log with this additional information before
> applying, but I wanted to let you know for your future contributions!
>
Ok, I'll remember that.
> Thanks,
>
> Thomas
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-11 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-11 12:36 [Buildroot] [PATCH 1/1] pigpio: depends on BR2_TOOLCHAIN_HAS_THREADS Grzegorz Blach
2018-10-11 14:43 ` Thomas Petazzoni
2018-10-11 15:58 ` Grzegorz Blach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox