* [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled
@ 2018-10-12 4:39 Baruch Siach
2018-10-12 4:39 ` [Buildroot] [PATCH 2/2] spandsp: remove redundant --disable-doc Baruch Siach
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Baruch Siach @ 2018-10-12 4:39 UTC (permalink / raw)
To: buildroot
When jpeg is enabled libtiff links with it, but the spandsp configure
test doesn't take that into account, so the configure test fails. Use
pkg-config to add the required tiff dependencies.
Fixes:
http://autobuild.buildroot.net/results/243/243f1d1271a767556e0a4cd56a42fcc8c1a371ed/
http://autobuild.buildroot.net/results/485/48527e144bc4ad3eaab807f302888380bd9e78bb/
http://autobuild.buildroot.net/results/058/05885325ec274cb9860d423c57eed5e7063aedc0/
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/spandsp/spandsp.mk | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/package/spandsp/spandsp.mk b/package/spandsp/spandsp.mk
index 4b1f89cf4b34..fc9db34bfcae 100644
--- a/package/spandsp/spandsp.mk
+++ b/package/spandsp/spandsp.mk
@@ -10,8 +10,9 @@ SPANDSP_SITE = https://www.soft-switch.org/downloads/spandsp/snapshots
SPANDSP_LICENSE = LGPL-2.1 (library), GPL-2.0 (test suite)
SPANDSP_LICENSE_FILES = COPYING
-SPANDSP_DEPENDENCIES = tiff
+SPANDSP_DEPENDENCIES = tiff host-pkgconf
SPANDSP_INSTALL_STAGING = YES
+SPANDSP_CONF_ENV = LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libtiff-4`"
SPANDSP_CONF_OPTS = \
--disable-doc \
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2] spandsp: remove redundant --disable-doc
2018-10-12 4:39 [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Baruch Siach
@ 2018-10-12 4:39 ` Baruch Siach
2018-10-12 19:59 ` Peter Korsgaard
2018-10-12 19:58 ` [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Peter Korsgaard
2018-10-12 20:04 ` Thomas Petazzoni
2 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2018-10-12 4:39 UTC (permalink / raw)
To: buildroot
We pass --disable-doc by default to all autotools packages.
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/spandsp/spandsp.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/spandsp/spandsp.mk b/package/spandsp/spandsp.mk
index fc9db34bfcae..e02c15a77677 100644
--- a/package/spandsp/spandsp.mk
+++ b/package/spandsp/spandsp.mk
@@ -15,7 +15,6 @@ SPANDSP_INSTALL_STAGING = YES
SPANDSP_CONF_ENV = LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libtiff-4`"
SPANDSP_CONF_OPTS = \
- --disable-doc \
--disable-builtin-tiff \
$(if $(BR2_X86_CPU_HAS_MMX),--enable-mmx,--disable-mmx) \
$(if $(BR2_X86_CPU_HAS_SSE),--enable-sse,--disable-sse) \
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled
2018-10-12 4:39 [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Baruch Siach
2018-10-12 4:39 ` [Buildroot] [PATCH 2/2] spandsp: remove redundant --disable-doc Baruch Siach
@ 2018-10-12 19:58 ` Peter Korsgaard
2018-10-12 20:04 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2018-10-12 19:58 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> When jpeg is enabled libtiff links with it, but the spandsp configure
> test doesn't take that into account, so the configure test fails. Use
> pkg-config to add the required tiff dependencies.
> Fixes:
> http://autobuild.buildroot.net/results/243/243f1d1271a767556e0a4cd56a42fcc8c1a371ed/
> http://autobuild.buildroot.net/results/485/48527e144bc4ad3eaab807f302888380bd9e78bb/
> http://autobuild.buildroot.net/results/058/05885325ec274cb9860d423c57eed5e7063aedc0/
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled
2018-10-12 4:39 [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Baruch Siach
2018-10-12 4:39 ` [Buildroot] [PATCH 2/2] spandsp: remove redundant --disable-doc Baruch Siach
2018-10-12 19:58 ` [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Peter Korsgaard
@ 2018-10-12 20:04 ` Thomas Petazzoni
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-10-12 20:04 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 12 Oct 2018 07:39:50 +0300, Baruch Siach wrote:
> -SPANDSP_DEPENDENCIES = tiff
> +SPANDSP_DEPENDENCIES = tiff host-pkgconf
> SPANDSP_INSTALL_STAGING = YES
> +SPANDSP_CONF_ENV = LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs libtiff-4`"
I have to say I continue to dislike such hacks, and would very much
prefer a change to the package configure.ac script to use pkg-config
directly.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-12 20:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-12 4:39 [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Baruch Siach
2018-10-12 4:39 ` [Buildroot] [PATCH 2/2] spandsp: remove redundant --disable-doc Baruch Siach
2018-10-12 19:59 ` Peter Korsgaard
2018-10-12 19:58 ` [Buildroot] [PATCH 1/2] spandsp: fix static build with jpeg enabled Peter Korsgaard
2018-10-12 20:04 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox