* [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick [not found] <20181015190217.GA31890@blarch> @ 2018-10-15 20:15 ` Peter Seiderer 2018-10-15 21:22 ` Alexander 'z33ky' Hirsch 0 siblings, 1 reply; 3+ messages in thread From: Peter Seiderer @ 2018-10-15 20:15 UTC (permalink / raw) To: buildroot Hello Alexander, On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch <1zeeky@gmail.com> wrote: > The Location module for QtQuick depends on this library, which was not > being copied in the build rule. > > Signed-off-by: Alexander 'z33ky' Hirsch <1zeeky@gmail.com> > --- > package/qt5/qt5location/qt5location.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/qt5/qt5location/qt5location.mk b/package/qt5/qt5location/qt5location.mk > index 18253e9..fe26b6e 100644 > --- a/package/qt5/qt5location/qt5location.mk > +++ b/package/qt5/qt5location/qt5location.mk > @@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION > cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib > cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/ > endef Should depend on BR2_PACKAGE_QT5_VERSION_LATEST because the library is not build/installed in the Qt5.6.x case: + ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) > +define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK > + cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib > +endef + endif Thanks for the patch, mind to resend with the changes? Regards, Peter > ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) > define QT5LOCATION_INSTALL_TARGET_EXAMPLES > cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/ > @@ -59,6 +62,7 @@ endef > > define QT5LOCATION_INSTALL_TARGET_CMDS > $(QT5LOCATION_INSTALL_TARGET_POSITION) > + $(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK) > $(QT5LOCATION_INSTALL_TARGET_LOCATION) > $(QT5LOCATION_INSTALL_TARGET_QMLS) > $(QT5LOCATION_INSTALL_TARGET_EXAMPLES) ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick 2018-10-15 20:15 ` [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick Peter Seiderer @ 2018-10-15 21:22 ` Alexander 'z33ky' Hirsch 2018-10-16 21:49 ` Peter Seiderer 0 siblings, 1 reply; 3+ messages in thread From: Alexander 'z33ky' Hirsch @ 2018-10-15 21:22 UTC (permalink / raw) To: buildroot On Mon, 2018-10-15T22:15:54+0200, Peter Seiderer wrote: > Hello Alexander, > > On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch <1zeeky@gmail.com> wrote: > > > The Location module for QtQuick depends on this library, which was not > > being copied in the build rule. > > > > Signed-off-by: Alexander 'z33ky' Hirsch <1zeeky@gmail.com> > > --- > > package/qt5/qt5location/qt5location.mk | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/package/qt5/qt5location/qt5location.mk b/package/qt5/qt5location/qt5location.mk > > index 18253e9..fe26b6e 100644 > > --- a/package/qt5/qt5location/qt5location.mk > > +++ b/package/qt5/qt5location/qt5location.mk > > @@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION > > cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib > > cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/ > > endef > > Should depend on BR2_PACKAGE_QT5_VERSION_LATEST because the library is not > build/installed in the Qt5.6.x case: > > + ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) > > > +define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK > > + cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib > > +endef > > + endif > > Thanks for the patch, mind to resend with the changes? > > Regards, > Peter > > > ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) > > define QT5LOCATION_INSTALL_TARGET_EXAMPLES > > cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/ > > @@ -59,6 +62,7 @@ endef > > > > define QT5LOCATION_INSTALL_TARGET_CMDS > > $(QT5LOCATION_INSTALL_TARGET_POSITION) > > + $(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK) > > $(QT5LOCATION_INSTALL_TARGET_LOCATION) > > $(QT5LOCATION_INSTALL_TARGET_QMLS) > > $(QT5LOCATION_INSTALL_TARGET_EXAMPLES) > Sure, thanks for the review. Wouldn't it be better to check if QT5LOCATION_VERSION >= 5.11 though? That seems to be the version where this library was added. Regards Alexander ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick 2018-10-15 21:22 ` Alexander 'z33ky' Hirsch @ 2018-10-16 21:49 ` Peter Seiderer 0 siblings, 0 replies; 3+ messages in thread From: Peter Seiderer @ 2018-10-16 21:49 UTC (permalink / raw) To: buildroot Hello Alexander, On Mon, 15 Oct 2018 23:22:20 +0200, Alexander 'z33ky' Hirsch <1zeeky@gmail.com> wrote: > On Mon, 2018-10-15T22:15:54+0200, Peter Seiderer wrote: > > Hello Alexander, > > > > On Mon, 15 Oct 2018 21:02:17 +0200, Alexander 'z33ky' Hirsch <1zeeky@gmail.com> wrote: > > > > > The Location module for QtQuick depends on this library, which was not > > > being copied in the build rule. > > > > > > Signed-off-by: Alexander 'z33ky' Hirsch <1zeeky@gmail.com> > > > --- > > > package/qt5/qt5location/qt5location.mk | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/package/qt5/qt5location/qt5location.mk b/package/qt5/qt5location/qt5location.mk > > > index 18253e9..fe26b6e 100644 > > > --- a/package/qt5/qt5location/qt5location.mk > > > +++ b/package/qt5/qt5location/qt5location.mk > > > @@ -44,6 +44,9 @@ define QT5LOCATION_INSTALL_TARGET_LOCATION > > > cp -dpf $(STAGING_DIR)/usr/lib/libQt5Location.so.* $(TARGET_DIR)/usr/lib > > > cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/geoservices $(TARGET_DIR)/usr/lib/qt/plugins/ > > > endef > > > > Should depend on BR2_PACKAGE_QT5_VERSION_LATEST because the library is not > > build/installed in the Qt5.6.x case: > > > > + ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y) > > > > > +define QT5LOCATION_INSTALL_TARGET_POSITION_QUICK > > > + cp -dpf $(STAGING_DIR)/usr/lib/libQt5PositioningQuick.so.* $(TARGET_DIR)/usr/lib > > > +endef > > > > + endif > > > > Thanks for the patch, mind to resend with the changes? > > > > Regards, > > Peter > > > > > ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y) > > > define QT5LOCATION_INSTALL_TARGET_EXAMPLES > > > cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/location $(TARGET_DIR)/usr/lib/qt/examples/ > > > @@ -59,6 +62,7 @@ endef > > > > > > define QT5LOCATION_INSTALL_TARGET_CMDS > > > $(QT5LOCATION_INSTALL_TARGET_POSITION) > > > + $(QT5LOCATION_INSTALL_TARGET_POSITION_QUICK) > > > $(QT5LOCATION_INSTALL_TARGET_LOCATION) > > > $(QT5LOCATION_INSTALL_TARGET_QMLS) > > > $(QT5LOCATION_INSTALL_TARGET_EXAMPLES) > > > > Sure, thanks for the review. > Wouldn't it be better to check if QT5LOCATION_VERSION >= 5.11 though? That seems to be the version where this library was added. In principle your are right with your suggestion, but the current way to express this one in buildroot is the dump BR2_PACKAGE_QT5_VERSION_LATEST check ;-) Regards, Peter > > Regards > Alexander > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-16 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20181015190217.GA31890@blarch>
2018-10-15 20:15 ` [Buildroot] [PATCH 1/1] qt5location: copy PositioningQuick.so* for QtQuick Peter Seiderer
2018-10-15 21:22 ` Alexander 'z33ky' Hirsch
2018-10-16 21:49 ` Peter Seiderer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox