* [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains @ 2018-07-14 17:15 Romain Naour 2018-07-26 18:46 ` Samuel Martin 2018-10-20 18:23 ` Thomas Petazzoni 0 siblings, 2 replies; 4+ messages in thread From: Romain Naour @ 2018-07-14 17:15 UTC (permalink / raw) To: buildroot If a custom external toolchain is used, we can't enable the fortran support. Add a new option for that. Signed-off-by: Romain Naour <romain.naour@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Cc: Samuel Martin <s.martin49@gmail.com> --- .../toolchain-external-custom/Config.in.options | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options index 6a9921c149..5ec3f961a1 100644 --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options @@ -401,6 +401,14 @@ config BR2_TOOLCHAIN_EXTERNAL_CXX support. If you don't know, leave the default value, Buildroot will tell you if it's correct or not. +config BR2_TOOLCHAIN_EXTERNAL_FORTRAN + bool "Toolchain has Fortran support?" + select BR2_TOOLCHAIN_HAS_FORTRAN + help + Select this option if your external toolchain has Fortran + support. If you don't know, leave the default value, + Buildroot will tell you if it's correct or not. + config BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS string "Extra toolchain libraries to be copied to target" help -- 2.14.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains 2018-07-14 17:15 [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains Romain Naour @ 2018-07-26 18:46 ` Samuel Martin 2018-10-20 18:05 ` Romain Naour 2018-10-20 18:23 ` Thomas Petazzoni 1 sibling, 1 reply; 4+ messages in thread From: Samuel Martin @ 2018-07-26 18:46 UTC (permalink / raw) To: buildroot Hi Romain, Sorry for the late response. :s On Sat, Jul 14, 2018 at 7:15 PM, Romain Naour <romain.naour@gmail.com> wrote: > If a custom external toolchain is used, we can't enable the fortran > support. Add a new option for that. Indeed, it is a long-time limitation of using buildroot toolchain as external ones, all options are not necessarily available in the external toolchain backend. :-/ > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Samuel Martin <s.martin49@gmail.com> > --- > .../toolchain-external-custom/Config.in.options | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options > index 6a9921c149..5ec3f961a1 100644 > --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options > +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options > @@ -401,6 +401,14 @@ config BR2_TOOLCHAIN_EXTERNAL_CXX > support. If you don't know, leave the default value, > Buildroot will tell you if it's correct or not. > > +config BR2_TOOLCHAIN_EXTERNAL_FORTRAN > + bool "Toolchain has Fortran support?" > + select BR2_TOOLCHAIN_HAS_FORTRAN > + help > + Select this option if your external toolchain has Fortran > + support. If you don't know, leave the default value, > + Buildroot will tell you if it's correct or not. > + In the gcc package, there is some extra checks for fortran with libquadmath when available (which depends on the target architecture). So, I wonder whether it should be sensitive to libquadmath (so wchar) on the relevant architectures. > config BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS > string "Extra toolchain libraries to be copied to target" > help > -- > 2.14.4 > Regards, -- Samuel ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains 2018-07-26 18:46 ` Samuel Martin @ 2018-10-20 18:05 ` Romain Naour 0 siblings, 0 replies; 4+ messages in thread From: Romain Naour @ 2018-10-20 18:05 UTC (permalink / raw) To: buildroot Hi Samuel, Le 26/07/2018 ? 20:46, Samuel Martin a ?crit?: > Hi Romain, > > Sorry for the late response. :s Ctrl-c Ctrl-v :s > > On Sat, Jul 14, 2018 at 7:15 PM, Romain Naour <romain.naour@gmail.com> wrote: >> If a custom external toolchain is used, we can't enable the fortran >> support. Add a new option for that. > > Indeed, it is a long-time limitation of using buildroot toolchain as > external ones, all options are not necessarily available in the > external toolchain backend. :-/ > >> >> Signed-off-by: Romain Naour <romain.naour@gmail.com> >> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> >> Cc: Samuel Martin <s.martin49@gmail.com> >> --- >> .../toolchain-external-custom/Config.in.options | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options >> index 6a9921c149..5ec3f961a1 100644 >> --- a/toolchain/toolchain-external/toolchain-external-custom/Config.in.options >> +++ b/toolchain/toolchain-external/toolchain-external-custom/Config.in.options >> @@ -401,6 +401,14 @@ config BR2_TOOLCHAIN_EXTERNAL_CXX >> support. If you don't know, leave the default value, >> Buildroot will tell you if it's correct or not. >> >> +config BR2_TOOLCHAIN_EXTERNAL_FORTRAN >> + bool "Toolchain has Fortran support?" >> + select BR2_TOOLCHAIN_HAS_FORTRAN >> + help >> + Select this option if your external toolchain has Fortran >> + support. If you don't know, leave the default value, >> + Buildroot will tell you if it's correct or not. >> + > > In the gcc package, there is some extra checks for fortran with > libquadmath when available (which depends on the target architecture). > So, I wonder whether it should be sensitive to libquadmath (so wchar) > on the relevant architectures. Indeed, I added: config BR2_TOOLCHAIN_EXTERNAL_FORTRAN bool "Toolchain has Fortran support?" # on architecture building libquadmath, wchar is required depends on !BR2_TOOLCHAIN_HAS_LIBQUADMATH || \ (BR2_TOOLCHAIN_HAS_LIBQUADMATH && BR2_USE_WCHAR) select BR2_TOOLCHAIN_HAS_FORTRAN help Select this option if your external toolchain has Fortran support. If you don't know, leave the default value, Buildroot will tell you if it's correct or not. comment "Fortran support needs a toolchain w/ wchar" depends on BR2_TOOLCHAIN_HAS_LIBQUADMATH depends on !BR2_USE_WCHAR # libquadmath I'll send a v2. Best regards, Romain > >> config BR2_TOOLCHAIN_EXTRA_EXTERNAL_LIBS >> string "Extra toolchain libraries to be copied to target" >> help >> -- >> 2.14.4 >> > > Regards, > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains 2018-07-14 17:15 [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains Romain Naour 2018-07-26 18:46 ` Samuel Martin @ 2018-10-20 18:23 ` Thomas Petazzoni 1 sibling, 0 replies; 4+ messages in thread From: Thomas Petazzoni @ 2018-10-20 18:23 UTC (permalink / raw) To: buildroot Hello, On Sat, 14 Jul 2018 19:15:42 +0200, Romain Naour wrote: > If a custom external toolchain is used, we can't enable the fortran > support. Add a new option for that. > > Signed-off-by: Romain Naour <romain.naour@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > Cc: Samuel Martin <s.martin49@gmail.com> > --- > .../toolchain-external-custom/Config.in.options | 8 ++++++++ > 1 file changed, 8 insertions(+) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-20 18:23 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-07-14 17:15 [Buildroot] [PATCH] toolchain-external: add fortran support option for custom external toolchains Romain Naour 2018-07-26 18:46 ` Samuel Martin 2018-10-20 18:05 ` Romain Naour 2018-10-20 18:23 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox