Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/2] ell: new package
Date: Thu, 8 Nov 2018 21:43:37 +0100	[thread overview]
Message-ID: <20181108214337.720dc93e@windsurf.home> (raw)
In-Reply-To: <20181105220426.17194-1-ps.report@gmx.net>

Hello,

On Mon,  5 Nov 2018 23:04:25 +0100, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

I've applied, after adjusting two things.

> ---
>  package/Config.in                             |  1 +
>  ...-standard-sigset_t-fixes-musl-compil.patch | 57 +++++++++++++++++++
>  package/ell/Config.in                         | 13 +++++
>  package/ell/ell.hash                          |  5 ++
>  package/ell/ell.mk                            | 27 +++++++++

You forgot to add an entry to the DEVELOPERS file.

> +comment "ell needs a toolchain w/ dynamic library, wchar"
> +	depends on BR2_STATIC_LIBS
> +	depends on !BR2_USE_WCHAR

This should have been:

+comment "ell needs a toolchain w/ dynamic library, wchar"
+       depends on BR2_TOOLCHAIN_HAS_SYNC_4
+       depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR

Applied with those two issues fixed. Thanks!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-11-08 20:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 22:04 [Buildroot] [PATCH v1 1/2] ell: new package Peter Seiderer
2018-11-05 22:04 ` [Buildroot] [PATCH v1 2/2] iwd: " Peter Seiderer
2018-11-08 21:18   ` Thomas Petazzoni
2018-11-08 22:20     ` Peter Seiderer
2018-11-08 20:43 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181108214337.720dc93e@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox